Varun Agrawal
a119eb8e59
Merge pull request #1003 from borglab/fix/change-local-plane-factor-to-shared-noise-model
2022-01-03 09:31:59 -05:00
David Wisth
25c82c9878
change a couple of variables to const
2022-01-03 16:41:21 +11:00
David Wisth
c86e42e8a1
fix constructor documentation
2022-01-03 16:41:04 +11:00
David Wisth
b166985a82
remove unnessecary constructor - use default arguments instead
2022-01-03 16:40:48 +11:00
David Wisth
2151fd3852
change from SharedGaussian to SharedNoiseModel
2022-01-03 16:06:11 +11:00
David Wisth
6af7c3ac29
fix destructor virtual keyword
2022-01-03 16:05:58 +11:00
Frank Dellaert
88c79a2a56
Fixed some examples
2022-01-02 22:48:55 -05:00
Frank Dellaert
8eb623b58f
Added an optional names argument for discrete markdown renderers
2022-01-02 21:34:22 -05:00
Frank Dellaert
6d0c55901c
Global replace to V42
2022-01-02 15:49:47 -05:00
Frank Dellaert
9518346161
Fix unstable c++ examples
2022-01-02 14:59:28 -05:00
Frank Dellaert
55f31ab2d7
Revive BetweenFactorEM, without LieVector
2022-01-02 14:38:20 -05:00
Frank Dellaert
340ac7569d
Removed 2 and 3 key constructors for DecisionTreeFactor because wrapper is awesome!
2021-12-28 13:00:14 -05:00
Frank Dellaert
38f0a40fbc
Fix markdown names (that somehow reverted)
2021-12-25 10:46:49 -05:00
Frank Dellaert
042cb9d902
markdown for DiscreteFactorGraph
2021-12-24 13:27:02 -05:00
Varun Agrawal
d42044f22e
initialize all EmptyCal shared pointers
2021-12-20 21:19:54 -05:00
lcarlone
39286f6672
added clone to play well with gnc
2021-12-19 10:41:07 -05:00
Frank Dellaert
e89a294376
Use DiscreteValues everywhere
2021-12-13 13:46:53 -05:00
Varun Agrawal
3615c4b5ac
Merge pull request #956 from borglab/fix/compiler-warnings-posetopointfactor
2021-12-09 09:37:40 -05:00
Varun Agrawal
b47f46a6f5
Windows Fixes ( #904 )
2021-12-09 09:37:21 -05:00
David Wisth
45d5328457
remove "virtual" keyword for functions with "override"
2021-12-08 21:12:46 +00:00
David Wisth
ab73e03ad4
add override keyword to functions
2021-12-08 18:17:35 +00:00
lcarlone
748b647a79
generalized factor and enabled unit tests
2021-12-07 23:45:33 -05:00
lcarlone
260312af38
Merge branch 'develop' into feature/sphericalCamera
2021-12-04 18:51:16 -05:00
lcarlone
1cd33cb11e
renamed README
2021-12-04 11:51:23 -05:00
Frank Dellaert
58dafd43e9
Fixed up sudoku tests after merge
2021-11-20 16:44:17 -05:00
Frank Dellaert
84014c96c4
Merge branch 'feature/modernize_discrete' into feature/arc_consistency
...
# Conflicts:
# gtsam_unstable/discrete/CSP.h
# gtsam_unstable/discrete/tests/testCSP.cpp
# gtsam_unstable/discrete/tests/testSudoku.cpp
2021-11-20 16:41:38 -05:00
Frank Dellaert
371fe3e865
Fixed all examples
2021-11-20 16:34:53 -05:00
Frank Dellaert
8206d8d09d
Got rid of straggling typedefs
2021-11-20 16:34:44 -05:00
Frank Dellaert
9fe6d23d9f
Got rid of sharedValues
2021-11-20 16:15:05 -05:00
Frank Dellaert
0c6d5d438f
use emplace_shared
2021-11-20 15:52:36 -05:00
Frank Dellaert
ad3225953b
Cleaned up AC1 implementation
2021-11-20 15:52:12 -05:00
Frank Dellaert
23bcf96da4
use emplace_shared
2021-11-20 11:46:32 -05:00
Frank Dellaert
b7f43906bc
Formatting only
2021-11-18 15:12:32 -05:00
Frank Dellaert
dd50975668
Revamped arc consistency
2021-11-18 15:11:47 -05:00
Frank Dellaert
aebcf07ab5
Formatted sudokus better
2021-11-18 11:31:11 -05:00
Frank Dellaert
d27d6b60a7
Formatting with Google style
2021-11-18 10:54:00 -05:00
Jose Luis Blanco-Claraco
744db328e7
Merge pull request #915 from borglab/fix/gcc-Wpedantic-warnings
...
Fix warnings raised by GCC -Wpedactic
2021-11-10 12:24:07 +01:00
Jose Luis Blanco Claraco
582f6914cd
more extra semicolon warnings fixed
2021-11-08 23:07:05 +01:00
Jose Luis Blanco Claraco
94aa96e00a
prefer semicolon in definitions
2021-11-08 22:41:59 +01:00
lcarlone
52fb88abe6
Merge branch 'feature/cameraTemplateForAllSmartFactors' into feature/sphericalCamera
...
# Conflicts:
# gtsam/slam/tests/testSmartProjectionRigFactor.cpp
2021-11-07 18:47:59 -05:00
lcarlone
620f9cb99f
now using shared ptrs
2021-11-07 18:32:43 -05:00
lcarlone
2c2e43ee5b
got rid of second constructor
2021-11-07 18:01:28 -05:00
lcarlone
78a4075a54
applied formatting to modified files
2021-11-07 16:31:48 -05:00
lcarlone
78a8b7dc0e
Merge branch 'feature/cameraTemplateForAllSmartFactors' into feature/sphericalCamera
...
# Conflicts:
# gtsam_unstable/slam/SmartProjectionPoseFactorRollingShutter.h
2021-11-07 15:20:16 -05:00
lcarlone
c105aa4e1e
added intermediate camera variable for clarity
2021-11-07 14:56:06 -05:00
lcarlone
b1baf6c8b3
final cosmetics
2021-11-07 14:50:56 -05:00
lcarlone
2f57a1a307
Merge branch 'feature/cameraTemplateForAllSmartFactors' into feature/sphericalCamera
...
# Conflicts:
# gtsam/slam/SmartProjectionFactorP.h
# gtsam/slam/tests/smartFactorScenarios.h
# gtsam/slam/tests/testSmartProjectionRigFactor.cpp
# gtsam_unstable/slam/SmartProjectionPoseFactorRollingShutter.h
# gtsam_unstable/slam/tests/testSmartProjectionPoseFactorRollingShutter.cpp
2021-11-07 14:23:14 -05:00
lcarlone
e51d10f18c
Merge branch 'develop' into feature/sphericalCamera
...
# Conflicts:
# gtsam/geometry/CameraSet.h
# gtsam_unstable/slam/SmartProjectionPoseFactorRollingShutter.h
# gtsam_unstable/slam/tests/testSmartProjectionPoseFactorRollingShutter.cpp
2021-11-07 12:02:33 -05:00
lcarlone
dfd86e8c57
this will need to be applied in #861
2021-11-06 20:00:23 -04:00
lcarlone
29f3af560d
point2 -> measurement
2021-11-06 19:58:33 -04:00
lcarlone
710a64fed4
now throwing exception is params are incorrect
2021-11-06 19:22:28 -04:00
lcarlone
1e384686a1
more const&
2021-11-06 18:34:34 -04:00
lcarlone
459c8f93a5
Merge branch 'develop' into feature/cameraTemplateForAllSmartFactors
2021-11-06 18:12:15 -04:00
lcarlone
dfd4a77454
formatting + const&
2021-11-06 18:11:46 -04:00
lcarlone
c4cd2b5080
fixed formatting (plus small fix: std::vector -> fastVector)
2021-11-06 18:05:58 -04:00
Jose Luis Blanco Claraco
89ce766269
more consistent notation of macros
2021-11-04 07:11:28 +01:00
Jose Luis Blanco Claraco
a61cbdc4d1
Fix warnings raised by GCC -Wpedactic
2021-11-03 17:14:37 +01:00
Varun Agrawal
48cc70c506
generate GTSAM_UNSTABLE Cmake exports
2021-10-23 12:45:21 -04:00
lcarlone
737dcf65e4
all set here!
2021-10-05 23:29:20 -04:00
lcarlone
f0745a9c28
now I only need to fix comments in rolling shutter factor
2021-10-05 23:10:45 -04:00
lcarlone
823a7e7be0
done with tests
2021-10-05 22:53:36 -04:00
lcarlone
0797eae9a8
all tests are passing!
2021-10-05 22:32:02 -04:00
lcarlone
4fd6c2cb5d
bug fix - finalizing last few tests
2021-10-05 22:23:16 -04:00
lcarlone
7988a7050f
changing API for rolling shutter
2021-10-04 21:33:26 -04:00
lcarlone
3758fdaa5d
all tests work except serialization
2021-10-02 23:10:05 -04:00
lcarlone
c4b64877eb
Merge branch 'develop' into feature/cameraTemplateForAllSmartFactors
2021-09-23 09:42:03 -04:00
Varun Agrawal
30ac64accf
Merge pull request #570 from borglab/feature/system-metis-lib
2021-09-18 02:12:43 -04:00
Frank Dellaert
c0262b074c
Address review comments, docs only.
2021-08-29 19:38:20 -04:00
Frank Dellaert
372ae27a5e
Added two ReadMe files to document the plethora of smart factors.
2021-08-29 16:47:32 -04:00
Frank Dellaert
4ef234bbbb
Formatting and better documentation
2021-08-29 16:46:53 -04:00
lcarlone
e9641ba26b
Merge branch 'develop' into feature/cameraTemplateForAllSmartFactors
...
# Conflicts:
# gtsam/geometry/CameraSet.h
2021-08-28 20:09:24 -04:00
Frank Dellaert
bafcde9ee1
Google-style formatting in new files.
2021-08-28 17:36:14 -04:00
Frank Dellaert
d0505d4bc3
Check equals not assert_equal
2021-08-28 17:20:08 -04:00
Frank Dellaert
2b3709ec73
Got rid of SchurComplementAndRearrangeBlocks_3_12_6
2021-08-28 17:19:53 -04:00
Frank Dellaert
0c622294d2
Some formatting
2021-08-28 17:19:19 -04:00
Frank Dellaert
f712d62150
Added override
2021-08-28 16:30:25 -04:00
lcarlone
ff33eb614d
adjusted rolling shutter as well
2021-08-28 01:31:50 -04:00
lcarlone
8af633a991
Merge branch 'feature/rollingShutterSmartFactors' into feature/cameraTemplateForAllSmartFactors
2021-08-26 11:30:59 -04:00
lcarlone
37b001307e
plot twist: templating new factor on CAMERA
2021-08-26 11:29:34 -04:00
Varun Agrawal
4f33cb8835
add guards for system Metis
2021-08-26 02:22:28 -04:00
lcarlone
330a100110
Merge branch 'feature/rollingShutterSmartFactors' into feature/cameraTemplateForAllSmartFactors
2021-08-25 22:22:58 -04:00
lcarlone
db2a9151e5
don't like it - going to create a different class
2021-08-24 20:56:40 -04:00
lcarlone
0a8ebdf8cd
renamed interp param to alpha, improved comments, added cpp
2021-08-13 21:42:09 -04:00
lcarlone
a3ee695b85
reformatted using google style
2021-08-13 20:05:19 -04:00
lcarlone
e4f1bb1bd0
CHECK -> EXPECT
2021-07-23 22:56:37 -04:00
lcarlone
e838d011a6
added timing test
2021-07-23 22:48:16 -04:00
lcarlone
a10d495611
extra cleanup
2021-07-23 22:23:01 -04:00
lcarlone
1f07142b5b
renamed params. need one last test
2021-07-23 19:03:23 -04:00
lcarlone
5350e3463e
done with tests, now I only have to rename gamma to keep consistency with the projection factors RS
2021-07-23 18:58:43 -04:00
lcarlone
81526e8917
fixed another test.
2021-07-23 17:57:24 -04:00
lcarlone
9c288d90ce
working on testing + cosmetic improvements to print for smart factors
2021-07-23 17:48:08 -04:00
lcarlone
a7b7770310
test with EPI fixed
2021-07-23 15:50:16 -04:00
lcarlone
aeb1d35dd6
fixed test with lmk distance
2021-07-23 15:47:07 -04:00
lcarlone
934413522d
fixed another test, few more to go
2021-07-23 15:39:13 -04:00
lcarlone
1c3ff0580b
removed printout, solved CI issue
2021-07-23 00:03:41 -04:00
lcarlone
48a7afa463
removed comments. Code is complete now. Need few more unit tests and we are good to go
2021-07-22 22:35:21 -04:00
lcarlone
91a6613d84
moved common function to cameraSet. commented issues with templated calls to functions in cameraSet
2021-07-22 22:31:33 -04:00
lcarlone
477dd5b247
all pass!
2021-07-22 21:49:40 -04:00
lcarlone
d7e8912d6a
all pass!
2021-07-22 21:45:26 -04:00
lcarlone
a439cf0f0f
stuck on compile issue
2021-07-21 23:33:42 -04:00
lcarlone
d4b88ba59a
got to the final monster. Now I need to implement createHessian
2021-07-21 22:46:42 -04:00
lcarlone
e6ff03f73e
jacobians and errors are well tested now
2021-07-21 16:31:45 -04:00
lcarlone
4669213618
jacobians are good to go!
2021-07-21 16:19:44 -04:00
lcarlone
5d55e153f0
yay! error test passes!
2021-07-21 15:10:10 -04:00
lcarlone
6f8d639ab8
finding best way to test RS errors
2021-07-21 14:46:52 -04:00
lcarlone
306393a18c
solidified add and equal
2021-07-21 14:30:55 -04:00
lcarlone
30f304e733
started serious testing: all tests pass for now
2021-07-21 13:58:47 -04:00
lcarlone
02d2d97a8e
added nice test on cheirality exception - done with projectionFactorRollingShutter
2021-07-20 23:04:52 -04:00
lcarlone
a480b2dcfc
all tests are passing!
2021-07-20 22:05:36 -04:00
lcarlone
0d1c3f16ef
everything working out so far with the tests
2021-07-20 21:29:56 -04:00
lcarlone
2812eeb1be
pass on projection factor, but looks great overall
2021-07-20 21:06:51 -04:00
lcarlone
a204f6d508
amended
2021-07-20 20:46:43 -04:00
lcarlone
4c997e5474
removed interp from Pose3, starting to take pass on projection factor and test
2021-07-20 20:46:29 -04:00
lucacarlone
b8fa0ccc6f
Merge branch 'feature/rollingShutterSmartFactors' into rolling_factor
2021-07-20 18:29:10 -04:00
lcarlone
16d624d4e1
now I need to move to testing and interpolation
2021-07-19 17:01:27 -04:00
lcarlone
1e2a1d2591
removed cpp
2021-07-19 16:11:34 -04:00
lcarlone
82844b541c
put in place initial functions
2021-07-19 16:11:18 -04:00
lcarlone
00387b32cd
setting up .h and tests - compiles and tests pass.
2021-07-19 15:30:53 -04:00
lcarlone
cd1d4b4df5
added templates for factors
2021-07-19 14:38:26 -04:00
Varun Agrawal
d5890a2d61
update all the tests
2021-07-10 21:03:15 -04:00
Varun Agrawal
dc8b5e58ff
replaced boost with std for placeholders, bind and function
2021-07-10 21:01:20 -04:00
Akash Patel
5a2ff198f0
Merge branch 'develop' into boost-bind-warn
2021-06-28 10:54:48 -04:00
acxz
944b3aea29
formatting
2021-06-20 20:37:49 -04:00
Akash Patel
7aeb386dbd
formatting
...
remove extraneous `using`
2021-06-20 18:04:28 -04:00
acxz
6dea8667fd
explicitly use boost::placeholders:_X for compilers that do not respect function scope
2021-06-18 13:45:59 -04:00
acxz
650e432f52
update boost::bind usage
...
use <boost/bind/bind.hpp> instead of deprecated <boost/bind.hpp>
use boost::placeholders:: scope in appropriate files
remove and add <boost/bind/bind.hpp> in appropriate files
2021-06-16 00:56:43 -04:00
acxz
ad7d8f183a
use size_t variable type
2021-06-14 16:25:15 -04:00
Milo Knowles
9392bfd1c1
Move MagPoseFactor to gtsam
2021-06-08 18:25:33 -04:00
Varun Agrawal
554009741c
Merge pull request #752 from miloknowles/feature/mag_pose_factor
2021-06-03 11:09:02 -04:00
Milo Knowles
5e2af67a74
Update commment syntax and replace typedef with using
2021-06-01 16:31:20 -04:00
Frank Dellaert
1011055007
Merge pull request #696 from borglab/feature/smartFactorsWithExtrinsicCalibration
...
smart factors with extrinsics calibration
2021-05-27 10:41:33 -04:00
lcarlone
5510b41e31
amended
2021-05-12 19:22:16 -04:00
lcarlone
7d93e6fca0
added comment on example interface
2021-05-12 19:20:21 -04:00
lcarlone
7342438fb3
added GNC example
2021-05-10 10:30:17 -04:00
lcarlone
c163e28c31
addeed gnc example
2021-05-08 17:03:04 -04:00
Varun Agrawal
6c3aca8cac
remove virtual from overridden methods, add virtual destructors to appease compiler
2021-04-30 12:58:52 -04:00
Varun Agrawal
4d6eef2c2f
override print methods and update wrapper
2021-04-29 19:43:27 -04:00
Milo Knowles
f584537412
Improve docs
2021-04-23 10:02:41 -04:00
Milo Knowles
378b379e56
Compute error in the body frame and fix print()
2021-04-23 09:42:07 -04:00
Milo Knowles
0313a56734
Add MagPoseFactor
2021-04-22 16:51:47 -04:00
yotams
d4eaa15280
rolling shutter projection factor
2021-04-22 08:52:28 +03:00
lcarlone
0a08c19847
added comment
2021-04-04 12:07:10 -04:00
lcarlone
10260253b3
trying to fix CI error
2021-04-03 21:01:53 -04:00
lcarlone
6ae3b80bae
fixed glitch highlighted by CI
2021-04-03 18:10:39 -04:00
lcarlone
413b9d8202
cleanup
2021-04-03 17:59:45 -04:00
lcarlone
53e3de3629
improved naming, formatting, comments
2021-04-03 17:45:02 -04:00
lcarlone
71c528a87d
formatting
2021-04-03 17:37:36 -04:00
lcarlone
038c1c0b8e
added extra unit test
2021-04-03 17:33:12 -04:00
lcarlone
282aa1a0a9
Merge branch 'develop' into feature/smartFactorsWithExtrinsicCalibration
2021-04-03 17:16:04 -04:00
lcarlone
0c865fa52a
removed extra "else"
2021-03-29 23:00:38 -04:00
lcarlone
5677bdb6c1
need to clean up templates and remove 2 redundant lines
2021-03-29 22:58:29 -04:00
lcarlone
2e1ed2c852
1 test to go!
2021-03-28 20:07:29 -04:00
lcarlone
2c1b780a4f
2 tests to go
2021-03-28 20:03:02 -04:00
lcarlone
b10a9d245b
getting ready to enable monocular operation
2021-03-28 18:42:20 -04:00
lcarlone
81aad1977c
works now!!
2021-03-27 23:03:05 -04:00
lcarlone
8ca3d475c8
now I have a working prototype!
2021-03-27 22:28:35 -04:00
lcarlone
8b4a74efff
test still failing
2021-03-26 22:33:15 -04:00
lcarlone
e8db2b6b9b
getting better
2021-03-26 20:04:42 -04:00
Milo Knowles
1f12f82e01
Fix Rot3::LocalCoordinates runtime error when using Cayley map
2021-03-26 17:29:47 -04:00
lcarlone
ec047ccd08
moving to more appropriate construction of Hessian
2021-03-26 17:25:27 -04:00
Milo Knowles
a0ff5e3886
Add LocalCoordinates() to ProductLieGroup and remove unnecessary <Eigen/Core> include to reduce compile memory
2021-03-26 14:36:43 -04:00
Milo Knowles
909b5500f8
Fix incorrect Vector dimension that was causing CI failures
2021-03-26 11:26:27 -04:00
Milo Knowles
05fad78ce9
Switch to cleaner T::Logmap
2021-03-26 10:09:05 -04:00
Milo Knowles
74b92efd89
Add constructor tests and extend tests to Pose2
2021-03-26 09:55:25 -04:00
Milo Knowles
ef2cd5dab5
Fix x/y mismatch in unit tests
2021-03-26 08:59:44 -04:00
lcarlone
b3c828f8d2
amended
2021-03-25 21:42:28 -04:00
lcarlone
7c052ff48a
fixed print, removed cout, test still failing
2021-03-25 21:37:13 -04:00
lcarlone
4df78be0f0
Merge branch 'develop' into feature/smartFactorsWithExtrinsicCalibration
2021-03-22 19:19:23 -04:00
lcarlone
00eee7cd19
removed tests that are not applicable - merging to develop now
2021-03-22 19:18:44 -04:00
lcarlone
d8eeaf9cb3
adding test with single key
2021-03-22 19:16:31 -04:00
Milo Knowles
4b29c0370d
Prefer localCoordinates over logmap
2021-03-21 20:46:26 -04:00
lcarlone
3d1c170860
fixed optimization test: now we have to (i) allow reuse of same calibration, (ii) enable all other tests, (iii) remove cout
2021-03-21 19:39:37 -04:00
lcarlone
7a30d8b4d4
trying to fix crucial test
2021-03-21 19:34:21 -04:00
lcarlone
483a1995ba
solving key problem
2021-03-21 19:12:40 -04:00
Milo Knowles
43c9f2ba26
Change mask to indices and update factor docstring
2021-03-21 17:20:43 -04:00
Milo Knowles
593e6e975d
Correct Jacobian in PartialPriorFactor, modify derived factors for compatibility
2021-03-21 17:10:00 -04:00
Milo Knowles
e6b7d9f133
Add successful unit test for identity pose
2021-03-20 17:57:10 -04:00
Milo Knowles
075293cf83
Three examples of failing PartialPriorFactor<Pose3> Jacobians
2021-03-20 17:44:03 -04:00
lcarlone
2dc908c986
working on new sym matrix
2021-03-19 23:09:26 -04:00
lcarlone
6d118da82d
still segfaults
2021-03-14 22:43:53 -04:00
Varun Agrawal
436c8fa436
Merge pull request #711 from borglab/feature/matlab-wrap
2021-03-14 11:13:44 -04:00
lcarlone
e571d2c188
debugging jacobians
2021-03-13 23:49:33 -05:00
lcarlone
2132778edc
pipeline up and running, need to fix Jacobians next, then Schur complement
2021-03-13 22:34:37 -05:00
lcarlone
dbc10ff227
isolated schur complement!
2021-03-13 21:51:39 -05:00
lcarlone
0161047427
trying to figure out jacobians
2021-03-13 19:19:12 -05:00
lcarlone
8a37a86441
test failure: now we can start computing jacobians
2021-03-13 18:12:12 -05:00
lcarlone
c1da490c2d
got it!
2021-03-13 18:10:03 -05:00
lcarlone
0194e3df94
fixed unit test
2021-03-13 17:55:24 -05:00
lcarlone
f234ad516e
moving to noisy tests
2021-03-13 17:49:08 -05:00
lcarlone
f0b5b244ad
moving to other tests
2021-03-13 17:40:53 -05:00
lcarlone
0c50c963a1
error computation also looks fine!
2021-03-13 17:36:53 -05:00
lcarlone
c965ce6be0
fixed equals
2021-03-13 17:20:39 -05:00
lcarlone
266d8248d0
simple tests are passing, but now we start on the serious ones
2021-03-13 14:03:10 -05:00
lcarlone
273d2da567
compiles and all tests pass!!
2021-03-13 13:54:23 -05:00
lcarlone
f84e1750ea
done factor!
2021-03-13 13:50:47 -05:00
lcarlone
bc8866bd9e
created .h
2021-03-13 13:21:43 -05:00
lcarlone
f7a84ff9f3
added test
2021-03-13 12:46:18 -05:00
Varun Agrawal
f03b12e420
Make matlab wrapping rely completely on the wrap project
2021-03-09 16:10:08 -05:00
John Lambert
b105b8fe95
Merge branch 'develop' of https://github.com/borglab/gtsam into sim3-alignment
2021-03-05 14:38:14 -05:00
John Lambert
98faf54f9b
move unit test out of gtsam unstable
2021-02-24 22:12:00 -05:00