6f8d639ab8
finding best way to test RS errors
2021-07-21 14:46:52 -04:00
306393a18c
solidified add and equal
2021-07-21 14:30:55 -04:00
30f304e733
started serious testing: all tests pass for now
2021-07-21 13:58:47 -04:00
02d2d97a8e
added nice test on cheirality exception - done with projectionFactorRollingShutter
2021-07-20 23:04:52 -04:00
a480b2dcfc
all tests are passing!
2021-07-20 22:05:36 -04:00
0d1c3f16ef
everything working out so far with the tests
2021-07-20 21:29:56 -04:00
2812eeb1be
pass on projection factor, but looks great overall
2021-07-20 21:06:51 -04:00
a204f6d508
amended
2021-07-20 20:46:43 -04:00
4c997e5474
removed interp from Pose3, starting to take pass on projection factor and test
2021-07-20 20:46:29 -04:00
b8fa0ccc6f
Merge branch 'feature/rollingShutterSmartFactors' into rolling_factor
2021-07-20 18:29:10 -04:00
16d624d4e1
now I need to move to testing and interpolation
2021-07-19 17:01:27 -04:00
1e2a1d2591
removed cpp
2021-07-19 16:11:34 -04:00
82844b541c
put in place initial functions
2021-07-19 16:11:18 -04:00
00387b32cd
setting up .h and tests - compiles and tests pass.
2021-07-19 15:30:53 -04:00
cd1d4b4df5
added templates for factors
2021-07-19 14:38:26 -04:00
d5890a2d61
update all the tests
2021-07-10 21:03:15 -04:00
dc8b5e58ff
replaced boost with std for placeholders, bind and function
2021-07-10 21:01:20 -04:00
944b3aea29
formatting
2021-06-20 20:37:49 -04:00
7aeb386dbd
formatting
...
remove extraneous `using`
2021-06-20 18:04:28 -04:00
6dea8667fd
explicitly use boost::placeholders:_X for compilers that do not respect function scope
2021-06-18 13:45:59 -04:00
650e432f52
update boost::bind usage
...
use <boost/bind/bind.hpp> instead of deprecated <boost/bind.hpp>
use boost::placeholders:: scope in appropriate files
remove and add <boost/bind/bind.hpp> in appropriate files
2021-06-16 00:56:43 -04:00
9392bfd1c1
Move MagPoseFactor to gtsam
2021-06-08 18:25:33 -04:00
554009741c
Merge pull request #752 from miloknowles/feature/mag_pose_factor
2021-06-03 11:09:02 -04:00
5e2af67a74
Update commment syntax and replace typedef with using
2021-06-01 16:31:20 -04:00
1011055007
Merge pull request #696 from borglab/feature/smartFactorsWithExtrinsicCalibration
...
smart factors with extrinsics calibration
2021-05-27 10:41:33 -04:00
6c3aca8cac
remove virtual from overridden methods, add virtual destructors to appease compiler
2021-04-30 12:58:52 -04:00
f584537412
Improve docs
2021-04-23 10:02:41 -04:00
378b379e56
Compute error in the body frame and fix print()
2021-04-23 09:42:07 -04:00
0313a56734
Add MagPoseFactor
2021-04-22 16:51:47 -04:00
d4eaa15280
rolling shutter projection factor
2021-04-22 08:52:28 +03:00
0a08c19847
added comment
2021-04-04 12:07:10 -04:00
10260253b3
trying to fix CI error
2021-04-03 21:01:53 -04:00
6ae3b80bae
fixed glitch highlighted by CI
2021-04-03 18:10:39 -04:00
413b9d8202
cleanup
2021-04-03 17:59:45 -04:00
53e3de3629
improved naming, formatting, comments
2021-04-03 17:45:02 -04:00
71c528a87d
formatting
2021-04-03 17:37:36 -04:00
038c1c0b8e
added extra unit test
2021-04-03 17:33:12 -04:00
282aa1a0a9
Merge branch 'develop' into feature/smartFactorsWithExtrinsicCalibration
2021-04-03 17:16:04 -04:00
0c865fa52a
removed extra "else"
2021-03-29 23:00:38 -04:00
5677bdb6c1
need to clean up templates and remove 2 redundant lines
2021-03-29 22:58:29 -04:00
2e1ed2c852
1 test to go!
2021-03-28 20:07:29 -04:00
2c1b780a4f
2 tests to go
2021-03-28 20:03:02 -04:00
b10a9d245b
getting ready to enable monocular operation
2021-03-28 18:42:20 -04:00
81aad1977c
works now!!
2021-03-27 23:03:05 -04:00
8ca3d475c8
now I have a working prototype!
2021-03-27 22:28:35 -04:00
8b4a74efff
test still failing
2021-03-26 22:33:15 -04:00
e8db2b6b9b
getting better
2021-03-26 20:04:42 -04:00
1f12f82e01
Fix Rot3::LocalCoordinates runtime error when using Cayley map
2021-03-26 17:29:47 -04:00
ec047ccd08
moving to more appropriate construction of Hessian
2021-03-26 17:25:27 -04:00
a0ff5e3886
Add LocalCoordinates() to ProductLieGroup and remove unnecessary <Eigen/Core> include to reduce compile memory
2021-03-26 14:36:43 -04:00
909b5500f8
Fix incorrect Vector dimension that was causing CI failures
2021-03-26 11:26:27 -04:00
05fad78ce9
Switch to cleaner T::Logmap
2021-03-26 10:09:05 -04:00
74b92efd89
Add constructor tests and extend tests to Pose2
2021-03-26 09:55:25 -04:00
ef2cd5dab5
Fix x/y mismatch in unit tests
2021-03-26 08:59:44 -04:00
b3c828f8d2
amended
2021-03-25 21:42:28 -04:00
7c052ff48a
fixed print, removed cout, test still failing
2021-03-25 21:37:13 -04:00
4df78be0f0
Merge branch 'develop' into feature/smartFactorsWithExtrinsicCalibration
2021-03-22 19:19:23 -04:00
00eee7cd19
removed tests that are not applicable - merging to develop now
2021-03-22 19:18:44 -04:00
d8eeaf9cb3
adding test with single key
2021-03-22 19:16:31 -04:00
4b29c0370d
Prefer localCoordinates over logmap
2021-03-21 20:46:26 -04:00
3d1c170860
fixed optimization test: now we have to (i) allow reuse of same calibration, (ii) enable all other tests, (iii) remove cout
2021-03-21 19:39:37 -04:00
7a30d8b4d4
trying to fix crucial test
2021-03-21 19:34:21 -04:00
483a1995ba
solving key problem
2021-03-21 19:12:40 -04:00
43c9f2ba26
Change mask to indices and update factor docstring
2021-03-21 17:20:43 -04:00
593e6e975d
Correct Jacobian in PartialPriorFactor, modify derived factors for compatibility
2021-03-21 17:10:00 -04:00
e6b7d9f133
Add successful unit test for identity pose
2021-03-20 17:57:10 -04:00
075293cf83
Three examples of failing PartialPriorFactor<Pose3> Jacobians
2021-03-20 17:44:03 -04:00
2dc908c986
working on new sym matrix
2021-03-19 23:09:26 -04:00
6d118da82d
still segfaults
2021-03-14 22:43:53 -04:00
e571d2c188
debugging jacobians
2021-03-13 23:49:33 -05:00
2132778edc
pipeline up and running, need to fix Jacobians next, then Schur complement
2021-03-13 22:34:37 -05:00
dbc10ff227
isolated schur complement!
2021-03-13 21:51:39 -05:00
0161047427
trying to figure out jacobians
2021-03-13 19:19:12 -05:00
8a37a86441
test failure: now we can start computing jacobians
2021-03-13 18:12:12 -05:00
c1da490c2d
got it!
2021-03-13 18:10:03 -05:00
0194e3df94
fixed unit test
2021-03-13 17:55:24 -05:00
f234ad516e
moving to noisy tests
2021-03-13 17:49:08 -05:00
f0b5b244ad
moving to other tests
2021-03-13 17:40:53 -05:00
0c50c963a1
error computation also looks fine!
2021-03-13 17:36:53 -05:00
c965ce6be0
fixed equals
2021-03-13 17:20:39 -05:00
266d8248d0
simple tests are passing, but now we start on the serious ones
2021-03-13 14:03:10 -05:00
273d2da567
compiles and all tests pass!!
2021-03-13 13:54:23 -05:00
f84e1750ea
done factor!
2021-03-13 13:50:47 -05:00
bc8866bd9e
created .h
2021-03-13 13:21:43 -05:00
f7a84ff9f3
added test
2021-03-13 12:46:18 -05:00
f5ff7aa49f
Merge pull request #564 from borglab/fix/planeFactor
...
Fix/plane factor
2021-02-22 23:58:14 -05:00
8f18ce931b
Add inline comments on commented-out unit tests
2021-02-20 23:13:43 +00:00
5b0bd08e7b
small tidy and fix unit tests
2021-02-16 18:21:53 +00:00
960a3e1d8e
Tidy up comments and use cpplint
2021-02-16 11:48:26 +00:00
7480d149c8
Update documentation on new factor
2021-02-15 15:08:57 +00:00
a62bdd45e8
Add new oriented plane 3 factors with local linearisation point
2021-02-15 13:15:11 +00:00
7f80c906c4
Fix override warnings: modernize-use-override
2021-01-28 23:02:13 -05:00
c073473f5b
Merge branch 'develop' of github.com:borglab/gtsam into fix/warning_in_smart_factor
...
* 'develop' of github.com:borglab/gtsam: (65 commits)
type in test hidden by duplicate test values
auto and reserve fewer
replace sparseJacobian with "fast" version
disambiguate double template >>
fix comment and remove whitespace diff
remove InPlace jacobian from .h file
remove unnecessary function overloads and typedefs
use standard function to check for empty string
fix bug in Pose2 print
formatting
revert Matrix.h
remove templating while maintaining efficiency Templating still used in cpp file for generic-ness, but not exposed anymore
move SparseMatrixBoostTriplets typedef to gfg
add known issues section with info about march=native
Revert "upgrade minimum required Boost version to 1.67."
upgrade minimum required Boost version to 1.67.
populate sparse matrix with `insert` rather than `setFromTriplets` About 5% speed improvement.
eliminate copy/pasta from SparseEigen with generic version of sparseJacobian
more generic sparseJacobianInPlace function
add generic optional parameters to sparseJacobian Also, the unit test changed due to a 0 entry that was previously wrongly included in the b-column of the sparse representation.
...
2021-01-28 22:49:06 -05:00
241d82dbf7
Fix can be marked override warning
2021-01-22 00:27:32 -05:00
f831bfd62e
add override and formatting
2021-01-19 15:40:37 -05:00
96dc9bfa5a
Fix formatting
2021-01-18 14:48:19 -05:00
5ad65ed46c
Fix formatting
2021-01-18 14:41:59 -05:00
19b7312edb
Split .h/.cpp, use const& (WIP)
2021-01-17 11:08:53 -05:00
cb3a766b30
uncomment calibration applications
2020-11-30 13:19:13 -05:00
2703307a43
deprecate SimpleCamera tests
2020-11-30 07:01:58 -05:00
5a6bfed42c
Fix override warning
2020-08-18 23:19:56 -04:00
e22c24eff5
Removed superfluous size, added doxygen partitions
2020-08-01 15:43:21 -04:00
0198c648e3
Fix all new gcc warnings/errors: make explicit virtual/override methods.
...
Rules are:
- use "virtual" in base classes only.
- use "override" in all derived classes.
2020-07-26 11:20:42 +02:00
0ee4e3b77e
Add more documentation and clang-format
2020-06-20 09:45:24 +10:00
c422815b94
Update incorrect test name
2020-06-20 09:03:17 +10:00
0a44315a7f
Add Pose3-Point3 factor
2020-06-20 08:46:06 +10:00
93ba522582
Remove any unnecessary PriorFactor.h includes
2020-04-12 13:42:02 -04:00
211119b00e
Replace addPrior<> with addPrior
2020-04-12 13:10:09 -04:00
aa3ac32235
Change all old cases of graph.emplace_shared<PriorFactor<...>>(...) and graph.add(PriorFactor<...>(...)) to graph.addPrior<...>(...). Removed unnecessary PriorFactor.h includes.
2020-04-11 20:09:54 -04:00
f4525b51e4
Change PriorFactor includes from gtsam/slam to gtsam/nonlinear
2020-04-10 22:26:22 -04:00
76b29b78af
Prefer C++11 nullptr
2020-04-06 23:31:05 +02:00
9361d5b491
Merge pull request #260 from borglab/fix/cmake-wrapper-warnings
...
Fixed some wrapper warnings
2020-03-29 19:26:58 -04:00
0c2890b815
Merge pull request #252 from borglab/feature/TOA
...
Time of arrival measurements
2020-03-25 16:41:02 -04:00
ca4daa0894
Merge pull request #258 from borglab/deprecate-simplecamera
...
Replace SimpleCamera with PinholeCameraCal3_S2
2020-03-23 08:08:18 -04:00
d2d5ce1166
Eigen alignment
2020-03-22 12:46:25 -04:00
cd318b2295
Python example and necessary wrapper gymnastics
2020-03-18 17:36:42 -04:00
f3865539c6
Refactor TOAFactor and test
2020-03-18 15:44:33 -04:00
2087075ee7
Transitioned toa method to a functor
2020-03-17 14:34:11 -04:00
8e81890f9b
eradicated last vestiges of boost/random in gtsam_unstable
2020-02-28 07:21:54 -08:00
d9923fc3cc
replaced/appended all calls to SimpleCamera with PinholeCameraCal3_S2
2020-02-21 19:42:55 -05:00
a614e5efa1
Merge pull request #115 from borglab/fix/absolute-value
...
C++11 Absolute Value
2019-09-19 07:45:40 -04:00
ff1f37c26f
replaced fabs with c++11 std::abs
2019-09-18 18:30:26 -04:00
4949d6988c
Fix compilation of PartialPriorFactor
2019-09-07 15:48:30 -04:00
52b0579a9b
Consistent dllexport.h across gtsam & gtsam_unstable
2019-07-18 08:22:41 +02:00
c007c7715c
Duplicate measurements are disallowed -> leads to duplicate keys in JacobianFactor
2019-06-11 20:42:35 -04:00
692959f0f3
Fix for issue #38 (gcc specific issue, but fix works for all)
2019-06-11 20:41:56 -04:00
a1096a6f3b
Fix bug: iSAM2 won't update() with smart factors
2019-05-27 12:26:54 +02:00
77d56cb2eb
Add iSAM2+Stereo factor unit test to reveal bug #10
...
fix test
2019-05-27 12:26:53 +02:00
8801de4d63
Pose3 naming convention
2019-05-16 15:06:15 -04:00
b2e5dadcdb
Merge branch 'develop' of https://bitbucket.org/gtborg/gtsam into fix/trailing_whitespaces
...
# Conflicts:
# gtsam/symbolic/tests/testVariableIndex.cpp
# gtsam_unstable/gtsam_unstable.h
# gtsam_unstable/linear/RawQP.cpp
# gtsam_unstable/linear/RawQP.h
2019-05-12 09:26:28 -04:00
1304d26e81
exit()-> throw ( Closes #427 )
2019-04-07 23:59:53 +02:00
1cdc228d6a
remove trailing spaces
2019-02-11 10:58:34 -05:00
fbcfbf0cdd
Made naming convention in wrapper uniform.
...
2D means Pose2 + Point2
3D means Pose3 + Point3
2018-12-31 11:19:46 -05:00
2aa43e11bd
Use KeyVector everywhere to avoid conversions
2018-11-08 10:10:32 -05:00
658ec8c17b
Merge develop into fix/Unit3
...
# Conflicts:
# gtsam_unstable/slam/SmartRangeFactor.h
2018-10-12 23:40:20 -04:00
6c09d8681c
Fixed warning in SmartRangeFactor.h
2018-10-12 19:10:18 -04:00
7da4824568
Fixed remaining lint errors
2018-10-09 10:25:47 -04:00
560ee010c2
Fixed uninitialized problem
2018-10-09 10:25:47 -04:00
a34a9b8ff1
Fixed remaining lint errors
2018-10-09 08:46:30 -04:00
e1466b2609
Fixed uninitialized problem
2018-10-09 08:45:42 -04:00
b04c0bb15d
Fix memory alignment issues
2018-07-13 14:31:02 -04:00
fbb9d3bdda
Merged in feature/heterogeneousSmartFactorNoise (pull request #271 )
...
Feature/heterogeneoussmartfactornoise
Approved-by: Chris Beall
Approved-by: Jing Dong
2017-03-12 05:50:08 +00:00
249d6b0b1b
Replaced graph.push_back with graph.emplace_shared if needed.
2016-10-01 11:17:41 -04:00
c1b00e28b1
created SmartFactorParams class collecting common parameters in smartProjectionFactor and smartStereoProjectFactor classes. This largely reduced copy-paste. SmartStereoProjectionParams is now a typedef
2016-08-14 18:54:00 -04:00
edcf94591d
added functions to get/set smart stereo parameters with unit test
2016-08-06 23:27:54 -04:00
e0869719fa
now SmartFactorBase doesn't know about stereoPoint2 (removed also header). The functionality to check if the right pixel is missing has been moved to SmartStereoProjectionFactor, removing the casting.
2016-08-02 22:56:48 -04:00
a93c1e86f2
Merge remote-tracking branch 'origin/feature/heterogeneousSmartFactorNoise' into feature/heterogeneousSmartFactorNoise
2016-08-02 18:50:54 -04:00
e54159c695
Merge branch 'develop' into feature/heterogeneousSmartFactorNoise
...
# Conflicts:
# gtsam_unstable/slam/SmartStereoProjectionFactor.h
2016-08-02 18:50:18 -04:00
938454916f
improved test, and slightly loosened tolerance when using MKL
2016-07-31 20:10:31 -04:00
9336c0b8c0
added comment and made variables const when possible
2016-07-31 18:47:30 -04:00
f009633384
exposed point status in smart factors to keep uniformity with mono smart factors
2016-07-31 18:33:58 -04:00
6a21f1b730
adapted stereoSmart factors to use "outlier" and "far point" statuses
2016-07-31 18:31:38 -04:00
20c13580cc
deleted unused variables in unit test
2016-07-29 16:34:18 -04:00
50d6532fe1
the ultimate test: smartStereoFactors generalize smartFactors in that they work in the purely monocular case!
2016-07-27 23:48:58 -04:00
a5138bfb46
included body_P_sensor in smartStereoProjectionPoseFactor!
2016-07-25 22:13:25 -04:00
6c163b0a4d
added test which optimize smartStereoFactor with missing measurements (uR)
2016-07-24 19:07:00 -04:00
b90e224f59
added tests for error and triangulation
2016-07-24 18:56:04 -04:00
cd9b4cd5ab
moved common definitions to base class
2016-07-24 18:31:55 -04:00
f2bec78a58
first implementation of smartStereo with possibly left-only pixel measurements
2016-07-24 18:27:20 -04:00
3c15ef5d1e
great simplification in stereo triangulation: converting stereo into a set of monocular cameras, then proceed as in the monocular case
2016-07-24 16:11:07 -04:00
a97502f5a1
Resolved all issues with typedefs
2016-06-06 21:57:52 -07:00
41b091e86f
Chasing down more vector() and Point2 default constructor uses
2016-06-06 00:37:49 -07:00
bdbbe0203d
Derive Point2 from Vector2 and deprecate a number of methods
2016-06-05 23:52:04 -07:00
72fe66d468
Removed headers
2016-05-22 14:22:36 -07:00
3b7c57aedf
Replaced BOOSE_FOREACH with for in gtsam_unstable folder.
2016-05-20 23:41:41 -04:00
b6728ef620
Deprecated Vector ones(size_t n). All unit tests pass.
2016-04-15 17:30:54 -04:00
76308a5d46
Deprecated Vector zero(size_t n). All unit tests pass.
2016-04-15 16:54:46 -04:00
652edb6e61
Merged in fix/DeprecateMatrixFunctions (pull request #243 )
...
Fix/deprecatematrixfunctions
2016-04-12 23:53:42 -07:00
70b2aab352
Deprecated all inline functions in Matrix.h.
2016-04-11 15:11:29 -04:00
a3b66a94ea
Cleaned up Double_ problems
2016-04-10 19:01:14 -07:00
ae19e078c7
Changed argument and implementation of correct() in Mechanization_bRn2
2016-03-12 20:44:05 -05:00
97e26cc365
Deprecated sub() in Vector.h.
2016-03-11 20:30:19 -05:00
5502691022
Deprecated norm_2() in Vector.h
2016-03-11 19:34:49 -05:00
2f146e85ef
Deprecated esqrt() from Vector.h.
2016-03-11 14:34:19 -05:00
7d0b562908
Fixed two missed replacements of cwiseProduct() with array().square().
2016-03-05 21:20:32 -05:00
caa45ad67b
Replaced cwiseProduct() with array().square(). Killed deprecated comments.
2016-03-05 21:08:24 -05:00
22c3af906e
Deprecated emul() in Vector.h.
2016-03-05 18:49:34 -05:00
0372a959ee
Many small improvements, bug-fixes, and tests
2016-02-24 11:01:19 -08:00
1c920967d9
No more use of vector() or default constructor
2016-02-12 00:06:07 -08:00
56dbf487ee
Fixed more default constructor calls
2016-02-11 23:31:17 -08:00
2060b09a2b
Avoid calling default constructors and/or vector
2016-02-11 19:03:11 -08:00
94ccf98985
Avoid default constructor in tests
2016-02-11 19:01:54 -08:00
4d93a33f61
Static methods should be uppercase.
2016-01-26 23:09:58 -08:00
04bcf26aa6
Explicitly cast optional to bool
2015-10-20 14:44:00 -04:00
aa2ffcd118
Merge branch 'develop' into feature/cleanup_ImuFactor
2015-09-17 17:42:38 -04:00
29ad9478f7
Move noise model initialization from add function into constructor. Can only have one noise model per factor anyway
2015-08-26 13:02:39 -04:00
0503df31fa
Relax tolerance to 1e-6 for MKL/quaternion test, and fix up documentation a bit.
2015-08-25 12:14:52 -04:00
6a5147b5b5
Merged in fix/SmartStereo (pull request #181 )
...
Fix/smartstereo
2015-08-25 09:51:59 -04:00
8b4228fa56
Make smart parameters public. Now easier to set, and it's sufficient for this to be const within the smart factor itself!
2015-08-19 10:58:35 -04:00
c8df985e2f
Relax test tolerance a bit for quaternion mode
2015-08-19 07:30:14 -04:00
1727b60728
Fixed and cleaned up unit test
2015-08-19 00:11:35 -04:00
123c55f0d7
respect triangulation.enableEPI flag in SmartStereo factor
2015-07-29 14:05:48 -04:00
fd1e41a9e6
remove calibration template from SmartStereoProjectionPoseFactor
2015-07-28 15:12:02 -04:00
748877ff7e
remove calibration template from SmartStereoProjectionFactor
2015-07-28 14:56:45 -04:00
db64b48fda
tests pass
2015-07-28 14:48:53 -04:00
da9078cf3b
add nonlinear triangulation back. Some unit tests fail again
2015-07-27 23:27:20 -04:00
1a47a334de
Deal with changes in Rot3
2015-07-21 11:23:42 -07:00
7ae31bd8e7
delete some unused stuff
2015-07-20 11:43:57 -04:00
b5a978c534
improve dynamic outlier rejection test
2015-07-19 21:01:14 -04:00
fcc9ac2669
remove extra cout
2015-07-19 20:39:34 -04:00
lcarlone
lucacarlone
Varun Agrawal
acxz
Milo Knowles
Frank Dellaert
yotams
David Wisth
Toni
Frank Dellaert
Jose Luis Blanco Claraco
alescontrela
Fan Jiang
Jose Luis Blanco-Claraco
Duy-Nguyen Ta
Duy-Nguyen Ta
AndreiCostinescu
Sean Bowman
Yao Chen
Frank Dellaert
dellaert
Yao Chen
Alex Hagiopol
cbeall3
Duy-Nguyen Ta