29f3af560d
point2 -> measurement
2021-11-06 19:58:33 -04:00
710a64fed4
now throwing exception is params are incorrect
2021-11-06 19:22:28 -04:00
1e384686a1
more const&
2021-11-06 18:34:34 -04:00
dfd4a77454
formatting + const&
2021-11-06 18:11:46 -04:00
c4cd2b5080
fixed formatting (plus small fix: std::vector -> fastVector)
2021-11-06 18:05:58 -04:00
89ce766269
more consistent notation of macros
2021-11-04 07:11:28 +01:00
a61cbdc4d1
Fix warnings raised by GCC -Wpedactic
2021-11-03 17:14:37 +01:00
737dcf65e4
all set here!
2021-10-05 23:29:20 -04:00
f0745a9c28
now I only need to fix comments in rolling shutter factor
2021-10-05 23:10:45 -04:00
823a7e7be0
done with tests
2021-10-05 22:53:36 -04:00
0797eae9a8
all tests are passing!
2021-10-05 22:32:02 -04:00
4fd6c2cb5d
bug fix - finalizing last few tests
2021-10-05 22:23:16 -04:00
7988a7050f
changing API for rolling shutter
2021-10-04 21:33:26 -04:00
3758fdaa5d
all tests work except serialization
2021-10-02 23:10:05 -04:00
c0262b074c
Address review comments, docs only.
2021-08-29 19:38:20 -04:00
372ae27a5e
Added two ReadMe files to document the plethora of smart factors.
2021-08-29 16:47:32 -04:00
4ef234bbbb
Formatting and better documentation
2021-08-29 16:46:53 -04:00
e9641ba26b
Merge branch 'develop' into feature/cameraTemplateForAllSmartFactors
...
# Conflicts:
# gtsam/geometry/CameraSet.h
2021-08-28 20:09:24 -04:00
bafcde9ee1
Google-style formatting in new files.
2021-08-28 17:36:14 -04:00
d0505d4bc3
Check equals not assert_equal
2021-08-28 17:20:08 -04:00
2b3709ec73
Got rid of SchurComplementAndRearrangeBlocks_3_12_6
2021-08-28 17:19:53 -04:00
0c622294d2
Some formatting
2021-08-28 17:19:19 -04:00
f712d62150
Added override
2021-08-28 16:30:25 -04:00
ff33eb614d
adjusted rolling shutter as well
2021-08-28 01:31:50 -04:00
8af633a991
Merge branch 'feature/rollingShutterSmartFactors' into feature/cameraTemplateForAllSmartFactors
2021-08-26 11:30:59 -04:00
37b001307e
plot twist: templating new factor on CAMERA
2021-08-26 11:29:34 -04:00
330a100110
Merge branch 'feature/rollingShutterSmartFactors' into feature/cameraTemplateForAllSmartFactors
2021-08-25 22:22:58 -04:00
db2a9151e5
don't like it - going to create a different class
2021-08-24 20:56:40 -04:00
0a8ebdf8cd
renamed interp param to alpha, improved comments, added cpp
2021-08-13 21:42:09 -04:00
a3ee695b85
reformatted using google style
2021-08-13 20:05:19 -04:00
e4f1bb1bd0
CHECK -> EXPECT
2021-07-23 22:56:37 -04:00
e838d011a6
added timing test
2021-07-23 22:48:16 -04:00
a10d495611
extra cleanup
2021-07-23 22:23:01 -04:00
1f07142b5b
renamed params. need one last test
2021-07-23 19:03:23 -04:00
5350e3463e
done with tests, now I only have to rename gamma to keep consistency with the projection factors RS
2021-07-23 18:58:43 -04:00
81526e8917
fixed another test.
2021-07-23 17:57:24 -04:00
9c288d90ce
working on testing + cosmetic improvements to print for smart factors
2021-07-23 17:48:08 -04:00
a7b7770310
test with EPI fixed
2021-07-23 15:50:16 -04:00
aeb1d35dd6
fixed test with lmk distance
2021-07-23 15:47:07 -04:00
934413522d
fixed another test, few more to go
2021-07-23 15:39:13 -04:00
1c3ff0580b
removed printout, solved CI issue
2021-07-23 00:03:41 -04:00
48a7afa463
removed comments. Code is complete now. Need few more unit tests and we are good to go
2021-07-22 22:35:21 -04:00
91a6613d84
moved common function to cameraSet. commented issues with templated calls to functions in cameraSet
2021-07-22 22:31:33 -04:00
477dd5b247
all pass!
2021-07-22 21:49:40 -04:00
d7e8912d6a
all pass!
2021-07-22 21:45:26 -04:00
a439cf0f0f
stuck on compile issue
2021-07-21 23:33:42 -04:00
d4b88ba59a
got to the final monster. Now I need to implement createHessian
2021-07-21 22:46:42 -04:00
e6ff03f73e
jacobians and errors are well tested now
2021-07-21 16:31:45 -04:00
4669213618
jacobians are good to go!
2021-07-21 16:19:44 -04:00
5d55e153f0
yay! error test passes!
2021-07-21 15:10:10 -04:00
6f8d639ab8
finding best way to test RS errors
2021-07-21 14:46:52 -04:00
306393a18c
solidified add and equal
2021-07-21 14:30:55 -04:00
30f304e733
started serious testing: all tests pass for now
2021-07-21 13:58:47 -04:00
02d2d97a8e
added nice test on cheirality exception - done with projectionFactorRollingShutter
2021-07-20 23:04:52 -04:00
a480b2dcfc
all tests are passing!
2021-07-20 22:05:36 -04:00
0d1c3f16ef
everything working out so far with the tests
2021-07-20 21:29:56 -04:00
2812eeb1be
pass on projection factor, but looks great overall
2021-07-20 21:06:51 -04:00
a204f6d508
amended
2021-07-20 20:46:43 -04:00
4c997e5474
removed interp from Pose3, starting to take pass on projection factor and test
2021-07-20 20:46:29 -04:00
b8fa0ccc6f
Merge branch 'feature/rollingShutterSmartFactors' into rolling_factor
2021-07-20 18:29:10 -04:00
16d624d4e1
now I need to move to testing and interpolation
2021-07-19 17:01:27 -04:00
1e2a1d2591
removed cpp
2021-07-19 16:11:34 -04:00
82844b541c
put in place initial functions
2021-07-19 16:11:18 -04:00
00387b32cd
setting up .h and tests - compiles and tests pass.
2021-07-19 15:30:53 -04:00
cd1d4b4df5
added templates for factors
2021-07-19 14:38:26 -04:00
d5890a2d61
update all the tests
2021-07-10 21:03:15 -04:00
dc8b5e58ff
replaced boost with std for placeholders, bind and function
2021-07-10 21:01:20 -04:00
944b3aea29
formatting
2021-06-20 20:37:49 -04:00
7aeb386dbd
formatting
...
remove extraneous `using`
2021-06-20 18:04:28 -04:00
6dea8667fd
explicitly use boost::placeholders:_X for compilers that do not respect function scope
2021-06-18 13:45:59 -04:00
650e432f52
update boost::bind usage
...
use <boost/bind/bind.hpp> instead of deprecated <boost/bind.hpp>
use boost::placeholders:: scope in appropriate files
remove and add <boost/bind/bind.hpp> in appropriate files
2021-06-16 00:56:43 -04:00
9392bfd1c1
Move MagPoseFactor to gtsam
2021-06-08 18:25:33 -04:00
554009741c
Merge pull request #752 from miloknowles/feature/mag_pose_factor
2021-06-03 11:09:02 -04:00
5e2af67a74
Update commment syntax and replace typedef with using
2021-06-01 16:31:20 -04:00
1011055007
Merge pull request #696 from borglab/feature/smartFactorsWithExtrinsicCalibration
...
smart factors with extrinsics calibration
2021-05-27 10:41:33 -04:00
6c3aca8cac
remove virtual from overridden methods, add virtual destructors to appease compiler
2021-04-30 12:58:52 -04:00
f584537412
Improve docs
2021-04-23 10:02:41 -04:00
378b379e56
Compute error in the body frame and fix print()
2021-04-23 09:42:07 -04:00
0313a56734
Add MagPoseFactor
2021-04-22 16:51:47 -04:00
d4eaa15280
rolling shutter projection factor
2021-04-22 08:52:28 +03:00
0a08c19847
added comment
2021-04-04 12:07:10 -04:00
10260253b3
trying to fix CI error
2021-04-03 21:01:53 -04:00
6ae3b80bae
fixed glitch highlighted by CI
2021-04-03 18:10:39 -04:00
413b9d8202
cleanup
2021-04-03 17:59:45 -04:00
53e3de3629
improved naming, formatting, comments
2021-04-03 17:45:02 -04:00
71c528a87d
formatting
2021-04-03 17:37:36 -04:00
038c1c0b8e
added extra unit test
2021-04-03 17:33:12 -04:00
282aa1a0a9
Merge branch 'develop' into feature/smartFactorsWithExtrinsicCalibration
2021-04-03 17:16:04 -04:00
0c865fa52a
removed extra "else"
2021-03-29 23:00:38 -04:00
5677bdb6c1
need to clean up templates and remove 2 redundant lines
2021-03-29 22:58:29 -04:00
2e1ed2c852
1 test to go!
2021-03-28 20:07:29 -04:00
2c1b780a4f
2 tests to go
2021-03-28 20:03:02 -04:00
b10a9d245b
getting ready to enable monocular operation
2021-03-28 18:42:20 -04:00
81aad1977c
works now!!
2021-03-27 23:03:05 -04:00
8ca3d475c8
now I have a working prototype!
2021-03-27 22:28:35 -04:00
8b4a74efff
test still failing
2021-03-26 22:33:15 -04:00
e8db2b6b9b
getting better
2021-03-26 20:04:42 -04:00
1f12f82e01
Fix Rot3::LocalCoordinates runtime error when using Cayley map
2021-03-26 17:29:47 -04:00
ec047ccd08
moving to more appropriate construction of Hessian
2021-03-26 17:25:27 -04:00
a0ff5e3886
Add LocalCoordinates() to ProductLieGroup and remove unnecessary <Eigen/Core> include to reduce compile memory
2021-03-26 14:36:43 -04:00
909b5500f8
Fix incorrect Vector dimension that was causing CI failures
2021-03-26 11:26:27 -04:00
05fad78ce9
Switch to cleaner T::Logmap
2021-03-26 10:09:05 -04:00
74b92efd89
Add constructor tests and extend tests to Pose2
2021-03-26 09:55:25 -04:00
ef2cd5dab5
Fix x/y mismatch in unit tests
2021-03-26 08:59:44 -04:00
b3c828f8d2
amended
2021-03-25 21:42:28 -04:00
7c052ff48a
fixed print, removed cout, test still failing
2021-03-25 21:37:13 -04:00
4df78be0f0
Merge branch 'develop' into feature/smartFactorsWithExtrinsicCalibration
2021-03-22 19:19:23 -04:00
00eee7cd19
removed tests that are not applicable - merging to develop now
2021-03-22 19:18:44 -04:00
d8eeaf9cb3
adding test with single key
2021-03-22 19:16:31 -04:00
4b29c0370d
Prefer localCoordinates over logmap
2021-03-21 20:46:26 -04:00
3d1c170860
fixed optimization test: now we have to (i) allow reuse of same calibration, (ii) enable all other tests, (iii) remove cout
2021-03-21 19:39:37 -04:00
7a30d8b4d4
trying to fix crucial test
2021-03-21 19:34:21 -04:00
483a1995ba
solving key problem
2021-03-21 19:12:40 -04:00
43c9f2ba26
Change mask to indices and update factor docstring
2021-03-21 17:20:43 -04:00
593e6e975d
Correct Jacobian in PartialPriorFactor, modify derived factors for compatibility
2021-03-21 17:10:00 -04:00
e6b7d9f133
Add successful unit test for identity pose
2021-03-20 17:57:10 -04:00
075293cf83
Three examples of failing PartialPriorFactor<Pose3> Jacobians
2021-03-20 17:44:03 -04:00
2dc908c986
working on new sym matrix
2021-03-19 23:09:26 -04:00
6d118da82d
still segfaults
2021-03-14 22:43:53 -04:00
e571d2c188
debugging jacobians
2021-03-13 23:49:33 -05:00
2132778edc
pipeline up and running, need to fix Jacobians next, then Schur complement
2021-03-13 22:34:37 -05:00
dbc10ff227
isolated schur complement!
2021-03-13 21:51:39 -05:00
0161047427
trying to figure out jacobians
2021-03-13 19:19:12 -05:00
8a37a86441
test failure: now we can start computing jacobians
2021-03-13 18:12:12 -05:00
c1da490c2d
got it!
2021-03-13 18:10:03 -05:00
0194e3df94
fixed unit test
2021-03-13 17:55:24 -05:00
f234ad516e
moving to noisy tests
2021-03-13 17:49:08 -05:00
f0b5b244ad
moving to other tests
2021-03-13 17:40:53 -05:00
0c50c963a1
error computation also looks fine!
2021-03-13 17:36:53 -05:00
c965ce6be0
fixed equals
2021-03-13 17:20:39 -05:00
266d8248d0
simple tests are passing, but now we start on the serious ones
2021-03-13 14:03:10 -05:00
273d2da567
compiles and all tests pass!!
2021-03-13 13:54:23 -05:00
f84e1750ea
done factor!
2021-03-13 13:50:47 -05:00
bc8866bd9e
created .h
2021-03-13 13:21:43 -05:00
f7a84ff9f3
added test
2021-03-13 12:46:18 -05:00
f5ff7aa49f
Merge pull request #564 from borglab/fix/planeFactor
...
Fix/plane factor
2021-02-22 23:58:14 -05:00
8f18ce931b
Add inline comments on commented-out unit tests
2021-02-20 23:13:43 +00:00
5b0bd08e7b
small tidy and fix unit tests
2021-02-16 18:21:53 +00:00
960a3e1d8e
Tidy up comments and use cpplint
2021-02-16 11:48:26 +00:00
7480d149c8
Update documentation on new factor
2021-02-15 15:08:57 +00:00
a62bdd45e8
Add new oriented plane 3 factors with local linearisation point
2021-02-15 13:15:11 +00:00
7f80c906c4
Fix override warnings: modernize-use-override
2021-01-28 23:02:13 -05:00
c073473f5b
Merge branch 'develop' of github.com:borglab/gtsam into fix/warning_in_smart_factor
...
* 'develop' of github.com:borglab/gtsam: (65 commits)
type in test hidden by duplicate test values
auto and reserve fewer
replace sparseJacobian with "fast" version
disambiguate double template >>
fix comment and remove whitespace diff
remove InPlace jacobian from .h file
remove unnecessary function overloads and typedefs
use standard function to check for empty string
fix bug in Pose2 print
formatting
revert Matrix.h
remove templating while maintaining efficiency Templating still used in cpp file for generic-ness, but not exposed anymore
move SparseMatrixBoostTriplets typedef to gfg
add known issues section with info about march=native
Revert "upgrade minimum required Boost version to 1.67."
upgrade minimum required Boost version to 1.67.
populate sparse matrix with `insert` rather than `setFromTriplets` About 5% speed improvement.
eliminate copy/pasta from SparseEigen with generic version of sparseJacobian
more generic sparseJacobianInPlace function
add generic optional parameters to sparseJacobian Also, the unit test changed due to a 0 entry that was previously wrongly included in the b-column of the sparse representation.
...
2021-01-28 22:49:06 -05:00
241d82dbf7
Fix can be marked override warning
2021-01-22 00:27:32 -05:00
f831bfd62e
add override and formatting
2021-01-19 15:40:37 -05:00
96dc9bfa5a
Fix formatting
2021-01-18 14:48:19 -05:00
5ad65ed46c
Fix formatting
2021-01-18 14:41:59 -05:00
19b7312edb
Split .h/.cpp, use const& (WIP)
2021-01-17 11:08:53 -05:00
cb3a766b30
uncomment calibration applications
2020-11-30 13:19:13 -05:00
2703307a43
deprecate SimpleCamera tests
2020-11-30 07:01:58 -05:00
lcarlone
Jose Luis Blanco Claraco
Frank Dellaert
lucacarlone
Varun Agrawal
acxz
Milo Knowles
Frank Dellaert
yotams
David Wisth
Toni