Commit Graph

686 Commits (release/4.3a0)

Author SHA1 Message Date
Gerry Chen 97fcb409b9
revert confusing `->template key<N>()` notations
revert to using shortcut form: `key1()`, `key2()`
2023-01-04 22:55:24 -05:00
Varun Agrawal 6f5e85664c fix some more deprecation warnings 2022-12-24 20:36:26 +05:30
Gerry Chen 885eed33d1
replace all NoiseModelFactor1, 2, ... with NoiseModelFactorN 2022-12-22 17:25:48 -05:00
Varun Agrawal 1f6816d974 Merge branch 'develop' into fix/doxygen 2022-08-22 17:37:03 -04:00
Varun Agrawal 0f53b3f892
Merge pull request #1238 from borglab/fix/1182
Capitalize Identity trait
2022-08-21 09:05:21 -04:00
Varun Agrawal d6fe41d59d update the groups 2022-07-26 16:44:30 -04:00
Varun Agrawal c82981f217 fix doxygen warnings due to groups and and incorrect filenames 2022-07-26 16:38:51 -04:00
agilemapper aef4ec8185 replace addtogroup with ingroup for the SLAM group 2022-07-23 13:04:42 +02:00
Varun Agrawal d12dd55c55
Merge pull request #1035 from borglab/fix/gncOptimizer 2022-07-07 15:28:35 -04:00
Varun Agrawal c31298d367 Capitalize Identity trait since it is static 2022-07-07 12:31:27 -04:00
Dominik Van Opdenbosch c435da87fc InvDepthFactor3: Add unit test for Jacobians 2022-04-08 17:29:01 +02:00
d-vo d0144441cb InvDepthFactor3: Fix wrong derivative H3 2022-03-31 20:30:51 +02:00
acxz 026cfca0d9 replace ifndefs with pragma once 2022-02-20 02:53:15 -05:00
Frank Dellaert 55ad1841bd
Merge pull request #1108 from borglab/fix/headers
Header discipline in base
2022-02-17 01:25:01 -05:00
Varun Agrawal 2b78b96670
Merge pull request #1107 from borglab/fix/91_single_test_exe 2022-02-17 00:12:25 -05:00
Frank Dellaert c78af4d3ea Add headers in the place they are needed 2022-02-16 22:51:53 -05:00
Frank Dellaert 3d6a7bf970 Fix more stuff in check.slam 2022-02-16 09:43:12 -05:00
Mike Sheffler ac01db4f4d Per https://github.com/borglab/gtsam/blob/develop/Using-GTSAM-EXPORT.md , classes with no methods defined in a .cpp file shouldn't have the GTSAM_EXPORT or GTSAM_UNSTABLE_EXPORT modifier. This was causing problems with the building of gtsam_unstable on MSVC / Windows. 2022-02-15 00:19:54 -08:00
lcarlone e0082d746c Merge branch 'feature/robustTriangulation' into feature/refinementsForPoseToPointFactor 2022-01-12 20:43:13 -05:00
Frank Dellaert 3e768247ef
Merge pull request #999 from borglab/feature/deprecate_in_v42 2022-01-03 14:16:40 -05:00
Varun Agrawal a119eb8e59
Merge pull request #1003 from borglab/fix/change-local-plane-factor-to-shared-noise-model 2022-01-03 09:31:59 -05:00
David Wisth 25c82c9878 change a couple of variables to const 2022-01-03 16:41:21 +11:00
David Wisth c86e42e8a1 fix constructor documentation 2022-01-03 16:41:04 +11:00
David Wisth b166985a82 remove unnessecary constructor - use default arguments instead 2022-01-03 16:40:48 +11:00
David Wisth 2151fd3852 change from SharedGaussian to SharedNoiseModel 2022-01-03 16:06:11 +11:00
David Wisth 6af7c3ac29 fix destructor virtual keyword 2022-01-03 16:05:58 +11:00
Frank Dellaert 6d0c55901c Global replace to V42 2022-01-02 15:49:47 -05:00
Frank Dellaert 9518346161 Fix unstable c++ examples 2022-01-02 14:59:28 -05:00
Frank Dellaert 55f31ab2d7 Revive BetweenFactorEM, without LieVector 2022-01-02 14:38:20 -05:00
Varun Agrawal d42044f22e initialize all EmptyCal shared pointers 2021-12-20 21:19:54 -05:00
lcarlone 39286f6672 added clone to play well with gnc 2021-12-19 10:41:07 -05:00
Varun Agrawal 3615c4b5ac
Merge pull request #956 from borglab/fix/compiler-warnings-posetopointfactor 2021-12-09 09:37:40 -05:00
Varun Agrawal b47f46a6f5
Windows Fixes (#904) 2021-12-09 09:37:21 -05:00
David Wisth 45d5328457 remove "virtual" keyword for functions with "override" 2021-12-08 21:12:46 +00:00
David Wisth ab73e03ad4 add override keyword to functions 2021-12-08 18:17:35 +00:00
lcarlone 748b647a79 generalized factor and enabled unit tests 2021-12-07 23:45:33 -05:00
lcarlone 260312af38 Merge branch 'develop' into feature/sphericalCamera 2021-12-04 18:51:16 -05:00
lcarlone 1cd33cb11e renamed README 2021-12-04 11:51:23 -05:00
Jose Luis Blanco-Claraco 744db328e7
Merge pull request #915 from borglab/fix/gcc-Wpedantic-warnings
Fix warnings raised by GCC -Wpedactic
2021-11-10 12:24:07 +01:00
Jose Luis Blanco Claraco 94aa96e00a
prefer semicolon in definitions 2021-11-08 22:41:59 +01:00
lcarlone 52fb88abe6 Merge branch 'feature/cameraTemplateForAllSmartFactors' into feature/sphericalCamera
# Conflicts:
#	gtsam/slam/tests/testSmartProjectionRigFactor.cpp
2021-11-07 18:47:59 -05:00
lcarlone 620f9cb99f now using shared ptrs 2021-11-07 18:32:43 -05:00
lcarlone 2c2e43ee5b got rid of second constructor 2021-11-07 18:01:28 -05:00
lcarlone 78a4075a54 applied formatting to modified files 2021-11-07 16:31:48 -05:00
lcarlone 78a8b7dc0e Merge branch 'feature/cameraTemplateForAllSmartFactors' into feature/sphericalCamera
# Conflicts:
#	gtsam_unstable/slam/SmartProjectionPoseFactorRollingShutter.h
2021-11-07 15:20:16 -05:00
lcarlone c105aa4e1e added intermediate camera variable for clarity 2021-11-07 14:56:06 -05:00
lcarlone b1baf6c8b3 final cosmetics 2021-11-07 14:50:56 -05:00
lcarlone 2f57a1a307 Merge branch 'feature/cameraTemplateForAllSmartFactors' into feature/sphericalCamera
# Conflicts:
#	gtsam/slam/SmartProjectionFactorP.h
#	gtsam/slam/tests/smartFactorScenarios.h
#	gtsam/slam/tests/testSmartProjectionRigFactor.cpp
#	gtsam_unstable/slam/SmartProjectionPoseFactorRollingShutter.h
#	gtsam_unstable/slam/tests/testSmartProjectionPoseFactorRollingShutter.cpp
2021-11-07 14:23:14 -05:00
lcarlone e51d10f18c Merge branch 'develop' into feature/sphericalCamera
# Conflicts:
#	gtsam/geometry/CameraSet.h
#	gtsam_unstable/slam/SmartProjectionPoseFactorRollingShutter.h
#	gtsam_unstable/slam/tests/testSmartProjectionPoseFactorRollingShutter.cpp
2021-11-07 12:02:33 -05:00
lcarlone dfd86e8c57 this will need to be applied in #861 2021-11-06 20:00:23 -04:00
lcarlone 29f3af560d point2 -> measurement 2021-11-06 19:58:33 -04:00
lcarlone 710a64fed4 now throwing exception is params are incorrect 2021-11-06 19:22:28 -04:00
lcarlone 1e384686a1 more const& 2021-11-06 18:34:34 -04:00
lcarlone dfd4a77454 formatting + const& 2021-11-06 18:11:46 -04:00
lcarlone c4cd2b5080 fixed formatting (plus small fix: std::vector -> fastVector) 2021-11-06 18:05:58 -04:00
Jose Luis Blanco Claraco 89ce766269
more consistent notation of macros 2021-11-04 07:11:28 +01:00
Jose Luis Blanco Claraco a61cbdc4d1
Fix warnings raised by GCC -Wpedactic 2021-11-03 17:14:37 +01:00
lcarlone 737dcf65e4 all set here! 2021-10-05 23:29:20 -04:00
lcarlone f0745a9c28 now I only need to fix comments in rolling shutter factor 2021-10-05 23:10:45 -04:00
lcarlone 823a7e7be0 done with tests 2021-10-05 22:53:36 -04:00
lcarlone 0797eae9a8 all tests are passing! 2021-10-05 22:32:02 -04:00
lcarlone 4fd6c2cb5d bug fix - finalizing last few tests 2021-10-05 22:23:16 -04:00
lcarlone 7988a7050f changing API for rolling shutter 2021-10-04 21:33:26 -04:00
lcarlone 3758fdaa5d all tests work except serialization 2021-10-02 23:10:05 -04:00
Frank Dellaert c0262b074c Address review comments, docs only. 2021-08-29 19:38:20 -04:00
Frank Dellaert 372ae27a5e Added two ReadMe files to document the plethora of smart factors. 2021-08-29 16:47:32 -04:00
Frank Dellaert 4ef234bbbb Formatting and better documentation 2021-08-29 16:46:53 -04:00
lcarlone e9641ba26b Merge branch 'develop' into feature/cameraTemplateForAllSmartFactors
# Conflicts:
#	gtsam/geometry/CameraSet.h
2021-08-28 20:09:24 -04:00
Frank Dellaert bafcde9ee1 Google-style formatting in new files. 2021-08-28 17:36:14 -04:00
Frank Dellaert d0505d4bc3 Check equals not assert_equal 2021-08-28 17:20:08 -04:00
Frank Dellaert 2b3709ec73 Got rid of SchurComplementAndRearrangeBlocks_3_12_6 2021-08-28 17:19:53 -04:00
Frank Dellaert 0c622294d2 Some formatting 2021-08-28 17:19:19 -04:00
Frank Dellaert f712d62150 Added override 2021-08-28 16:30:25 -04:00
lcarlone ff33eb614d adjusted rolling shutter as well 2021-08-28 01:31:50 -04:00
lcarlone 8af633a991 Merge branch 'feature/rollingShutterSmartFactors' into feature/cameraTemplateForAllSmartFactors 2021-08-26 11:30:59 -04:00
lcarlone 37b001307e plot twist: templating new factor on CAMERA 2021-08-26 11:29:34 -04:00
lcarlone 330a100110 Merge branch 'feature/rollingShutterSmartFactors' into feature/cameraTemplateForAllSmartFactors 2021-08-25 22:22:58 -04:00
lcarlone db2a9151e5 don't like it - going to create a different class 2021-08-24 20:56:40 -04:00
lcarlone 0a8ebdf8cd renamed interp param to alpha, improved comments, added cpp 2021-08-13 21:42:09 -04:00
lcarlone a3ee695b85 reformatted using google style 2021-08-13 20:05:19 -04:00
lcarlone e4f1bb1bd0 CHECK -> EXPECT 2021-07-23 22:56:37 -04:00
lcarlone e838d011a6 added timing test 2021-07-23 22:48:16 -04:00
lcarlone a10d495611 extra cleanup 2021-07-23 22:23:01 -04:00
lcarlone 1f07142b5b renamed params. need one last test 2021-07-23 19:03:23 -04:00
lcarlone 5350e3463e done with tests, now I only have to rename gamma to keep consistency with the projection factors RS 2021-07-23 18:58:43 -04:00
lcarlone 81526e8917 fixed another test. 2021-07-23 17:57:24 -04:00
lcarlone 9c288d90ce working on testing + cosmetic improvements to print for smart factors 2021-07-23 17:48:08 -04:00
lcarlone a7b7770310 test with EPI fixed 2021-07-23 15:50:16 -04:00
lcarlone aeb1d35dd6 fixed test with lmk distance 2021-07-23 15:47:07 -04:00
lcarlone 934413522d fixed another test, few more to go 2021-07-23 15:39:13 -04:00
lcarlone 1c3ff0580b removed printout, solved CI issue 2021-07-23 00:03:41 -04:00
lcarlone 48a7afa463 removed comments. Code is complete now. Need few more unit tests and we are good to go 2021-07-22 22:35:21 -04:00
lcarlone 91a6613d84 moved common function to cameraSet. commented issues with templated calls to functions in cameraSet 2021-07-22 22:31:33 -04:00
lcarlone 477dd5b247 all pass! 2021-07-22 21:49:40 -04:00
lcarlone d7e8912d6a all pass! 2021-07-22 21:45:26 -04:00
lcarlone a439cf0f0f stuck on compile issue 2021-07-21 23:33:42 -04:00
lcarlone d4b88ba59a got to the final monster. Now I need to implement createHessian 2021-07-21 22:46:42 -04:00
lcarlone e6ff03f73e jacobians and errors are well tested now 2021-07-21 16:31:45 -04:00
lcarlone 4669213618 jacobians are good to go! 2021-07-21 16:19:44 -04:00
lcarlone 5d55e153f0 yay! error test passes! 2021-07-21 15:10:10 -04:00