Frank Dellaert
0c6d5d438f
use emplace_shared
2021-11-20 15:52:36 -05:00
Frank Dellaert
ad3225953b
Cleaned up AC1 implementation
2021-11-20 15:52:12 -05:00
Frank Dellaert
23bcf96da4
use emplace_shared
2021-11-20 11:46:32 -05:00
Frank Dellaert
b7f43906bc
Formatting only
2021-11-18 15:12:32 -05:00
Frank Dellaert
dd50975668
Revamped arc consistency
2021-11-18 15:11:47 -05:00
Frank Dellaert
aebcf07ab5
Formatted sudokus better
2021-11-18 11:31:11 -05:00
Frank Dellaert
d27d6b60a7
Formatting with Google style
2021-11-18 10:54:00 -05:00
Jose Luis Blanco-Claraco
744db328e7
Merge pull request #915 from borglab/fix/gcc-Wpedantic-warnings
...
Fix warnings raised by GCC -Wpedactic
2021-11-10 12:24:07 +01:00
Jose Luis Blanco Claraco
582f6914cd
more extra semicolon warnings fixed
2021-11-08 23:07:05 +01:00
Jose Luis Blanco Claraco
94aa96e00a
prefer semicolon in definitions
2021-11-08 22:41:59 +01:00
lcarlone
52fb88abe6
Merge branch 'feature/cameraTemplateForAllSmartFactors' into feature/sphericalCamera
...
# Conflicts:
# gtsam/slam/tests/testSmartProjectionRigFactor.cpp
2021-11-07 18:47:59 -05:00
lcarlone
620f9cb99f
now using shared ptrs
2021-11-07 18:32:43 -05:00
lcarlone
2c2e43ee5b
got rid of second constructor
2021-11-07 18:01:28 -05:00
lcarlone
78a4075a54
applied formatting to modified files
2021-11-07 16:31:48 -05:00
lcarlone
78a8b7dc0e
Merge branch 'feature/cameraTemplateForAllSmartFactors' into feature/sphericalCamera
...
# Conflicts:
# gtsam_unstable/slam/SmartProjectionPoseFactorRollingShutter.h
2021-11-07 15:20:16 -05:00
lcarlone
c105aa4e1e
added intermediate camera variable for clarity
2021-11-07 14:56:06 -05:00
lcarlone
b1baf6c8b3
final cosmetics
2021-11-07 14:50:56 -05:00
lcarlone
2f57a1a307
Merge branch 'feature/cameraTemplateForAllSmartFactors' into feature/sphericalCamera
...
# Conflicts:
# gtsam/slam/SmartProjectionFactorP.h
# gtsam/slam/tests/smartFactorScenarios.h
# gtsam/slam/tests/testSmartProjectionRigFactor.cpp
# gtsam_unstable/slam/SmartProjectionPoseFactorRollingShutter.h
# gtsam_unstable/slam/tests/testSmartProjectionPoseFactorRollingShutter.cpp
2021-11-07 14:23:14 -05:00
lcarlone
e51d10f18c
Merge branch 'develop' into feature/sphericalCamera
...
# Conflicts:
# gtsam/geometry/CameraSet.h
# gtsam_unstable/slam/SmartProjectionPoseFactorRollingShutter.h
# gtsam_unstable/slam/tests/testSmartProjectionPoseFactorRollingShutter.cpp
2021-11-07 12:02:33 -05:00
lcarlone
dfd86e8c57
this will need to be applied in #861
2021-11-06 20:00:23 -04:00
lcarlone
29f3af560d
point2 -> measurement
2021-11-06 19:58:33 -04:00
lcarlone
710a64fed4
now throwing exception is params are incorrect
2021-11-06 19:22:28 -04:00
lcarlone
1e384686a1
more const&
2021-11-06 18:34:34 -04:00
lcarlone
459c8f93a5
Merge branch 'develop' into feature/cameraTemplateForAllSmartFactors
2021-11-06 18:12:15 -04:00
lcarlone
dfd4a77454
formatting + const&
2021-11-06 18:11:46 -04:00
lcarlone
c4cd2b5080
fixed formatting (plus small fix: std::vector -> fastVector)
2021-11-06 18:05:58 -04:00
Jose Luis Blanco Claraco
89ce766269
more consistent notation of macros
2021-11-04 07:11:28 +01:00
Jose Luis Blanco Claraco
a61cbdc4d1
Fix warnings raised by GCC -Wpedactic
2021-11-03 17:14:37 +01:00
Varun Agrawal
48cc70c506
generate GTSAM_UNSTABLE Cmake exports
2021-10-23 12:45:21 -04:00
lcarlone
737dcf65e4
all set here!
2021-10-05 23:29:20 -04:00
lcarlone
f0745a9c28
now I only need to fix comments in rolling shutter factor
2021-10-05 23:10:45 -04:00
lcarlone
823a7e7be0
done with tests
2021-10-05 22:53:36 -04:00
lcarlone
0797eae9a8
all tests are passing!
2021-10-05 22:32:02 -04:00
lcarlone
4fd6c2cb5d
bug fix - finalizing last few tests
2021-10-05 22:23:16 -04:00
lcarlone
7988a7050f
changing API for rolling shutter
2021-10-04 21:33:26 -04:00
lcarlone
3758fdaa5d
all tests work except serialization
2021-10-02 23:10:05 -04:00
lcarlone
c4b64877eb
Merge branch 'develop' into feature/cameraTemplateForAllSmartFactors
2021-09-23 09:42:03 -04:00
Varun Agrawal
30ac64accf
Merge pull request #570 from borglab/feature/system-metis-lib
2021-09-18 02:12:43 -04:00
Frank Dellaert
c0262b074c
Address review comments, docs only.
2021-08-29 19:38:20 -04:00
Frank Dellaert
372ae27a5e
Added two ReadMe files to document the plethora of smart factors.
2021-08-29 16:47:32 -04:00
Frank Dellaert
4ef234bbbb
Formatting and better documentation
2021-08-29 16:46:53 -04:00
lcarlone
e9641ba26b
Merge branch 'develop' into feature/cameraTemplateForAllSmartFactors
...
# Conflicts:
# gtsam/geometry/CameraSet.h
2021-08-28 20:09:24 -04:00
Frank Dellaert
bafcde9ee1
Google-style formatting in new files.
2021-08-28 17:36:14 -04:00
Frank Dellaert
d0505d4bc3
Check equals not assert_equal
2021-08-28 17:20:08 -04:00
Frank Dellaert
2b3709ec73
Got rid of SchurComplementAndRearrangeBlocks_3_12_6
2021-08-28 17:19:53 -04:00
Frank Dellaert
0c622294d2
Some formatting
2021-08-28 17:19:19 -04:00
Frank Dellaert
f712d62150
Added override
2021-08-28 16:30:25 -04:00
lcarlone
ff33eb614d
adjusted rolling shutter as well
2021-08-28 01:31:50 -04:00
lcarlone
8af633a991
Merge branch 'feature/rollingShutterSmartFactors' into feature/cameraTemplateForAllSmartFactors
2021-08-26 11:30:59 -04:00
lcarlone
37b001307e
plot twist: templating new factor on CAMERA
2021-08-26 11:29:34 -04:00
Varun Agrawal
4f33cb8835
add guards for system Metis
2021-08-26 02:22:28 -04:00
lcarlone
330a100110
Merge branch 'feature/rollingShutterSmartFactors' into feature/cameraTemplateForAllSmartFactors
2021-08-25 22:22:58 -04:00
lcarlone
db2a9151e5
don't like it - going to create a different class
2021-08-24 20:56:40 -04:00
lcarlone
0a8ebdf8cd
renamed interp param to alpha, improved comments, added cpp
2021-08-13 21:42:09 -04:00
lcarlone
a3ee695b85
reformatted using google style
2021-08-13 20:05:19 -04:00
lcarlone
e4f1bb1bd0
CHECK -> EXPECT
2021-07-23 22:56:37 -04:00
lcarlone
e838d011a6
added timing test
2021-07-23 22:48:16 -04:00
lcarlone
a10d495611
extra cleanup
2021-07-23 22:23:01 -04:00
lcarlone
1f07142b5b
renamed params. need one last test
2021-07-23 19:03:23 -04:00
lcarlone
5350e3463e
done with tests, now I only have to rename gamma to keep consistency with the projection factors RS
2021-07-23 18:58:43 -04:00
lcarlone
81526e8917
fixed another test.
2021-07-23 17:57:24 -04:00
lcarlone
9c288d90ce
working on testing + cosmetic improvements to print for smart factors
2021-07-23 17:48:08 -04:00
lcarlone
a7b7770310
test with EPI fixed
2021-07-23 15:50:16 -04:00
lcarlone
aeb1d35dd6
fixed test with lmk distance
2021-07-23 15:47:07 -04:00
lcarlone
934413522d
fixed another test, few more to go
2021-07-23 15:39:13 -04:00
lcarlone
1c3ff0580b
removed printout, solved CI issue
2021-07-23 00:03:41 -04:00
lcarlone
48a7afa463
removed comments. Code is complete now. Need few more unit tests and we are good to go
2021-07-22 22:35:21 -04:00
lcarlone
91a6613d84
moved common function to cameraSet. commented issues with templated calls to functions in cameraSet
2021-07-22 22:31:33 -04:00
lcarlone
477dd5b247
all pass!
2021-07-22 21:49:40 -04:00
lcarlone
d7e8912d6a
all pass!
2021-07-22 21:45:26 -04:00
lcarlone
a439cf0f0f
stuck on compile issue
2021-07-21 23:33:42 -04:00
lcarlone
d4b88ba59a
got to the final monster. Now I need to implement createHessian
2021-07-21 22:46:42 -04:00
lcarlone
e6ff03f73e
jacobians and errors are well tested now
2021-07-21 16:31:45 -04:00
lcarlone
4669213618
jacobians are good to go!
2021-07-21 16:19:44 -04:00
lcarlone
5d55e153f0
yay! error test passes!
2021-07-21 15:10:10 -04:00
lcarlone
6f8d639ab8
finding best way to test RS errors
2021-07-21 14:46:52 -04:00
lcarlone
306393a18c
solidified add and equal
2021-07-21 14:30:55 -04:00
lcarlone
30f304e733
started serious testing: all tests pass for now
2021-07-21 13:58:47 -04:00
lcarlone
02d2d97a8e
added nice test on cheirality exception - done with projectionFactorRollingShutter
2021-07-20 23:04:52 -04:00
lcarlone
a480b2dcfc
all tests are passing!
2021-07-20 22:05:36 -04:00
lcarlone
0d1c3f16ef
everything working out so far with the tests
2021-07-20 21:29:56 -04:00
lcarlone
2812eeb1be
pass on projection factor, but looks great overall
2021-07-20 21:06:51 -04:00
lcarlone
a204f6d508
amended
2021-07-20 20:46:43 -04:00
lcarlone
4c997e5474
removed interp from Pose3, starting to take pass on projection factor and test
2021-07-20 20:46:29 -04:00
lucacarlone
b8fa0ccc6f
Merge branch 'feature/rollingShutterSmartFactors' into rolling_factor
2021-07-20 18:29:10 -04:00
lcarlone
16d624d4e1
now I need to move to testing and interpolation
2021-07-19 17:01:27 -04:00
lcarlone
1e2a1d2591
removed cpp
2021-07-19 16:11:34 -04:00
lcarlone
82844b541c
put in place initial functions
2021-07-19 16:11:18 -04:00
lcarlone
00387b32cd
setting up .h and tests - compiles and tests pass.
2021-07-19 15:30:53 -04:00
lcarlone
cd1d4b4df5
added templates for factors
2021-07-19 14:38:26 -04:00
Varun Agrawal
d5890a2d61
update all the tests
2021-07-10 21:03:15 -04:00
Varun Agrawal
dc8b5e58ff
replaced boost with std for placeholders, bind and function
2021-07-10 21:01:20 -04:00
Akash Patel
5a2ff198f0
Merge branch 'develop' into boost-bind-warn
2021-06-28 10:54:48 -04:00
acxz
944b3aea29
formatting
2021-06-20 20:37:49 -04:00
Akash Patel
7aeb386dbd
formatting
...
remove extraneous `using`
2021-06-20 18:04:28 -04:00
acxz
6dea8667fd
explicitly use boost::placeholders:_X for compilers that do not respect function scope
2021-06-18 13:45:59 -04:00
acxz
650e432f52
update boost::bind usage
...
use <boost/bind/bind.hpp> instead of deprecated <boost/bind.hpp>
use boost::placeholders:: scope in appropriate files
remove and add <boost/bind/bind.hpp> in appropriate files
2021-06-16 00:56:43 -04:00
acxz
ad7d8f183a
use size_t variable type
2021-06-14 16:25:15 -04:00
Milo Knowles
9392bfd1c1
Move MagPoseFactor to gtsam
2021-06-08 18:25:33 -04:00
Varun Agrawal
554009741c
Merge pull request #752 from miloknowles/feature/mag_pose_factor
2021-06-03 11:09:02 -04:00