Commit Graph

1576 Commits (cded12e6c8e6a5b74ff08ea231e38ddd2c7d01d3)

Author SHA1 Message Date
Frank Dellaert 5a6bfed42c Fix override warning 2020-08-18 23:19:56 -04:00
Fan Jiang 1d6392dc88 Initial migration 2020-08-17 17:13:10 -04:00
Frank Dellaert 84afc94458
Feature/shonan averaging (#473)
Shonan Rotation Averaging.

199 commit messages below, many are obsolete as design has changed quite a bit over time, especially from the earlier period where I thought we only needed SO(4).

* prototyping weighted sampler

* Moved WeightedSampler into its own header

* Random now uses std header <random>.

* Removed boost/random usage from linear and discrete directories

* Made into class

* Now using new WeightedSampler class

* Inlined random direction generation

* eradicated last vestiges of boost/random in gtsam_unstable

* Added 3D example g2o file

* Added Frobenius norm factors

* Shonan averaging algorithm, using SOn class

* Wrapping Frobenius and Shonan

* Fixed issues with <<

* Use Builder parameters

* Refactored Shonan interface

* Fixed << issues as well as MATLAB segfault, using eval(), as discussed in issue #451

* ShonanAveragingParameters

* New factor FrobeniusWormholeFactorP computes |Rj*P - Ri*P*Rij|

* Fixed broken GetDimension for Lie groups with variable dimension.

* Removed all but Shonan averaging factor and made everything work with new SOn

* Just a single WormholeFactor, wrapped noise model

* Use std <random>

* comments/todos

* added timing script

* add script to process ShonanAveraging timing results

* Now producing a CSV file

* Parse csv file and make combined plot

* Fixed range

* change p value and set two flags on

* input file path, all the csv files proceeses at the same time

* add check convergence rate part

* csv file have name according to input  data name

* correct one mistake in initialization

* generate the convergence rate for each p value

* add yticks for the bar plot

* add noises to the measurements

* test add noise

* Basic structure for checkOptimalityAt

* change optimizer method to cholesky

* buildQ now working. Tests should be better but visually inspected.

* multiple test with cholesky

* back

* computeLambda now works

* make combined plots while make bar plot

* Calculate minimum eigenvalue - the very expensive version

* Exposed computeMinEigenValue

* make plots and bar  togenter

* method change to jacobi

* add time for check optimality, min_eigen_value, sub_bound

* updated plot min_eigen value and subounds

* Adding Spectra headers

* David's min eigenvalue code inserted and made to compile.

* Made it work

* Made "run" method work.

* add rim.g2o name

* Fixed bug in shifting eigenvalues

* roundSolution which replaces projectFrom

* removed extra arguments

* Added to wrapper

* Add SOn to template lists

* roundSolution delete the extra arguement p

* only calculate p=5 and change to the correct way computing f_R

* Fixed conflict and made Google-style name changes

* prototype descent code and unit test for initializeWithDescent

* add averaging cost/time part in processing data

* initializewithDescent success in test

* Formatting and find example rather than hardcode

* Removed accidentally checked in cmake files

* give value to xi by block

* correct gradient descent

* correct xi

* }

* Fix wrapper

* Make Hat/Vee have alternating signs

* MakeATangentVector helpder function

* Fixed cmake files

* changed sign

* add line search

* unit test for line search

* test real data with line search

* correct comment

* Fix boost::uniform_real

* add save .dat file

* correct test case

* add explanation

* delete redundant cout

* add name to .dat output file

* correct checkR

* add get poses_  in shonan

* add Vector Point type for savig data

* Remove cmake file which magically re-appeared??

* Switched to std random library.

* Prepare Klaus test

* Add klaus3.g2o data.

* fix comment

* Fix derivatives

* Fixed broken GetDimension for Lie groups with variable dimension.

* Fix SOn tests to report correct dimension

* Added tests for Klaus3 data

* Add runWithRandomKlaus test for shonan.

* Finish runWithRandomKlaus unittest.

* Correct datafile.

* Correct the format.

* Added measured and keys methods

* Shonan works on Klaus data

* Create dense versions for wrappers, for testing

* Now store D, Q, and L

* Remove another cmake file incorrectly checked in.

* Found and fixed the bug in ComputeLambda !

* Now using Q in Lambdas calculation, so Lambdas agree with Eriksson18cvpr.

* Make FrobeniusFactor not use deprecated methods

* FrobeniusWormholeFactor takes Rot3 as argument

* Wrapped some more methods.

* Wrapped more methods

* Allow creating and populating BetweenFactorPose3s in python

* New constructors for ShonanAveraging

* add function of get measurements number

* Remove option not to use noise model

* wrap Use nrMeasurements

* Made Logmap a bit more tolerant of slightly degenerate rotations (with trace < -1)

* Allow for Anchor index

* Fix anchor bug

* Change outside view to Rot3 rather than SO3

* Add Lift in SOn class

* Make comet working

* Small fixes

* Delete extra function

* Add SOn::Lift

* Removed hardcoded flag

* Moved Frobenius factor to gtsam from unstable

* Added new tests and made an old regression pass again

* Cleaned up formatting and some comments, added EXPORT directives

* Throw exception if wrongly dimensioned values are given

* static_cast and other throw

* Fixed run-time dimension

* Added gauge-constraining factor

* LM parameters now passed in, added Gauge fixing

* 2D test scaffold

* Comments

* Pre-allocated generators

* Document API

* Add optional weight

* New prior weeights infrastructure

* Made d a template parameter

* Recursive Hat and RetractJacobian test

* Added Spectra 0.9.0 to 3rdparty

* Enabling 2D averaging

* Templatized Wormhole factor

* ignore xcode folder

* Fixed vec and VectorizedGenerators templates for fixed N!=3 or 4

* Simplifying constructors
Moved file loading to tests (for now)
All unit tests pass for d==3!

* Templated some methods internally

* Very generic parseToVector

* refactored load2d

* Very much improved FrobeniusWormholeFactor (Shonan) Jacobians

* SO(2) averaging works !

* Templated parse methods

* Switched to new Dataset paradigm

* Moved Shonan to gtsam

* Checked noise model is correctly gotten from file

* Fixed covariance bug

* Making Shonan wrapper work

* Renamed FrobeniusWormholeFactor to ShonanFactor and moved into its own compilation unit in gtsam/sfm

* Fixed wrong include

* Simplified interface (removed irrelevant random inits) and fixed eigenvector test

* Removed stray boost::none

* Added citation as suggested by Jose

* Made descent test deterministic

* Fixed some comments, commented out flaky test

Co-authored-by: Jing Wu <jingwu@gatech.edu>
Co-authored-by: jingwuOUO <wujing2951@gmail.com>
Co-authored-by: swang <swang736@gatech.edu>
Co-authored-by: ss <ss>
Co-authored-by: Fan Jiang <prof.fan@foxmail.com>
2020-08-17 07:43:10 -04:00
Frank Dellaert 269dea3a24
Merge pull request #422 from borglab/dellaert/issue420
Dellaert/issue420
2020-08-02 16:16:01 -04:00
Frank Dellaert e22c24eff5 Removed superfluous size, added doxygen partitions 2020-08-01 15:43:21 -04:00
Frank Dellaert 09bb25498f
Merge branch 'develop' into dellaert/issue420 2020-07-31 16:45:03 -04:00
acxz 1b77579810 fix return copy 2020-07-26 20:20:14 -04:00
acxz ced6eac7e2 remove useless Planning test 2020-07-26 20:20:14 -04:00
acxz ccbdb40c93 fix warnings on incorrect for range reference bindings 2020-07-26 20:20:14 -04:00
Jose Luis Blanco Claraco 0198c648e3
Fix all new gcc warnings/errors: make explicit virtual/override methods.
Rules are:
- use "virtual" in base classes only.
- use "override" in all derived classes.
2020-07-26 11:20:42 +02:00
Frank dellaert 30703ccb6a Removed all deprecated code w Stephanie... 2020-07-22 17:32:25 -04:00
David 0ee4e3b77e Add more documentation and clang-format 2020-06-20 09:45:24 +10:00
David c422815b94 Update incorrect test name 2020-06-20 09:03:17 +10:00
David 0a44315a7f Add Pose3-Point3 factor 2020-06-20 08:46:06 +10:00
Bernd Pfrommer 5801ab079d rename libmetis -> libmetis-gtsam to avoid collision with system libs 2020-06-01 16:20:56 -04:00
Bernd Pfrommer 71f4bb3019 Use GNUInstallDirs to make install destination directories configurable 2020-05-31 21:52:00 -04:00
Frank Dellaert 0af2277dc9
Merge pull request #303 from acxz/boost-timer
update calls from boost timer
2020-05-10 13:24:04 -04:00
acxz 93b4081c7f update timing to use internal timing.h api 2020-05-09 21:29:08 -04:00
acxz 89c6bd6af1 fix sign-compare warning 2020-05-07 11:47:34 -04:00
alescontrela 93ba522582 Remove any unnecessary PriorFactor.h includes 2020-04-12 13:42:02 -04:00
alescontrela 211119b00e Replace addPrior<> with addPrior 2020-04-12 13:10:09 -04:00
alescontrela aa3ac32235 Change all old cases of graph.emplace_shared<PriorFactor<...>>(...) and graph.add(PriorFactor<...>(...)) to graph.addPrior<...>(...). Removed unnecessary PriorFactor.h includes. 2020-04-11 20:09:54 -04:00
alescontrela f4525b51e4 Change PriorFactor includes from gtsam/slam to gtsam/nonlinear 2020-04-10 22:26:22 -04:00
Jose Luis Blanco Claraco 76b29b78af
Prefer C++11 nullptr 2020-04-06 23:31:05 +02:00
Varun Agrawal 9361d5b491
Merge pull request #260 from borglab/fix/cmake-wrapper-warnings
Fixed some wrapper warnings
2020-03-29 19:26:58 -04:00
Frank Dellaert 0c2890b815
Merge pull request #252 from borglab/feature/TOA
Time of arrival measurements
2020-03-25 16:41:02 -04:00
Frank Dellaert 1cfcd2075a Style and dates 2020-03-25 08:59:58 -04:00
Varun Agrawal ca4daa0894
Merge pull request #258 from borglab/deprecate-simplecamera
Replace SimpleCamera with PinholeCameraCal3_S2
2020-03-23 08:08:18 -04:00
Varun Agrawal d2d5ce1166 Eigen alignment 2020-03-22 12:46:25 -04:00
Frank Dellaert cd318b2295 Python example and necessary wrapper gymnastics 2020-03-18 17:36:42 -04:00
Frank Dellaert 2e75ffd01d C++ example 2020-03-18 17:28:18 -04:00
Frank Dellaert f3865539c6 Refactor TOAFactor and test 2020-03-18 15:44:33 -04:00
Frank Dellaert 2087075ee7 Transitioned toa method to a functor 2020-03-17 14:34:11 -04:00
Frank Dellaert 8e81890f9b eradicated last vestiges of boost/random in gtsam_unstable 2020-02-28 07:21:54 -08:00
Varun Agrawal d9923fc3cc replaced/appended all calls to SimpleCamera with PinholeCameraCal3_S2 2020-02-21 19:42:55 -05:00
Jose Luis Blanco-Claraco 7d3b3f1172 Fix use of non-standard array of non-constant length 2019-12-28 23:39:54 +01:00
Jose Luis Blanco-Claraco d76fc052b0
fix missing include 2019-12-20 10:06:15 +01:00
Fan Jiang ed7f949385
Merge pull request #156 from borglab/fix/boost-optional
boost::optional<const Ordering &>
2019-11-13 14:32:07 -05:00
Frank Dellaert 4ac78953ae
Merge pull request #163 from michaelbosse/fix/variable_slots_bug
Fix bug when constructing VariableSlots
2019-11-10 13:42:17 +08:00
Michael Bosse fab3b01756 updates from code review 2019-11-09 19:49:59 -08:00
Mike Bosse 8572cd17ad Fix bug when constructing VariableSlots
from a GaussianFactorGraph that has null factors.
2019-11-09 17:05:42 -08:00
Gerry Chen 4877bdb4f3 Caught some stragglers using boost::optional<Ordering> 2019-10-20 03:20:14 -04:00
Gerry Chen 1733f3ac98 convert all optional Ordering to function overloads
compiles and passes tests, but some potentially code-breaking changes in:
Marginals.h - order of arguments had to change since `factorization` has a default value
EliminatableFactorGraph.h - marginalMultifrontalBayesNet and marginalMultifrontalBayesTree no longer accept `boost::none` as a placeholder to specify later arguments
Notes:
EliminateableFactorGraph.h - `orderingType` is no longer needed in function overloads that specify ordering, but I left it for the time being to avoid potential code breaking
2019-10-20 01:15:20 -04:00
duyanwei 38982ae4aa changed function name and made it static 2019-10-18 00:23:06 +08:00
duyanwei dcb82920ea fix default parameters in constructor of IncrementalFixedLagSmoother.h 2019-10-17 21:32:21 +08:00
Frank Dellaert a614e5efa1
Merge pull request #115 from borglab/fix/absolute-value
C++11 Absolute Value
2019-09-19 07:45:40 -04:00
Varun Agrawal ff1f37c26f replaced fabs with c++11 std::abs 2019-09-18 18:30:26 -04:00
Fan Jiang 4949d6988c Fix compilation of PartialPriorFactor 2019-09-07 15:48:30 -04:00
Jose Luis Blanco-Claraco 438b4ff014 more DLL warnings & errors fixed 2019-07-18 11:09:08 +02:00
Jose Luis Blanco-Claraco 52b0579a9b Consistent dllexport.h across gtsam & gtsam_unstable 2019-07-18 08:22:41 +02:00