Commit Graph

118 Commits (f81879aff6b53e385caee0db561833348f262efa)

Author SHA1 Message Date
Frank Dellaert c60d257e80 Add prior and sanitize printing 2025-01-25 15:22:22 -05:00
Varun Agrawal 94a95b69cb update tests 2024-10-15 23:43:52 -04:00
Varun Agrawal e4fff74690 update gtsamAddExamplesGlob and gtsamAddTimingGlob to take an additional argument rather than using a global variable 2023-10-08 12:16:24 -04:00
Varun Agrawal 80a052d048 fix templating TODOs 2023-06-16 10:38:31 -04:00
Varun Agrawal 3374524172 clean up cmake 2023-02-12 22:16:32 -05:00
Frank Dellaert c6dd2bb0f0 Fix up timing and examples 2023-02-06 01:44:55 -08:00
Frank Dellaert bd3b5be0a0 Exclude more files 2023-02-05 20:45:55 -08:00
Frank Dellaert c13f58a67e Got rid of intrusive_ptr 2023-02-05 20:45:54 -08:00
Frank Dellaert 285cbe4f22 Get rid of all (pre c++11) += calls to create Orderings. 2023-02-05 20:45:54 -08:00
Frank Dellaert fbc748a1a1 Merge branch 'develop' into feaure/remove_misc_boost 2023-02-05 10:43:34 -08:00
Frank Dellaert df96d10094 Fix timing script to use c++17 and not boost foreach. 2023-02-04 12:50:25 -08:00
kartik arcot 9347f35ae5 replace boost::format 2023-02-04 12:21:32 -08:00
Frank Dellaert ae7c17420d Replace std::tie with c++17 pattern matching 2023-02-04 10:28:14 -08:00
kartik arcot 769ecd3e96 remove tuple header 2023-01-23 18:30:09 -08:00
kartik arcot 773d4975e6 remove all adaptors 2023-01-23 18:28:55 -08:00
kartik arcot d1d5336ed0 global find/replace. Does not compile 2023-01-23 18:26:44 -08:00
Frank Dellaert 3b94469ce2 Merge branch 'develop' into feature/remove_boost_in_Values 2023-01-22 21:32:27 -08:00
Frank Dellaert 1cf0c59a12 Cleaning up warnings and boost::none 2023-01-22 17:23:38 -08:00
Kartik Arcot 8e48ccd9cf Merge branch 'develop' into verdant/smart_ptrs 2023-01-22 17:10:52 -08:00
kartik arcot bea191f009 removed boost/shared_ptr 2023-01-22 08:40:02 -08:00
kartik arcot c037e0a1fc replaced casts 2023-01-22 08:40:02 -08:00
kartik arcot 852e8768c0 shared_ptr, make_shared, allocate_shared 2023-01-22 08:40:02 -08:00
Frank Dellaert 6743c4f6bc Fixed some stragglers in timing 2023-01-21 20:26:06 -08:00
Frank Dellaert c71d07bbfd Removed filter from examples and timing scripts 2023-01-21 11:39:42 -08:00
kartik arcot 376c910e2b timePose2 updates 2023-01-20 18:06:55 -08:00
kartik arcot bbb997f895 removed some more boost optional matrix references 2023-01-20 18:06:55 -08:00
Frank Dellaert d3a40fbc71 Use initializer lists in tests and gtsam_unstable 2023-01-07 23:59:39 -08:00
Frank Dellaert 9b5321ce03 Remove unused boost::assign headers 2023-01-07 23:58:35 -08:00
Gerry Chen 885eed33d1
replace all NoiseModelFactor1, 2, ... with NoiseModelFactorN 2022-12-22 17:25:48 -05:00
Varun Agrawal c31298d367 Capitalize Identity trait since it is static 2022-07-07 12:31:27 -04:00
acxz eadfabc51d filename in repo is w10000 not w10000-odom 2022-02-27 15:06:56 -05:00
acxz 1bf53fc414 add missing header guards under timing/ and examples/ 2022-02-21 13:50:27 -05:00
Frank Dellaert 3e003bdf46 Add missing header for timing target 2022-02-19 11:09:42 -05:00
Frank Dellaert 9dfe52d0b6 Made reading static named constructors 2022-01-31 13:43:41 -05:00
Frank Dellaert 762e8097bb nr -> number 2022-01-31 12:46:42 -05:00
Frank Dellaert 3d51989f2e Deprecated incorrectly named methods 2022-01-31 08:32:44 -05:00
acxz 7bdaff3cd8 update timeLago.cpp with newer Sampler interface 2021-06-14 15:33:17 -04:00
Toni 7f80c906c4 Fix override warnings: modernize-use-override 2021-01-28 23:02:13 -05:00
Frank Dellaert 84afc94458
Feature/shonan averaging (#473)
Shonan Rotation Averaging.

199 commit messages below, many are obsolete as design has changed quite a bit over time, especially from the earlier period where I thought we only needed SO(4).

* prototyping weighted sampler

* Moved WeightedSampler into its own header

* Random now uses std header <random>.

* Removed boost/random usage from linear and discrete directories

* Made into class

* Now using new WeightedSampler class

* Inlined random direction generation

* eradicated last vestiges of boost/random in gtsam_unstable

* Added 3D example g2o file

* Added Frobenius norm factors

* Shonan averaging algorithm, using SOn class

* Wrapping Frobenius and Shonan

* Fixed issues with <<

* Use Builder parameters

* Refactored Shonan interface

* Fixed << issues as well as MATLAB segfault, using eval(), as discussed in issue #451

* ShonanAveragingParameters

* New factor FrobeniusWormholeFactorP computes |Rj*P - Ri*P*Rij|

* Fixed broken GetDimension for Lie groups with variable dimension.

* Removed all but Shonan averaging factor and made everything work with new SOn

* Just a single WormholeFactor, wrapped noise model

* Use std <random>

* comments/todos

* added timing script

* add script to process ShonanAveraging timing results

* Now producing a CSV file

* Parse csv file and make combined plot

* Fixed range

* change p value and set two flags on

* input file path, all the csv files proceeses at the same time

* add check convergence rate part

* csv file have name according to input  data name

* correct one mistake in initialization

* generate the convergence rate for each p value

* add yticks for the bar plot

* add noises to the measurements

* test add noise

* Basic structure for checkOptimalityAt

* change optimizer method to cholesky

* buildQ now working. Tests should be better but visually inspected.

* multiple test with cholesky

* back

* computeLambda now works

* make combined plots while make bar plot

* Calculate minimum eigenvalue - the very expensive version

* Exposed computeMinEigenValue

* make plots and bar  togenter

* method change to jacobi

* add time for check optimality, min_eigen_value, sub_bound

* updated plot min_eigen value and subounds

* Adding Spectra headers

* David's min eigenvalue code inserted and made to compile.

* Made it work

* Made "run" method work.

* add rim.g2o name

* Fixed bug in shifting eigenvalues

* roundSolution which replaces projectFrom

* removed extra arguments

* Added to wrapper

* Add SOn to template lists

* roundSolution delete the extra arguement p

* only calculate p=5 and change to the correct way computing f_R

* Fixed conflict and made Google-style name changes

* prototype descent code and unit test for initializeWithDescent

* add averaging cost/time part in processing data

* initializewithDescent success in test

* Formatting and find example rather than hardcode

* Removed accidentally checked in cmake files

* give value to xi by block

* correct gradient descent

* correct xi

* }

* Fix wrapper

* Make Hat/Vee have alternating signs

* MakeATangentVector helpder function

* Fixed cmake files

* changed sign

* add line search

* unit test for line search

* test real data with line search

* correct comment

* Fix boost::uniform_real

* add save .dat file

* correct test case

* add explanation

* delete redundant cout

* add name to .dat output file

* correct checkR

* add get poses_  in shonan

* add Vector Point type for savig data

* Remove cmake file which magically re-appeared??

* Switched to std random library.

* Prepare Klaus test

* Add klaus3.g2o data.

* fix comment

* Fix derivatives

* Fixed broken GetDimension for Lie groups with variable dimension.

* Fix SOn tests to report correct dimension

* Added tests for Klaus3 data

* Add runWithRandomKlaus test for shonan.

* Finish runWithRandomKlaus unittest.

* Correct datafile.

* Correct the format.

* Added measured and keys methods

* Shonan works on Klaus data

* Create dense versions for wrappers, for testing

* Now store D, Q, and L

* Remove another cmake file incorrectly checked in.

* Found and fixed the bug in ComputeLambda !

* Now using Q in Lambdas calculation, so Lambdas agree with Eriksson18cvpr.

* Make FrobeniusFactor not use deprecated methods

* FrobeniusWormholeFactor takes Rot3 as argument

* Wrapped some more methods.

* Wrapped more methods

* Allow creating and populating BetweenFactorPose3s in python

* New constructors for ShonanAveraging

* add function of get measurements number

* Remove option not to use noise model

* wrap Use nrMeasurements

* Made Logmap a bit more tolerant of slightly degenerate rotations (with trace < -1)

* Allow for Anchor index

* Fix anchor bug

* Change outside view to Rot3 rather than SO3

* Add Lift in SOn class

* Make comet working

* Small fixes

* Delete extra function

* Add SOn::Lift

* Removed hardcoded flag

* Moved Frobenius factor to gtsam from unstable

* Added new tests and made an old regression pass again

* Cleaned up formatting and some comments, added EXPORT directives

* Throw exception if wrongly dimensioned values are given

* static_cast and other throw

* Fixed run-time dimension

* Added gauge-constraining factor

* LM parameters now passed in, added Gauge fixing

* 2D test scaffold

* Comments

* Pre-allocated generators

* Document API

* Add optional weight

* New prior weeights infrastructure

* Made d a template parameter

* Recursive Hat and RetractJacobian test

* Added Spectra 0.9.0 to 3rdparty

* Enabling 2D averaging

* Templatized Wormhole factor

* ignore xcode folder

* Fixed vec and VectorizedGenerators templates for fixed N!=3 or 4

* Simplifying constructors
Moved file loading to tests (for now)
All unit tests pass for d==3!

* Templated some methods internally

* Very generic parseToVector

* refactored load2d

* Very much improved FrobeniusWormholeFactor (Shonan) Jacobians

* SO(2) averaging works !

* Templated parse methods

* Switched to new Dataset paradigm

* Moved Shonan to gtsam

* Checked noise model is correctly gotten from file

* Fixed covariance bug

* Making Shonan wrapper work

* Renamed FrobeniusWormholeFactor to ShonanFactor and moved into its own compilation unit in gtsam/sfm

* Fixed wrong include

* Simplified interface (removed irrelevant random inits) and fixed eigenvector test

* Removed stray boost::none

* Added citation as suggested by Jose

* Made descent test deterministic

* Fixed some comments, commented out flaky test

Co-authored-by: Jing Wu <jingwu@gatech.edu>
Co-authored-by: jingwuOUO <wujing2951@gmail.com>
Co-authored-by: swang <swang736@gatech.edu>
Co-authored-by: ss <ss>
Co-authored-by: Fan Jiang <prof.fan@foxmail.com>
2020-08-17 07:43:10 -04:00
Frank Dellaert 8288b55d4e Addressed review comments 2020-08-16 17:30:52 -04:00
Frank Dellaert fc08562641 Hunted down deprecated use of parse3DLandmarks 2020-08-15 08:06:37 -04:00
Frank Dellaert e62d04ce27 Templated parse methods 2020-08-14 19:10:31 -04:00
Frank Dellaert a4590a2fe3 Allow to pass in pre-computed generators. Should save some energy. 2020-08-01 15:43:55 -04:00
acxz 15f581ce29 pass in expected Rot3 and parameter p 2020-07-24 16:40:18 -04:00
acxz 5eb2bea357 use reasonable distribution name 2020-07-23 14:54:21 -04:00
acxz d5d58fd707 use reasonable distribution names 2020-07-23 14:49:13 -04:00
acxz e993afe2bf replace boost random with std random 2020-07-23 14:05:23 -04:00
Frank Dellaert 0bd8143057 Importing Frobenius error factors from Shonan effort 2020-06-19 23:33:29 -04:00
acxz 93b4081c7f update timing to use internal timing.h api 2020-05-09 21:29:08 -04:00
alescontrela 211119b00e Replace addPrior<> with addPrior 2020-04-12 13:10:09 -04:00