- Among the lines added in #150, the one that fixes building with Qt5 is
the following line:
include_directories(${Qt5Widgets_INCLUDE_DIRS})
The rest is redundant and actually doesn't do anything. A CMake
variable named QtX_INCLUDE_DIRS is not defined when find_package()-ing
Qt. Also, there is no need to find_package() Qt5 Widgets twice.
- In documentation, add sudo to rosdep init invocation, following
http://wiki.ros.org/rosdep. Add a comment about the error which will
be printed if the user has already run sudo rosdep init since
installing ROS.
* Change mutex locker scope in SubmapsDisplay::update()
This avoids the potential unsafe situation where someone (for example,
SubmapsDisplay::Reset()) clears the trajectories vector, but update()
uses it after the mutex has been released, since the scope of the lock
was only in the try block.
Also resolve a miscellaneous signed-unsigned warning.
* Make DrawableSubmap destructor safer
Make the DrawableSubmap destructor wait for the asynchronous fetch
thread to finish - otherwise, it's possible to crash rviz by rapidly
pressing the enable checkbox of the submaps plugin. Eventually the race
condition will be triggered, and the fetch thread will write into a
deleted DrawableSubmap object, which causes a crash.
Add support for building libcartographer in the same project
Support adding as a CMake subproject by using the PROJECT_*_DIR variables
instead of the absolute CMAKE_*_DIR variables.
Resolve a signed-unsigned comparison compiler warning
Fix comment typo
- Move sources from <project>/src into project/project and fix includes.
- Add autogenerated CMakeFiles for ROS projects. The python script is
not yet fully updated to be used for keeping the files updated without
manual intervention though.
- Build everything with -fPIC, so we can create shared libraries.
We disable backface culling so that submaps also show when looked at from
below.
We add a depth bias to move submaps further to the back, so that submaps
do not overdraw the visualization of laser scans which makes the latter
sometimes hard to see.
Juraj Oršulić
Damon Kohler
Wolfgang Hess
Thiago de Freitas
Holger Rapp
Damon Kohler