Commit Graph

16150 Commits (a96b6918dbce44c1eb4b6be2cdd3233d28c45798)

Author SHA1 Message Date
Frank Dellaert a96b6918db
Merge pull request #1464 from Ibarria/law/cmakeoptions
Allow override of BUILD_SHARED_LIBS
2023-02-16 10:59:25 -08:00
Varun Agrawal 3e4884d019
Merge pull request #1467 from borglab/fixes-from-4.2 2023-02-16 01:22:32 -05:00
Varun Agrawal d303b221de
Merge branch 'develop' into law/cmakeoptions 2023-02-15 21:52:28 -05:00
Lawrence Ibarria b103fea40c Fix cmake issue with msvc
The cmake call to set_properties is fully overriding a property,
in this case the COMPILE_DEFINITIONS and we were losing an eigen
definition needed. The correct way to do this is to use the cmake
function target_compile_definitions
2023-02-15 07:42:52 -08:00
Frank Dellaert 282c3f4d45
Merge pull request #1465 from borglab/fixes
CMakes updates
2023-02-14 22:29:43 -08:00
Varun Agrawal 04daae036e fix to remove leftover boost 2023-02-13 20:00:09 -05:00
Varun Agrawal e36440b08d add ordering method for HybridSmoother 2023-02-13 19:40:53 -05:00
Varun Agrawal 765e73879b Add better hybrid support 2023-02-13 19:40:38 -05:00
Varun Agrawal df973651fb remove commented Cmake commands 2023-02-13 19:38:36 -05:00
Varun Agrawal e08c227f0b only print cmake compile options for current build version 2023-02-13 19:38:21 -05:00
Varun Agrawal 464b025b46 Revert "enforce C++17 standards"
This reverts commit 4e999b3419.
2023-02-13 12:05:59 -05:00
Varun Agrawal 4e999b3419 enforce C++17 standards 2023-02-13 11:02:19 -05:00
Varun Agrawal 0e6cbfd44a improved CMake for Boost serialization flag 2023-02-13 11:00:14 -05:00
Varun Agrawal 3374524172 clean up cmake 2023-02-12 22:16:32 -05:00
Frank Dellaert 32c5bb2aad
Merge pull request #1460 from borglab/fix/concepts
Reverted ill-advised concepts, attempt 2
2023-02-12 16:46:09 -08:00
Lawrence Ibarria 5851656544 Merge remote-tracking branch 'origin/develop' into law/cmakeoptions 2023-02-12 14:32:45 -08:00
Frank Dellaert 03de47b860
Merge pull request #1458 from borglab/fix/expressions
Cross-platform traceStorage
2023-02-12 14:01:13 -08:00
Lawrence Ibarria 5347d205e8 Minor cleanup on HandleEigen.cmake 2023-02-12 13:39:39 -08:00
Lawrence Ibarria 1bed89e942 Allow override of BUILD_SHARED_LIBS
The cmake option BUILD_SHARED_LIBS is a cmake built-in option
to control if libraries are by default SHARED or STATIC.

For large projects, it is desired to be able to design gtsam as a
shared or static library regardless of the value of BUILD_SHARED_LIBS.
This change is unobtrusive, two new cmake options are created, to
force gtsam to be a shared or static library. If neither option is
set (this is the default), the behavior of gtsam remains unchanged
which is to use BUILD_SHARED_LIBS decision.
2023-02-12 13:29:30 -08:00
Frank Dellaert 9cc00a85f6 Merge branch 'develop' into fix/expressions 2023-02-12 07:12:23 -08:00
Frank Dellaert 16bffa645f
Merge pull request #1456 from borglab/fix/warnings
Fixed warnings that arise from stricter compiler flags
2023-02-12 07:03:08 -08:00
Frank Dellaert 72cdcf8ce3
Merge pull request #1453 from keevindoherty/hotfix/sumproduct
Add normalization to sum-product, avoiding underflow.
2023-02-11 22:46:50 -08:00
Frank Dellaert 598582087f Remove more redundant virtual destructors 2023-02-11 22:46:16 -08:00
Frank Dellaert 87cfb25635 Fix whitespace 2023-02-11 22:45:37 -08:00
Frank Dellaert 9e460d26eb Fix TBB compilation issue 2023-02-11 22:45:15 -08:00
Frank Dellaert cb6603416c Fix TBB compilation issue 2023-02-11 22:17:46 -08:00
Frank Dellaert b30d553042 Got rid of some warnings in the boost-free path 2023-02-11 17:28:48 -08:00
Frank Dellaert c647257ffd Replaced numbered GTSAM_CONCEPT_ASSERT# with GTSAM_CONCEPT_ASSERT 2023-02-11 17:17:18 -08:00
Kevin 92443f5378 Simply sum-product test in Python. 2023-02-11 20:04:43 -05:00
Kevin 9fa2d30362 Test sum-product in discrete factor graph up to scale. 2023-02-11 20:00:26 -05:00
Kevin 70fa568131 Normalize products by max in discrete elimination. 2023-02-11 19:59:16 -05:00
Kevin feaa07ad02 Merge branch 'develop' of github.com:keevindoherty/gtsam into hotfix/sumproduct 2023-02-11 19:33:27 -05:00
Frank Dellaert 179575764a Reverted ill-advised quick fix for concepts - now no-op. 2023-02-11 15:54:28 -08:00
Frank Dellaert 81ce4f4d9e Avoid issues on platforms where Eigen decides it needs 32 byte alignment. 2023-02-11 15:19:48 -08:00
Frank Dellaert 38a9ba3692 Work with raw char pointers to have correct pointer arithmetic and avoid buffer overflow. 2023-02-11 15:19:19 -08:00
Frank Dellaert 04e155c9d4 Make sure pointer arithmetic is correct 2023-02-11 12:38:11 -08:00
Frank Dellaert ae1526dd8a Fix warnings and use new allocAligned scheme 2023-02-11 12:37:52 -08:00
Frank Dellaert 73c20c2ae1 New unified allocAligned scheme 2023-02-11 12:37:39 -08:00
Frank Dellaert dfb79632be Fix warnings 2023-02-11 12:37:03 -08:00
Frank Dellaert a8eb98acea Fixed warnings that arise from stricter compiler flags 2023-02-11 12:32:50 -08:00
Kevin 548509f28b First pass at underflow test for sum-product. 2023-02-10 17:02:27 -05:00
Kevin 29358f826b Patch discrete factor graph test to normalize expected result. 2023-02-09 14:23:52 -05:00
Frank Dellaert b71ed8f91d
Merge pull request #1441 from wanmeihuali/hotfix/stack_overflow
Fixing stack overflow issue for large tree
2023-02-08 19:07:02 -08:00
Kevin 0710a8a893 Add normalization trick to sum-product. 2023-02-08 14:15:32 -05:00
Kevin Doherty 4f4c6eba7e
Merge pull request #1449 from keevindoherty/hotfix/maxproduct
Add normalization to max-product, avoiding underflow.
2023-02-08 10:15:09 -05:00
Kevin 9d0be8f2b2 Use simpler normalization for max-product. 2023-02-08 08:55:03 -05:00
wanmeihuali 36e9d4aaed move the destructor implementation from .h to -inst.h 2023-02-07 17:51:08 -08:00
Kevin 571b0f5e90 Add toy problem testing max-product underflow. 2023-02-07 10:43:16 -05:00
Kevin 148d99f1d1 Add normalization to max-product, avoiding underflow. 2023-02-07 10:15:57 -05:00
wanmeihuali 46c311b5b9
Merge branch 'borglab:develop' into hotfix/stack_overflow 2023-02-06 12:58:52 -08:00