Commit Graph

13366 Commits (3e41ece75a0ba8fc923ea6f59d912fd52f3914d3)

Author SHA1 Message Date
roderick-koehle 3e41ece75a
Minor fix test_Cal3Unified 2021-07-13 22:10:38 +02:00
roderick-koehle 17c37de7c4
Shared setup triangulation unit test 2021-07-13 22:07:19 +02:00
roderick-koehle 3402e46ad1
Shared data for triangulation unit tests 2021-07-13 22:00:21 +02:00
roderick-koehle f53f5db4d1
Merge branch 'borglab:develop' into python-fisheye-interface 2021-07-13 12:03:10 +02:00
Varun Agrawal 39b1b15c3e
Merge pull request #819 from borglab/feature/std-bind-placeholders 2021-07-11 07:33:32 -07:00
roderick-koehle c595767cae
Unittest, triangulation for Cal3Unified 2021-07-11 14:14:08 +02:00
roderick-koehle 941594c94b
Testing CameraSet and triangulatePoint3
Currently triangulatePoint3 returns wrong results for fisheye models. The template for PinholePose may be implemented for a fixed size of variable dimensions.
2021-07-11 14:11:40 +02:00
Varun Agrawal dfc77f0967
Merge pull request #818 from borglab/tbb-disabling-instructions 2021-07-10 21:07:15 -04:00
Varun Agrawal d5890a2d61 update all the tests 2021-07-10 21:03:15 -04:00
Varun Agrawal dc8b5e58ff replaced boost with std for placeholders, bind and function 2021-07-10 21:01:20 -04:00
roderick-koehle 0a73961f5a
Update ignore list in CMakeFile 2021-07-10 23:05:53 +02:00
roderick-koehle 3118fde6d3
Missing CameraSet binding specialisations
Add pybind specialisations for CameraSetCal3Unified and CameraSetCal3Fisheye.
2021-07-10 23:00:24 +02:00
roderick-koehle d54e234f93
Add ambiguous calibrate/uncalibrate declarations.
Without declaring calibrate / uncalibrated in the interface specification, the functions of the Base class Cal3DS2_Base is called.
The layout of the optional Jacobian matrix is 2x10 in Cal3Unified and 2x9 in Cal3DS2_Base, so this are different function calls.
2021-07-10 22:03:17 +02:00
John Lambert 63236cf7af
improve wrapper compilation instructions, when TBB not installed 2021-07-10 11:37:59 -04:00
John Lambert 8b86d7a51c
improve docs about compiling without TBB 2021-07-10 11:36:36 -04:00
roderick-koehle 03049929a5
Add comment about initial guess in undistortion
For the equidistant fisheye model, r/f = tan(theta), the Gauss-Newton search to model radial distortion is expected to converge faster by mapping the angular coordinate space into the respective tangent space of the perspective plane. This is consistent to the nPlaneToSpace initial projection used in the calibrate() function of the omnidirectional model (Cal3Unified).
2021-07-10 15:21:22 +02:00
Varun Agrawal 4ac4302871
Merge pull request #813 from borglab/feature/between-factor-tests 2021-07-09 18:19:29 -04:00
Varun Agrawal 4fc68593ac
Merge pull request #814 from borglab/fix/misc 2021-07-09 18:19:03 -04:00
Varun Agrawal 2e40169324 fix dimension for Pose3 test 2021-07-09 14:07:19 -04:00
Varun Agrawal 8b9e60156c cleaner variables 2021-07-09 14:06:59 -04:00
roderick-koehle 66af0079ba
Improved accuracy for analytic undistortion 2021-07-09 12:39:31 +02:00
roderick-koehle a411b664a1
Correct tab to spaces to fix formatting 2021-07-09 11:25:18 +02:00
roderick-koehle 6205057ccb
Use of common setUpClass method 2021-07-09 11:17:38 +02:00
roderick-koehle bdeb60679b
Introduce setUpClass, python snake_case variables
Test case fails if object depth z is not equal 1.
2021-07-09 11:14:10 +02:00
Varun Agrawal d7d9ac0f06 typo fix 2021-07-08 19:43:25 -04:00
Varun Agrawal a12b49de40 add Pose3 expmap to wrapper 2021-07-08 19:43:09 -04:00
Varun Agrawal 2ecad47b9e Added lots of tests for BetweenFactor 2021-07-08 19:41:01 -04:00
roderick-koehle 19e8cde733
Extend unit testing of omnidirectional projection
Test projection function and factors using a stereoscopic (xi=1) reference model, i.e the image height is given by y = 2 f tan(theta/2).
2021-07-08 19:59:56 +02:00
roderick-koehle c8fc3cd216
Unit test for equidistant fisheye 2021-07-08 19:53:41 +02:00
roderick-koehle 55c12743fc
Forward declaration of fisheye camera.
Forward declaration of PinholeCal3Fisheye needed by Python wrapper.
2021-07-08 15:45:11 +02:00
roderick-koehle 73d40a5c64
Merge pull request #2 from roderick-koehle/patch-2
Forward declaration for Set of Fisheye Cameras
2021-07-08 15:39:10 +02:00
roderick-koehle 03e2744f71
Merge pull request #1 from roderick-koehle/patch-3
Extend python wrapper to include fisheye models.
2021-07-08 15:37:39 +02:00
roderick-koehle dfd50f98c2
Extend python wrapper to include fisheye models.
Extend python wrapper to include fisheye camera models Cal3Fisheye and Cal3Unified.
2021-07-08 15:13:29 +02:00
roderick-koehle 9967c59ed0
Forward declaration for Set of Fisheye Cameras
Forward declaration of camera vector for PinholeCamera<Cal3Fisheye> and PinholeCamera<Cal3Unified>.
2021-07-08 14:30:16 +02:00
Varun Agrawal cd3854a1f6
Merge pull request #796 from acxz/boost-bind-warn 2021-07-07 10:34:54 -04:00
Frank Dellaert 6d6d129d05
Merge pull request #806 from jaelrod/fix/rot2-copy-ctor
Add user-defined copy constructor for Rot2
2021-06-30 14:41:40 -04:00
Jay Elrod 7c358aae4c Add user-defined copy constructor for Rot2 2021-06-29 17:07:15 -04:00
Akash Patel 5a2ff198f0
Merge branch 'develop' into boost-bind-warn 2021-06-28 10:54:48 -04:00
Varun Agrawal 6ee17c2ed7
Merge pull request #800 from acxz/fix/tbb-deprecation 2021-06-23 13:21:15 -04:00
Varun Agrawal 91674c8008
Merge pull request #802 from borglab/fix/llvm-gpg-key 2021-06-22 13:50:30 -04:00
Varun Agrawal 04621b0275 update key server in other workflow files 2021-06-22 07:50:54 -04:00
Varun Agrawal 3244679dd1 update the pgp servers to get the LLVM GPG key 2021-06-21 23:25:03 -04:00
Akshay Krishnan aec2cf06a5
Merge pull request #753 from borglab/feature/essential-mat-with-approx-k
Adding factor which considers the essential matrix and camera calibration as variable
2021-06-21 09:14:06 -07:00
akrishnan86 01561bc217 formatting example 2021-06-20 22:26:19 -07:00
Akshay Krishnan 119e43aeac all jacobian tests for essential matrix use macro 2021-06-21 05:21:19 +00:00
Akshay Krishnan a69f9e59b4 changing to macro EssenstialMatrixfactor4 2021-06-21 03:47:44 +00:00
Akshay Krishnan e3b6c8308a updating points name, constexpr 2021-06-21 03:47:10 +00:00
acxz 944b3aea29 formatting 2021-06-20 20:37:49 -04:00
acxz e57fe4ab2f add comment for purpose of variable 2021-06-20 19:03:33 -04:00
acxz 155fafabf2 using using for boost placeholders in tests 2021-06-20 18:38:52 -04:00