dellaert
cb69f2cb82
Fastest linearize so far. Putting 'unsafe' constructor in JacobianFactor itself makes a *huge* difference.
2014-11-02 11:40:48 +01:00
Frank Dellaert
a1c6c3cbe5
Merged in feature/BAD_VerticalBlockMatrix (pull request #29 )
...
Straight copy into VerticalBlockMatrix
2014-11-01 19:26:14 +01:00
Paul Furgale
95e59d7c5d
Fixed the last failing unit test
2014-11-01 19:23:07 +01:00
dellaert
7aaf4dae8c
Merge remote-tracking branch 'origin/feature/BAD_VerticalBlockMatrix' into feature/BAD_WriteableJacobianFactor
...
Conflicts:
gtsam_unstable/nonlinear/ExpressionFactor.h
2014-11-01 17:45:23 +01:00
dellaert
7debde7518
Moved to ExpressionFactor that now uses it - timing seems worse ?
2014-11-01 15:12:06 +01:00
dellaert
12e38a44e4
WriteableJacobianFactor will allow ExpressionFactor to write into the factor directly, (hopefull) eliminating huge overhead.
2014-11-01 14:13:08 +01:00
dellaert
a4fa61a7a4
Removed JacobianMap tests
2014-11-01 11:56:38 +01:00
dellaert
f38b0b0eed
Fixed unwhitenedError
2014-11-01 11:50:28 +01:00
Paul Furgale
15ab2b27bc
Fixed one unit test
2014-11-01 11:47:56 +01:00
dellaert
7b539fbb5c
Make JacobianMap a wrapper around a VerticalBlockMatrix, which avoids us having to make a vector of references into it
2014-11-01 11:35:49 +01:00
Frank Dellaert
8e7864dc96
Merged in feature/BAD_vector (pull request #28 )
...
Changed the type of JacobianMap as std::vector
2014-10-31 16:29:35 +01:00
dellaert
593edd1e5c
Fixed asserts
2014-10-31 16:29:15 +01:00
dellaert
d0c3bc0c8e
Fixed tests
2014-10-31 16:27:54 +01:00
dellaert
768a4abc05
Does not need lambda
2014-10-31 16:27:46 +01:00
Sungtae An
a5b8d0fd35
Modified finding method
2014-10-31 11:06:26 -04:00
Mike Bosse
5e51745b86
debugging serialization of ChartValues
2014-10-31 14:21:02 +01:00
dellaert
f5c6ccca17
Changed size (because transpose_) was removed
2014-10-31 13:48:39 +01:00
Sungtae An
6a20d35a60
Modified pointer expression
2014-10-31 07:28:07 -04:00
Sungtae An
133fcf20e2
Cleaned up some commented codes
2014-10-31 07:22:19 -04:00
Sungtae An
97d4120858
Changed the type of JacobianMap as std::vector
2014-10-31 07:10:53 -04:00
cbeall3
699153ece9
Coding convention: convert tabs to two spaces
2014-10-30 12:44:46 -04:00
Mike Bosse
003224ac3f
fixing serialization code when class has no base
2014-10-30 17:21:24 +01:00
Renaud Dube
7d8ba565e5
Adapted ChartValue so that it can wrap a value to be passed to ExpressionFactor
2014-10-30 15:59:28 +01:00
cbeall3
57b4c79cad
minor doxygen fixes
2014-10-29 13:58:46 -04:00
Michael Bosse
18ad04970a
Merged in feature/BAD_generic_value_traits_no_cpp11 (pull request #27 )
...
reclaced std::type_traits with boost::type_traits
2014-10-29 11:00:50 +01:00
gawela
2788ec7f33
removed std::type_traits which is c++11
2014-10-29 10:23:13 +01:00
Michael Bosse
ef23309c84
Merged in feature/BAD_generic_chart_value (pull request #26 )
...
Generic Chart Values
2014-10-28 23:56:15 +01:00
Mike Bosse
f8183acd87
I should have remembered to compile and check before committing.
2014-10-28 17:37:45 +01:00
Mike Bosse
82f6ed5ca8
inserted spaces after commas
2014-10-28 14:15:34 +01:00
Mike Bosse
80187362b8
attemping to expose ChartValue for expressions with non DefaultCharts, but needs testing
2014-10-28 11:20:02 +01:00
Mike Bosse
ab76a306b7
using dynamic_cast to check base class typeid
2014-10-28 08:54:41 +01:00
Mike Bosse
bc094951ed
all values in Values container are now a ChartValue<ValueType, Chart=DefaultChart<ValueType> >
...
ChartValues are GenericValues and a Chart, which defaults to DefaultChart
had to make charts functional (ie no storage of the chart origin) so that they could be zero sized base class
otherwise there would have been a double of the memory for values (ones for the value, and once for the chart origin, which default to the same)
most tests work, execept for serialization based stuff, and const filtering of values.
2014-10-28 00:57:44 +01:00
cbeall3
fdaaf4c558
Add intermediate file for round-trip dataset test to ignore
2014-10-25 20:20:35 -04:00
cbeall3
f833472898
Remove intermediate file for dataset I/O test
2014-10-25 20:18:55 -04:00
Mike Bosse
9ef8980362
using static_cast in GenericValue's virtual functions
...
should be more efficient, but perhaps will crash instead of throwing an exception when the Value& derived class doesn't match.
2014-10-25 22:23:26 +02:00
Mike Bosse
c2cdd21a7a
added cast<ValueType> function to Value
2014-10-25 12:18:12 +02:00
Chris Beall
60ebd9cb4e
rename simple namespace to avoid clash on Windows
2014-10-25 06:01:20 -04:00
Chris Beall
f19cb3e677
Change expected error value back to negative, as it was (accidentally?) flipped after recent pull request , which didn't pass. The negative value, which I believe to be correct, passes in Quaternion mode, Full Expmap mode, as well as regular rotation matrix mode (with a lesser tolerance.)
2014-10-25 01:08:59 -04:00
Mike Bosse
4a3dc51f85
more tests work, except for serialization based tests
2014-10-24 23:47:02 +02:00
Mike Bosse
5b2a61682d
tests compiling, but many fail
2014-10-24 22:38:03 +02:00
cbeall3
f916531492
remove typename from non-templated class
2014-10-24 13:06:45 -04:00
cbeall3
1dec2c230c
Kill unused variables
2014-10-24 13:01:30 -04:00
Mike Bosse
1fadda83e0
removed DerivedValue<> inheritence from classes
2014-10-24 18:34:06 +02:00
Mike Bosse
0681212084
GenericValue based on defined traits to replace DerivedValue, first implementation
2014-10-24 16:59:37 +02:00
Chris Beall
eeb0293f27
Merged in feature/FixQuaternion (pull request #22 )
...
Was quaternion (somewhat) broken ?
2014-10-24 09:53:50 -04:00
Mike Bosse
95827dd4d8
GenericValue.h copied from DerivedValue.h
2014-10-24 11:27:38 +02:00
cbeall3
265bd1972d
Fix for flipped sign in quaternion mode on Linux and Windows
2014-10-23 17:08:30 -04:00
dellaert
c1c6a30e50
Removed print statement
2014-10-23 22:39:07 +02:00
Siddharth Choudhary
f81fa0a203
Unit test for load2D for victoria park dataset
2014-10-23 15:51:47 -04:00
dellaert
cfe56a0aa8
Removed transpose_. It did speed up things but was bad design. Will need to profile again and find different ways to cope with transpose() overhead. One way is to return a Eigen::Transpose<> object as hinted to in comments.
2014-10-23 19:13:37 +02:00