Commit Graph

18243 Commits (d5f304ef50d65b89257dddd471df22a9b10c9e23)

Author SHA1 Message Date
Varun Agrawal d5f304ef50
Merge pull request #1974 from borglab/fix-examples 2025-01-21 00:27:56 -05:00
Varun Agrawal 2115cd19d2 special CI build for examples 2025-01-20 19:23:32 -05:00
Varun Agrawal 17bf352e26 Merge branch 'develop' into fix-examples 2025-01-20 19:20:40 -05:00
Varun Agrawal c3908c8666
Merge pull request #1977 from JokerJohn/fix/1452 2025-01-20 19:15:07 -05:00
JokerJohn 49abc02b4e remove unitest of issue1452 2025-01-21 04:02:54 +08:00
Varun Agrawal 199b6cfcaa
Merge pull request #1984 from borglab/fixes 2025-01-20 13:20:48 -05:00
Varun Agrawal 08fc4885f7 check for boost all in one step 2025-01-20 10:45:04 -05:00
Varun Agrawal cdb761c603 update unix.sh to set Boost flags from env variable correctly 2025-01-20 10:43:36 -05:00
Varun Agrawal 5ce332764c don't install boost if no_boost flag is set 2025-01-20 10:27:11 -05:00
Varun Agrawal c2ee7ff122 bracket clang and GCC 2025-01-20 10:26:54 -05:00
Varun Agrawal 36758a818f add comment and remove unnecessary copy-constructor 2025-01-20 10:20:21 -05:00
Varun Agrawal 7eb5ad67e3 use reference capture instead of copy capture 2025-01-20 10:20:01 -05:00
Varun Agrawal 3d116d7fdf pass in this to lambda expression explicitly 2025-01-20 10:04:06 -05:00
Varun Agrawal ba355bc707 Merge branch 'develop' into fixes 2025-01-20 09:51:47 -05:00
Frank Dellaert ee7616e421
Merge pull request #1983 from mcm001/bayestree-dtor-std-move
Reduce smart pointer copies in destructors
2025-01-20 09:33:54 -05:00
Varun Agrawal aa91159fcb add Ubuntu 24.04 to the CI 2025-01-20 02:35:20 -05:00
Varun Agrawal a00335ff4a fully declare struct U 2025-01-20 02:32:17 -05:00
Varun Agrawal 0959bfef5c replace #ifdef with #if 2025-01-20 02:27:31 -05:00
Matt Morley 71944110e9 Make destructors protected 2025-01-19 21:24:42 -08:00
Matt Morley b3c02d2b40 Move shared pointers in dtors 2025-01-19 20:55:51 -08:00
Matt Morley 6697452954 Boost ifdef -> if macro 2025-01-19 20:52:25 -08:00
JokerJohn a9da253d00 add IncrementalFixedLagSmootherExample 2025-01-18 17:38:34 +08:00
JokerJohn 630ee11885 remove example 2025-01-17 23:57:58 +08:00
Frank Dellaert 717e3bea63
Merge pull request #1975 from mnissov/gps-lever-arm
Adding lever-arm to GPS factors
2025-01-17 08:14:38 -05:00
morten d1106ae4a3 adding GPSFactors with lever arm as state 2025-01-16 21:27:42 +01:00
morten 0c13038ed5 typo in print for GPSFactor2Arm 2025-01-16 21:26:47 +01:00
Frank Dellaert 61f2fdd042
Merge pull request #1979 from borglab/fix/faster_expmaps
Faster SE(3) and SE_2(3) exponential maps
2025-01-16 14:43:57 -05:00
morten b5349a74f5 improved documentation, params and getters 2025-01-16 18:12:07 +01:00
morten 4737f0d554 improving comments 2025-01-16 17:57:29 +01:00
Frank Dellaert 2042977d28 Last comment I hope 2025-01-16 00:54:49 -05:00
Frank Dellaert e3e4736e5e Fix comments about R^T 2025-01-16 00:41:08 -05:00
Frank Dellaert fdf8a51a44 X = R^T, according to Barfoot Eq 8.83 2025-01-15 18:09:26 -05:00
Frank Dellaert b0e9b16cc4 expmap now returns Matrix3 2025-01-15 18:09:01 -05:00
yetongumich 3c382dd47f
Merge pull request #1789 from borglab/feature/constrained_optimization
add definition of constraints
2025-01-15 09:58:30 -08:00
morten 94e96ab001 remove EstimateState from GPSFactorArm 2025-01-15 13:38:08 +01:00
morten b81593601a creating GPSFactorArm and GPSFactor2Arm w/ lever arm arguments 2025-01-15 13:31:38 +01:00
morten af1e6e34e6 reverting changes to existing factors 2025-01-15 11:54:41 +01:00
Frank Dellaert d6581cdef9 Fixed typo in quaternion path 2025-01-15 00:45:07 -05:00
JokerJohn 6795bf5709 add a new line at the end of file 2025-01-15 13:33:53 +08:00
JokerJohn fbd45776a6 add a new line at the end of file 2025-01-15 13:21:32 +08:00
JokerJohn 3743b562c1 Move the example to the appropriate folder, and modify the code for reading files and adding factors. 2025-01-15 13:17:21 +08:00
Frank Dellaert 04e04eed52 inlined ExpmapTranslation 2025-01-15 00:15:34 -05:00
JokerJohn c2355fd95a add IncrementalFixedLagExample to show the issue #1452 2025-01-14 19:47:30 +08:00
JokerJohn a4f88d2d25 add IncrementalFixedLagExample to showcase how setting addresses the issue #1452 2025-01-14 19:44:16 +08:00
morten 7efcb468f5 update GPSFactor interface 2025-01-14 12:09:27 +01:00
morten 57b8f6b158 fix GPSFactor serialization 2025-01-14 12:09:10 +01:00
Frank Dellaert 088332978b Check issue 1452 2025-01-13 13:02:39 -05:00
morten 5254b4f0b1 adding lever arm optional argument to gps factors 2025-01-13 16:55:40 +01:00
Tyler Veness 4cbf673540 Add missing test include for assert_inequal()
Here's the compilation errors without it.
```
In file included from /home/tav/git/gtsam/CppUnitLite/TestHarness.h:23,
                 from /home/tav/git/gtsam/gtsam/discrete/tests/testDecisionTreeFactor.cpp:20:
/home/tav/git/gtsam/gtsam/discrete/tests/testDecisionTreeFactor.cpp: In member function ‘virtual void DecisionTreeFactorDivideTest::run(TestResult&)’:
/home/tav/git/gtsam/gtsam/discrete/tests/testDecisionTreeFactor.cpp:123:25: error: invalid initialization of reference of type ‘const gtsam::Vector&’ {aka ‘const Eigen::Matrix<double, -1, 1>&’} from expression of type ‘gtsam::DecisionTreeFactor’
  123 |   EXPECT(assert_inequal(pS, s));
      |                         ^~
/home/tav/git/gtsam/CppUnitLite/Test.h:151:9: note: in definition of macro ‘EXPECT’
  151 | { if (!(condition)) \
      |         ^~~~~~~~~
In file included from /home/tav/git/gtsam/gtsam/inference/DotWriter.h:22,
                 from /home/tav/git/gtsam/gtsam/inference/FactorGraph.h:25,
                 from /home/tav/git/gtsam/gtsam/inference/MetisIndex.h:21,
                 from /home/tav/git/gtsam/gtsam/inference/Ordering.h:25,
                 from /home/tav/git/gtsam/gtsam/discrete/DiscreteFactor.h:25,
                 from /home/tav/git/gtsam/gtsam/discrete/DecisionTreeFactor.h:22,
                 from /home/tav/git/gtsam/gtsam/discrete/tests/testDecisionTreeFactor.cpp:23:
/home/tav/git/gtsam/gtsam/base/Vector.h:163:48: note: in passing argument 1 of ‘bool gtsam::assert_inequal(const Vector&, const Vector&, double)’
  163 | GTSAM_EXPORT bool assert_inequal(const Vector& vec1, const Vector& vec2, double tol=1e-9);
      |                                  ~~~~~~~~~~~~~~^~~~
/home/tav/git/gtsam/gtsam/discrete/tests/testDecisionTreeFactor.cpp:131:25: error: invalid initialization of reference of type ‘const gtsam::Vector&’ {aka ‘const Eigen::Matrix<double, -1, 1>&’} from expression of type ‘gtsam::KeySet’ {aka ‘gtsam::FastSet<long unsigned int>’}
  131 |   EXPECT(assert_inequal(KeySet(pS.keys()), keys));
      |                         ^~~~~~~~~~~~~~~~~
/home/tav/git/gtsam/CppUnitLite/Test.h:151:9: note: in definition of macro ‘EXPECT’
  151 | { if (!(condition)) \
      |         ^~~~~~~~~
/home/tav/git/gtsam/gtsam/base/Vector.h:163:48: note: in passing argument 1 of ‘bool gtsam::assert_inequal(const Vector&, const Vector&, double)’
  163 | GTSAM_EXPORT bool assert_inequal(const Vector& vec1, const Vector& vec2, double tol=1e-9);
      |                                  ~~~~~~~~~~~~~~^~~~
```
```
In file included from /home/tav/git/gtsam/CppUnitLite/TestHarness.h:23,
                 from /home/tav/git/gtsam/gtsam/discrete/tests/testTableFactor.cpp:19:
/home/tav/git/gtsam/gtsam/discrete/tests/testTableFactor.cpp: In member function ‘virtual void TableFactorconstructorsTest::run(TestResult&)’:
/home/tav/git/gtsam/gtsam/discrete/tests/testTableFactor.cpp:147:25: error: invalid initialization of reference of type ‘const gtsam::Vector&’ {aka ‘const Eigen::Matrix<double, -1, 1>&’} from expression of type ‘gtsam::TableFactor’
  147 |   EXPECT(assert_inequal(f5_with_wrong_keys, f5, 1e-9));
      |                         ^~~~~~~~~~~~~~~~~~
/home/tav/git/gtsam/CppUnitLite/Test.h:151:9: note: in definition of macro ‘EXPECT’
  151 | { if (!(condition)) \
      |         ^~~~~~~~~
In file included from /home/tav/git/gtsam/gtsam/inference/DotWriter.h:22,
                 from /home/tav/git/gtsam/gtsam/inference/FactorGraph.h:25,
                 from /home/tav/git/gtsam/gtsam/inference/MetisIndex.h:21,
                 from /home/tav/git/gtsam/gtsam/inference/Ordering.h:25,
                 from /home/tav/git/gtsam/gtsam/discrete/DiscreteFactor.h:25,
                 from /home/tav/git/gtsam/gtsam/discrete/DecisionTreeFactor.h:22,
                 from /home/tav/git/gtsam/gtsam/discrete/DiscreteConditional.h:21,
                 from /home/tav/git/gtsam/gtsam/discrete/tests/testTableFactor.cpp:22:
/home/tav/git/gtsam/gtsam/base/Vector.h:163:48: note: in passing argument 1 of ‘bool gtsam::assert_inequal(const Vector&, const Vector&, double)’
  163 | GTSAM_EXPORT bool assert_inequal(const Vector& vec1, const Vector& vec2, double tol=1e-9);
      |                                  ~~~~~~~~~~~~~~^~~~
```
2025-01-12 00:02:37 -08:00
Varun Agrawal 3c9b2a2351 fix examples using discrete factor graph product 2025-01-11 17:48:10 -05:00