Commit Graph

15936 Commits (773d4975e6046ee4e710cd218ede3837587f776a)

Author SHA1 Message Date
kartik arcot 544af1f03a fixed smart factor and camera set for boost optional references 2023-01-20 18:06:55 -08:00
kartik arcot 6233619095 removed some new lines 2023-01-20 18:06:55 -08:00
kartik arcot 7efc411aa1 fixed some mr comments: use auto, change comment style 2023-01-20 18:06:55 -08:00
kartik arcot 319342ab89 use auto instead 2023-01-20 18:06:55 -08:00
kartik arcot 200aa13701 return before using statement 2023-01-20 18:06:55 -08:00
kartik arcot 5575dc1f69 addressed MR comments on nonlinearfactor 2023-01-20 18:06:55 -08:00
kartik arcot 9c56c73c1a fixing some mr comments. added new lines 2023-01-20 18:06:55 -08:00
kartik arcot 984d2d104f gps factor replace bind calls 2023-01-20 18:06:55 -08:00
kartik arcot 8506877a52 some more comments 2023-01-20 18:06:55 -08:00
kartik arcot 376c910e2b timePose2 updates 2023-01-20 18:06:55 -08:00
kartik arcot bbb997f895 removed some more boost optional matrix references 2023-01-20 18:06:55 -08:00
kartik arcot 53d23b96ff added some comments and fixed some formatting 2023-01-20 18:06:55 -08:00
kartik arcot 6aed555eef removed NO_BOOST definitions and evaluateErrorInterface from expressionfactor 2023-01-20 18:06:55 -08:00
kartik arcot b7073e3224 all of gtsam compiles and tests pass with ptrs instead of optional matrix refererences 2023-01-20 18:06:55 -08:00
kartik arcot 2dc0dd5979 optional jacobian fix 2023-01-20 18:06:55 -08:00
kartik arcot 43b5ed78de both boost and ptr version compile. ptr version tests failt 2023-01-20 18:06:55 -08:00
kartik arcot ce02873140 everything compiles but tests fail in no boost mode 2023-01-20 18:06:55 -08:00
kartik arcot a070cf3130 added using keyword to expose the evaluateError overloads to the derived classes 2023-01-20 18:06:55 -08:00
kartik arcot f7c683a794 some changes that get testPriorFactor compiling 2023-01-20 18:06:55 -08:00
kartik arcot 841dc6005a changed signatures to use OptionalMatrix keyword 2023-01-20 18:06:55 -08:00
kartik arcot c1fe89cc0d type checing in evaluateError works 2023-01-20 18:06:55 -08:00
kartik arcot f2efe97f41 type checking works now 2023-01-20 18:06:55 -08:00
kartik arcot 1ee54c6533 works now 2023-01-20 18:06:55 -08:00
kartik arcot 4eb73db1c1 breaks 2023-01-20 18:06:55 -08:00
kartik arcot fcf339a31a changed interface for both unwhitenedError and evaluateError 2023-01-20 18:06:55 -08:00
kartik arcot 97269afe4b compile definitions for conditionally compiling 2023-01-20 18:06:55 -08:00
Frank Dellaert 22e9e80f43
Merge pull request #1398 from borglab/feature/deprecate_filter2 2023-01-20 15:02:58 -08:00
Frank Dellaert 603d665342 Deprecate `filter` in favor of `extract`, which copies to std::map without boost. 2023-01-20 12:48:57 -08:00
Frank Dellaert 5029e3ddc6
Merge pull request #1395 from borglab/feature/switch 2023-01-20 06:42:03 -08:00
Frank Dellaert 469e57122f commented out problematic python tests 2023-01-19 22:34:12 -08:00
Frank Dellaert 0cb0733e33 Added c++17 flags to build functions 2023-01-19 22:33:32 -08:00
Frank Dellaert a4367e1578 Updated docs to reflect switch. 2023-01-19 09:45:32 -08:00
Frank Dellaert b42db6764d Switch to version 4.3a0 and to c++17. 2023-01-19 09:45:00 -08:00
Varun Agrawal aebc3f94d4
Merge pull request #1391 from borglab/hybrid/pruning_test 2023-01-18 15:46:05 -05:00
Varun Agrawal 3460147df8
Merge pull request #1390 from borglab/hybrid/simplify-2 2023-01-18 12:08:55 -05:00
Varun Agrawal 7849cf4c41 add a TODO about reorder_relinearize 2023-01-17 15:57:18 -05:00
Frank Dellaert b5d574552c Switch pruning test to probabilities. 2023-01-17 12:56:53 -08:00
Varun Agrawal bfa4d6f3e6 update function names and docs to be correct 2023-01-17 15:56:37 -05:00
Frank Dellaert 0571af997c
Merge pull request #1388 from borglab/hybrid/simplify 2023-01-17 12:37:37 -08:00
Frank Dellaert f714c4ac82 Merge branch 'develop' into hybrid/simplify 2023-01-17 07:50:45 -08:00
Frank Dellaert e444962aad Added correction with the normalization constant in the second elimination path. 2023-01-17 07:47:56 -08:00
Frank Dellaert c3ca31f2f3 Added partial elimination test 2023-01-17 07:47:10 -08:00
Varun Agrawal 7cd360039f
Merge pull request #1387 from borglab/discreteKeys-vector
Some Hybrid Improvements
2023-01-17 04:00:41 -05:00
Frank Dellaert 892759e5d6 Add math related to hybrid classes 2023-01-16 20:00:07 -08:00
Frank Dellaert b494a61150 Removed obsolete normalizationConstants method 2023-01-16 19:59:42 -08:00
Frank Dellaert 4283925e60 Ratio test succeeds on fg, but not on posterior yet, 2023-01-16 19:21:10 -08:00
Frank Dellaert f4859f0229 Fix logProbability tests 2023-01-16 18:56:58 -08:00
Frank Dellaert 32d69a3bd7 Trap if conditional==null. 2023-01-16 18:56:40 -08:00
Frank Dellaert 519b2bb515 Added comment 2023-01-16 18:56:25 -08:00
Frank Dellaert 9af7236980 Added DEBUG_MARGINALS flag 2023-01-16 18:36:28 -08:00