7742f025fc
Clean up MSVC flags to allow use of MSVC variables instead
...
Generator expressions were used to prevent the addition of /MD and /Zi if the CMake version is new enough to have specific MSVC variables for controlling those flags
2025-01-07 08:45:47 -05:00
0435efdebc
Remove PREFIX ""
2025-01-07 08:27:19 -05:00
f638035e10
Remove redundant MSVC optimization flag in GKLib
2025-01-07 07:53:33 -05:00
3d23152a75
Clean up version finding in HandleEigen
2025-01-07 07:53:33 -05:00
885959a36b
Use new CMake policies up to 3.29
...
This silences most warnings about overriding /W3 with /w
2025-01-07 07:53:33 -05:00
e08064d9e7
Use CMAKE_POSITION_INDEPENDENT_CODE instead of -fPIC
2025-01-07 07:53:33 -05:00
6bb70df05b
Use newer binary output directory variables and don't specify output directory on each target
2025-01-07 07:53:33 -05:00
82d0ebc8fe
Merge pull request #1919 from borglab/discrete-elimination-refactor
2025-01-06 20:33:59 -05:00
c754f9bfdc
add comments
2025-01-06 18:47:44 -05:00
f8dedb5035
use DiscreteFactor for DiscreteConditional constructor
2025-01-06 18:37:40 -05:00
f932945652
check pointer casts
2025-01-06 18:30:34 -05:00
47074bd0c2
Merge pull request #1963 from borglab/discrete-multiply
...
DiscreteFactor multiply method
2025-01-06 15:21:52 -05:00
f043ac43a7
address review comments
2025-01-06 14:08:08 -05:00
ab90e0b0f3
move include to .cpp
2025-01-06 13:44:55 -05:00
ff5371fd4a
move sum, max and nrValues to Constraint class as well
2025-01-06 13:38:45 -05:00
7561da4df2
move operator/ to Constraint.h
2025-01-06 13:35:45 -05:00
ab2fe3707c
Merge branch 'discrete-multiply' into discrete-elimination-refactor
2025-01-06 13:32:52 -05:00
43f755d9d8
move multiply to Constraint.h
2025-01-06 11:17:03 -05:00
ffd04fd454
Merge pull request #1962 from borglab/fix-dtf-division
...
Fix DecisionTreeFactor division
2025-01-06 10:26:20 -05:00
2434e248e9
undo print change in DiscreteLookupTable
2025-01-05 20:54:56 -05:00
2f8c8ddb75
update tests
2025-01-05 20:50:40 -05:00
e9822a70d2
update DiscreteFactorGraph to use DiscreteFactor::shared_ptr for elimination
2025-01-05 20:50:24 -05:00
fb1d52a18e
fix constructor
2025-01-05 20:49:24 -05:00
4ebca71146
divide operator for DiscreteFactor::shared_ptr
2025-01-05 20:44:10 -05:00
b5128b2c9f
use DecisionTreeFactor version of sum and max where not available
2025-01-05 19:40:37 -05:00
5e9c1300db
Merge branch 'discrete-multiply' into discrete-elimination-refactor
2025-01-05 18:22:01 -05:00
b83aadb204
remove accidental type change
2025-01-05 15:37:37 -05:00
713c49c915
more robust product
2025-01-05 15:20:09 -05:00
bc63cc8cb8
use double dispatch for else case
2025-01-05 15:19:57 -05:00
8390ffa2cb
revert previous commit
2025-01-05 15:19:16 -05:00
a7fc6e3763
convert everything to DecisionTreeFactor so we can use override operator* method
2025-01-05 15:08:58 -05:00
13bafb0a48
Revert "simplify to remove DiscreteProduct static function"
...
This reverts commit 453059bd61
2025-01-05 14:28:57 -05:00
a02baec011
naive implementation of multiply for unstable
2025-01-05 14:23:34 -05:00
453059bd61
simplify to remove DiscreteProduct static function
2025-01-05 14:03:08 -05:00
260d448887
use new multiply method
2025-01-05 13:57:07 -05:00
700ad2bae3
remove override from TableFactor definition
2025-01-05 13:56:54 -05:00
75a4e98715
remove override from definition
2025-01-05 13:49:52 -05:00
5d865a8cc7
multiply method for DiscreteFactor
2025-01-05 13:49:47 -05:00
2f09e860e1
remove override from definition
2025-01-05 13:41:58 -05:00
268290dbf2
multiply method for DiscreteFactor
2025-01-05 13:41:51 -05:00
e309bf370b
improve operator/ documentation and also showcase understanding in test
2025-01-05 11:54:09 -05:00
5fa04d7622
small improvements
2025-01-05 09:08:57 -05:00
d3901be1c1
Merge branch 'develop' into discrete-elimination-refactor
2025-01-05 08:51:11 -05:00
a142556c52
move create to the top
2025-01-05 08:45:11 -05:00
6b6283c151
fix factor construction
2025-01-03 15:21:49 -05:00
e9e52ad21f
Merge pull request #1961 from borglab/serialize-tablefactor
2025-01-03 14:42:04 -05:00
be7be376a9
Revert "additional Signature based constructor for DecisionTreeFactor"
...
This reverts commit 834288f974
2025-01-03 13:42:56 -05:00
ffe14d39aa
Revert "update tests"
...
This reverts commit e6567457b5
2025-01-03 13:42:48 -05:00
3718cb19ed
use string based constructor
2025-01-03 13:35:13 -05:00
c6c451bee1
compute correct subset of keys for division
2025-01-03 13:28:40 -05:00
Gold856
Varun Agrawal