Commit Graph

18189 Commits (a9da253d001e533f16988ec077ed54f313de7c81)

Author SHA1 Message Date
JokerJohn a9da253d00 add IncrementalFixedLagSmootherExample 2025-01-18 17:38:34 +08:00
JokerJohn 630ee11885 remove example 2025-01-17 23:57:58 +08:00
JokerJohn 6795bf5709 add a new line at the end of file 2025-01-15 13:33:53 +08:00
JokerJohn fbd45776a6 add a new line at the end of file 2025-01-15 13:21:32 +08:00
JokerJohn 3743b562c1 Move the example to the appropriate folder, and modify the code for reading files and adding factors. 2025-01-15 13:17:21 +08:00
JokerJohn c2355fd95a add IncrementalFixedLagExample to show the issue #1452 2025-01-14 19:47:30 +08:00
JokerJohn a4f88d2d25 add IncrementalFixedLagExample to showcase how setting addresses the issue #1452 2025-01-14 19:44:16 +08:00
Frank Dellaert 088332978b Check issue 1452 2025-01-13 13:02:39 -05:00
Tyler Veness 4cbf673540 Add missing test include for assert_inequal()
Here's the compilation errors without it.
```
In file included from /home/tav/git/gtsam/CppUnitLite/TestHarness.h:23,
                 from /home/tav/git/gtsam/gtsam/discrete/tests/testDecisionTreeFactor.cpp:20:
/home/tav/git/gtsam/gtsam/discrete/tests/testDecisionTreeFactor.cpp: In member function ‘virtual void DecisionTreeFactorDivideTest::run(TestResult&)’:
/home/tav/git/gtsam/gtsam/discrete/tests/testDecisionTreeFactor.cpp:123:25: error: invalid initialization of reference of type ‘const gtsam::Vector&’ {aka ‘const Eigen::Matrix<double, -1, 1>&’} from expression of type ‘gtsam::DecisionTreeFactor’
  123 |   EXPECT(assert_inequal(pS, s));
      |                         ^~
/home/tav/git/gtsam/CppUnitLite/Test.h:151:9: note: in definition of macro ‘EXPECT’
  151 | { if (!(condition)) \
      |         ^~~~~~~~~
In file included from /home/tav/git/gtsam/gtsam/inference/DotWriter.h:22,
                 from /home/tav/git/gtsam/gtsam/inference/FactorGraph.h:25,
                 from /home/tav/git/gtsam/gtsam/inference/MetisIndex.h:21,
                 from /home/tav/git/gtsam/gtsam/inference/Ordering.h:25,
                 from /home/tav/git/gtsam/gtsam/discrete/DiscreteFactor.h:25,
                 from /home/tav/git/gtsam/gtsam/discrete/DecisionTreeFactor.h:22,
                 from /home/tav/git/gtsam/gtsam/discrete/tests/testDecisionTreeFactor.cpp:23:
/home/tav/git/gtsam/gtsam/base/Vector.h:163:48: note: in passing argument 1 of ‘bool gtsam::assert_inequal(const Vector&, const Vector&, double)’
  163 | GTSAM_EXPORT bool assert_inequal(const Vector& vec1, const Vector& vec2, double tol=1e-9);
      |                                  ~~~~~~~~~~~~~~^~~~
/home/tav/git/gtsam/gtsam/discrete/tests/testDecisionTreeFactor.cpp:131:25: error: invalid initialization of reference of type ‘const gtsam::Vector&’ {aka ‘const Eigen::Matrix<double, -1, 1>&’} from expression of type ‘gtsam::KeySet’ {aka ‘gtsam::FastSet<long unsigned int>’}
  131 |   EXPECT(assert_inequal(KeySet(pS.keys()), keys));
      |                         ^~~~~~~~~~~~~~~~~
/home/tav/git/gtsam/CppUnitLite/Test.h:151:9: note: in definition of macro ‘EXPECT’
  151 | { if (!(condition)) \
      |         ^~~~~~~~~
/home/tav/git/gtsam/gtsam/base/Vector.h:163:48: note: in passing argument 1 of ‘bool gtsam::assert_inequal(const Vector&, const Vector&, double)’
  163 | GTSAM_EXPORT bool assert_inequal(const Vector& vec1, const Vector& vec2, double tol=1e-9);
      |                                  ~~~~~~~~~~~~~~^~~~
```
```
In file included from /home/tav/git/gtsam/CppUnitLite/TestHarness.h:23,
                 from /home/tav/git/gtsam/gtsam/discrete/tests/testTableFactor.cpp:19:
/home/tav/git/gtsam/gtsam/discrete/tests/testTableFactor.cpp: In member function ‘virtual void TableFactorconstructorsTest::run(TestResult&)’:
/home/tav/git/gtsam/gtsam/discrete/tests/testTableFactor.cpp:147:25: error: invalid initialization of reference of type ‘const gtsam::Vector&’ {aka ‘const Eigen::Matrix<double, -1, 1>&’} from expression of type ‘gtsam::TableFactor’
  147 |   EXPECT(assert_inequal(f5_with_wrong_keys, f5, 1e-9));
      |                         ^~~~~~~~~~~~~~~~~~
/home/tav/git/gtsam/CppUnitLite/Test.h:151:9: note: in definition of macro ‘EXPECT’
  151 | { if (!(condition)) \
      |         ^~~~~~~~~
In file included from /home/tav/git/gtsam/gtsam/inference/DotWriter.h:22,
                 from /home/tav/git/gtsam/gtsam/inference/FactorGraph.h:25,
                 from /home/tav/git/gtsam/gtsam/inference/MetisIndex.h:21,
                 from /home/tav/git/gtsam/gtsam/inference/Ordering.h:25,
                 from /home/tav/git/gtsam/gtsam/discrete/DiscreteFactor.h:25,
                 from /home/tav/git/gtsam/gtsam/discrete/DecisionTreeFactor.h:22,
                 from /home/tav/git/gtsam/gtsam/discrete/DiscreteConditional.h:21,
                 from /home/tav/git/gtsam/gtsam/discrete/tests/testTableFactor.cpp:22:
/home/tav/git/gtsam/gtsam/base/Vector.h:163:48: note: in passing argument 1 of ‘bool gtsam::assert_inequal(const Vector&, const Vector&, double)’
  163 | GTSAM_EXPORT bool assert_inequal(const Vector& vec1, const Vector& vec2, double tol=1e-9);
      |                                  ~~~~~~~~~~~~~~^~~~
```
2025-01-12 00:02:37 -08:00
Frank Dellaert 49c67d3819
Merge pull request #1969 from calcmogul/remove-operator-from-matrix-and-subgraph-preconditioner
Remove operator^ from Matrix and SubgraphPreconditioner
2025-01-11 14:51:20 -05:00
Matt Morley 95a82bf3e0 Add cassert include to Chebyshev2.cpp 2025-01-10 22:32:09 -08:00
Tyler Veness 79960095b9
Fix invalid use of operator^ in matrix test 2025-01-10 15:36:30 -08:00
Tyler Veness 5a44974785
Reverted interface changes that are unnecessary to make the code compile 2025-01-10 15:36:09 -08:00
Frank Dellaert 60365b7630
Merge pull request #1871 from valgur/feature/spectra-1.0.1
Update Spectra to v1.1.0 to fix C++20 compatibility issues on GCC/Clang
2025-01-10 17:43:11 -05:00
Martin Valgur 8583185153 Fix wrapping of computed angles in test_backwards_compatibility.py 2025-01-10 22:51:37 +02:00
Martin Valgur b2a351c8de ShonanAveraging.cpp: pass explicit template args for GCC 7 2025-01-10 22:51:37 +02:00
Martin Valgur 6a42d8a1b2 Fix wrapping of computed angles in test_constructorBetweenFactorPose2s 2025-01-10 22:51:37 +02:00
Martin Valgur 274acb9e82 Update ShonanAveraging.cpp to use Spectra v1.1.0 2025-01-10 22:51:37 +02:00
Martin Valgur c99a8e1c1d Upgrade Spectra to v1.1.0 2025-01-10 22:51:18 +02:00
Varun Agrawal 0c44f9f451
Merge pull request #1943 from borglab/improvements 2025-01-10 12:51:48 -05:00
Varun Agrawal 22bdd2a029
Merge pull request #1966 from borglab/cross-platform-tests 2025-01-10 12:50:50 -05:00
Tyler Veness a0ae31f0d4
Remove operator^ from Matrix and SubgraphPreconditioner
Eigen recently added an operator^ for coefficient-wise bitwise xor,
which conflicts with gtsam's operator^. Since gtsam's operator^ isn't
xor, I opted to remove it.

Fixes #1951.
2025-01-10 08:36:39 -08:00
Varun Agrawal 62b0ed6678 change from ifdef to if 2025-01-10 11:11:03 -05:00
Varun Agrawal fbe4ad1dc9 common Apple and Windows assertions 2025-01-10 10:29:58 -05:00
Varun Agrawal 9910bb6362 Revert "Helper macro for cout printing"
This reverts commit 28065b737b.
2025-01-10 10:28:36 -05:00
Varun Agrawal 9142200a6e Revert "suppress newer GCC warnings in Eigen"
This reverts commit b7e60c4043.
2025-01-10 10:27:34 -05:00
Frank Dellaert 89fbe4bd2e
Merge pull request #1959 from mcm001/wall-wpedantic
Enable more warnings and remove unused variables
2025-01-09 20:41:45 -05:00
Varun Agrawal 438bead4fd small cleanup 2025-01-09 10:45:23 -05:00
Varun Agrawal 556ed9bfcc separate Windows regression for Shonan Averaging 2025-01-09 09:31:12 -05:00
Varun Agrawal cb2be68d05 fix test with better precision 2025-01-09 09:28:06 -05:00
Matt Morley fd2f39e271 Add misc explicit operators 2025-01-09 07:21:21 -07:00
Varun Agrawal d4726cfd1f fix some regressions 2025-01-09 08:57:45 -05:00
Matt Morley 3ed3c3b2e8 Bump CI GCC 11->12 2025-01-08 21:59:28 -07:00
Matt Morley f5774f0443 Enable extra warnings 2025-01-08 21:59:28 -07:00
Varun Agrawal 41280d4d1e update tests that failed and add shonan averaging test 2025-01-08 18:33:46 -05:00
Varun Agrawal d9106fd190 add numeric header for std::accumulate 2025-01-08 13:32:34 -05:00
Varun Agrawal 212c79289f support Windows 2025-01-08 12:57:30 -05:00
Varun Agrawal c00f6631ad other tests 2025-01-08 12:52:44 -05:00
Varun Agrawal 72da68ebf3 platform specific #ifs 2025-01-08 12:47:00 -05:00
Varun Agrawal 169523ecc6
Merge pull request #1948 from borglab/hybrid-timing 2025-01-08 12:45:26 -05:00
Varun Agrawal 8cf2123b5c
Merge pull request #1953 from borglab/discrete-table-conditional
TableFactor and TableDistribution
2025-01-08 11:25:27 -05:00
Frank Dellaert 8315ea75d8
Merge pull request #1965 from MagnusAagaard/develop
Fix BilinearAngleTranslationFactor part of TranslationFactor
2025-01-08 08:58:37 -05:00
Varun Agrawal 29d0db2cc4
Merge pull request #1964 from Gold856/cmake
Clean up CMake build
2025-01-08 06:40:08 -05:00
MagnusAagaard 3760b02d8e
Use std::abs to avoid implicit conversion of double input to int 2025-01-08 10:28:28 +01:00
Varun Agrawal 3ecc232c0a fix tests 2025-01-07 15:21:24 -05:00
Varun Agrawal 4fc2387a63 fix relinearization in HybridNonlinearISAM 2025-01-07 15:15:16 -05:00
Varun Agrawal 9c2ecc3c15 simplify multiplication 2025-01-07 14:55:30 -05:00
Varun Agrawal 9dfdf552e1 add hack to multiply DiscreteConditional with TableDistribution 2025-01-07 14:54:49 -05:00
Varun Agrawal 3629c33ecd override sample in TableDistribution 2025-01-07 14:53:28 -05:00
Varun Agrawal b81ab86b69 make ADT with nullptr in TableDistribution 2025-01-07 14:52:48 -05:00