Commit Graph

15787 Commits (892759e5d6b361b3531e53592d17e48a73929a5c)

Author SHA1 Message Date
Frank Dellaert 892759e5d6 Add math related to hybrid classes 2023-01-16 20:00:07 -08:00
Frank Dellaert b494a61150 Removed obsolete normalizationConstants method 2023-01-16 19:59:42 -08:00
Frank Dellaert 4283925e60 Ratio test succeeds on fg, but not on posterior yet, 2023-01-16 19:21:10 -08:00
Frank Dellaert f4859f0229 Fix logProbability tests 2023-01-16 18:56:58 -08:00
Frank Dellaert 32d69a3bd7 Trap if conditional==null. 2023-01-16 18:56:40 -08:00
Frank Dellaert 519b2bb515 Added comment 2023-01-16 18:56:25 -08:00
Frank Dellaert 9af7236980 Added DEBUG_MARGINALS flag 2023-01-16 18:36:28 -08:00
Frank Dellaert e31884c9a1 Eradicated GraphAndConstant 2023-01-16 18:28:12 -08:00
Frank Dellaert 8357fc7e02 Fix python tests (and expose HybridBayesNet.error) 2023-01-16 18:04:22 -08:00
Frank Dellaert a5951d8d34 Fixed test to work with "hidden constant" scheme 2023-01-16 18:03:51 -08:00
Frank Dellaert 202a5a3264 Fixed toFactorGraph and added test to verify 2023-01-16 17:38:01 -08:00
Frank Dellaert 3a446d7008 Explicitly implement logNormalizationConstant 2023-01-16 17:32:54 -08:00
Frank Dellaert 207c9b7236 Implemented the "hidden constant" scheme. 2023-01-16 16:45:30 -08:00
Frank Dellaert 7a41180e82 Refactored tests and removed incorrect (R not upper-triangular) test. 2023-01-16 15:34:00 -08:00
Frank Dellaert 57e59d1237 Compute log-normalization constant as the max of the individual normalization constants. 2023-01-16 15:33:14 -08:00
Frank Dellaert 191e6140b3 Fix print 2023-01-16 15:32:43 -08:00
Frank Dellaert 5b0408c7bb Check for error>0 and proper normalization constant 2023-01-16 15:32:34 -08:00
Frank Dellaert c22b2cad3b Improved docs 2023-01-16 10:31:09 -08:00
Frank Dellaert 96e3eb7d8b Some test refactoring 2023-01-16 10:30:47 -08:00
Frank Dellaert 070cdb7018 insert_or_assign 2023-01-16 10:30:47 -08:00
Frank Dellaert dfef2c202f Simplify elimination 2023-01-16 10:30:47 -08:00
Frank Dellaert 681c75cea4 Expose toFactorGraph to wrapper 2023-01-16 10:30:47 -08:00
Frank Dellaert 906330f0e4 Add discrete contribution to logProbability 2023-01-16 10:30:47 -08:00
Frank Dellaert 03ad393e12 Removed FactorAndConstant, no longer needed 2023-01-16 10:30:47 -08:00
Frank Dellaert 1dcc6ddde9 All tests still work with zero constant! 2023-01-16 10:30:47 -08:00
Frank Dellaert 34a9aef6f3 normalizationConstants returns all constants as a DecisionTreeFactor 2023-01-16 10:30:47 -08:00
Frank Dellaert 618ac28f2c
Merge pull request #1386 from borglab/hybrid/more_tests
Test and fix all conditionals
2023-01-15 08:15:12 -08:00
Frank Dellaert 51c46410dc Make sure all conditional methods can be called in wrappers and satisfy invariants there, as well. 2023-01-14 13:24:54 -08:00
Frank Dellaert bead5ce4da Test all HybridConditionals in all possible calling conventions. 2023-01-14 12:57:53 -08:00
Frank Dellaert ce8bf7ac48 Expose all needed versions of evaluate, operator(), error 2023-01-14 12:57:12 -08:00
Frank Dellaert c9fcfe3299 Resolve GaussianMixture error crisis 2023-01-14 12:56:38 -08:00
Frank Dellaert ab439bfbb0 Checking mixture invariants, WIP 2023-01-14 10:23:21 -08:00
Frank Dellaert 693d18233a Adapt to continuous densities 2023-01-14 10:23:00 -08:00
Frank Dellaert 0a6334ef1f check invariants 2023-01-14 10:22:41 -08:00
Frank Dellaert cd2d37e724 Made CheckInvariants a static method in Conditional.* 2023-01-13 14:55:14 -08:00
Frank Dellaert b99d464049 Consistency test in testGaussianConditional 2023-01-13 12:29:11 -08:00
Frank Dellaert ebb5ae6f18 Expose correct error versions 2023-01-13 12:28:39 -08:00
Frank Dellaert a4aebb548a Expose correct error versions 2023-01-13 12:28:16 -08:00
Frank Dellaert 7ea8bd0fba Add check 2023-01-13 11:58:17 -08:00
Frank Dellaert 8c752049de move normalization constant to base class 2023-01-13 11:57:20 -08:00
Varun Agrawal 5c59862238
Merge pull request #1381 from acowley/BatchFixedLagSmoother-verbosity 2023-01-12 10:48:26 -05:00
Frank Dellaert a34c463e2b
Merge pull request #1380 from borglab/feature/uniform_error 2023-01-12 07:48:01 -08:00
Frank Dellaert f4c3131ee2 Return a set of DiscreteKey, Fixes issue #1384 2023-01-11 23:50:17 -08:00
Frank Dellaert 28f440a623 Resolved review comments. 2023-01-11 18:11:28 -08:00
Frank Dellaert 4340b46828 Don't use deprecated method. 2023-01-10 23:56:49 -08:00
Frank Dellaert 87ff4af32d Wrapper and tests for logProbability 2023-01-10 23:13:40 -08:00
Frank Dellaert eb37d080d4 Added missing methods 2023-01-10 23:13:27 -08:00
Frank Dellaert e9485d1d76
Merge pull request #1379 from kartikarcot/kartik/list-of 2023-01-10 21:58:54 -08:00
Frank Dellaert 426a49dc72 Endowed hybrid with logProbability 2023-01-10 21:55:18 -08:00
Frank Dellaert 11ef99b3f0 discrete now has all logProbability and evaluate versions needed. 2023-01-10 21:54:58 -08:00