Commit Graph

135 Commits (6b834db828239ef0a66e27f21ec3a3f9f6af80e1)

Author SHA1 Message Date
Gerry Chen e5ec007185
readability 2022-12-22 17:55:25 -05:00
Gerry Chen 885eed33d1
replace all NoiseModelFactor1, 2, ... with NoiseModelFactorN 2022-12-22 17:25:48 -05:00
Gerry Chen 4b93970b34
Change backwards-compatibility defs to utilize new style 2022-12-22 14:29:15 -05:00
Gerry Chen d16d26394e
better docstrings w/ usage examples 2022-12-22 14:26:16 -05:00
Gerry Chen 040eb63949
make SFINAE templates more readable 2022-12-22 13:18:15 -05:00
Gerry Chen e8ddbbebff
Check type of CONTAINER constructor tparam
This is a byproduct of the overload resolution problem when N=1, then it can be hard to differentiate between:
NoiseModelFactorN(noise, key)
NoiseModelFactorN(noise, {key})
2022-12-19 20:14:12 -05:00
Gerry Chen b24511fb18
address review comments 2022-12-19 18:49:20 -05:00
Gerry Chen 0ebc6e881d
Change `X<N>` to `ValueType<N>` and `VALUES` -> `ValueTypes` 2022-12-19 18:06:34 -05:00
Gerry Chen 322e5551f7
address review comments 2022-11-16 14:56:18 -05:00
Gerry Chen 83276853b5
remove debug statements 2022-07-19 21:41:45 -04:00
Gerry Chen ea6e32de82
bugfix on serialization 2022-07-19 21:34:58 -04:00
Gerry Chen 71767a4c2b
serialization debugging (from stash) 2022-07-19 14:57:15 -04:00
Gerry Chen 8ae8c7ac52 Merge branch 'develop' into feature/NoiseModelFactorN
#1102 correctly removed "GTSAM_EXPORT" from NoiseModelFactorX
2022-04-21 15:52:35 -04:00
Mike Sheffler ac01db4f4d Per https://github.com/borglab/gtsam/blob/develop/Using-GTSAM-EXPORT.md , classes with no methods defined in a .cpp file shouldn't have the GTSAM_EXPORT or GTSAM_UNSTABLE_EXPORT modifier. This was causing problems with the building of gtsam_unstable on MSVC / Windows. 2022-02-15 00:19:54 -08:00
Gerry Chen 82e0d20519
move boost::index_sequence stuff to utilities file 2022-01-30 17:26:54 -05:00
Gerry Chen bb33be58b3
revert some template stuff with inheritance for readability
NoiseModelFactor123456 are now minimal classes that inherit from NoiseModelFactorN
2022-01-30 17:25:20 -05:00
Gerry Chen 3addc8dfff
Merge branch 'develop' into feature/NoiseModelFactorN 2022-01-30 16:26:30 -05:00
Varun Agrawal b47f46a6f5
Windows Fixes (#904) 2021-12-09 09:37:21 -05:00
Gerry Chen 40e585bb11
review comments 2021-12-09 02:26:57 -05:00
Gerry Chen 84e873ebb0
fix Windows CI issue: VALUE happens to have the same name in PriorFactor 2021-12-09 00:50:36 -05:00
Gerry Chen 018213ec85
switch `using NoiseModelFactorX = ...` to `#define ...`.
Reasoning is given as comments.
2021-12-08 19:09:35 -05:00
Gerry Chen 5004c47944
revert typedef X1, X2, ... to old version, and clean up a little 2021-12-08 18:56:09 -05:00
Gerry Chen 89b4340530
alternate option for typedef-ing X1, X2, ... 2021-12-08 18:29:52 -05:00
Gerry Chen 280acde2fc
can't get "using NoiseModelFactorX = NoiseModelFactorN" to work 2021-12-03 07:43:42 -05:00
Gerry Chen ddcca4cdae
switch template bool specialization order 2021-12-03 06:46:26 -05:00
Gerry Chen ba3cc85701
avoid inheritance by conditionally defining backwards compatibility types/funcs in NoiseModelFactorN 2021-12-03 06:17:14 -05:00
Gerry Chen ea7d769476
documentation 2021-12-03 05:49:36 -05:00
Gerry Chen ed07edbfe4
converted all NoiseModelFactorX to inherit from NoiseModelFactorN 2021-12-03 03:00:47 -05:00
Gerry Chen bee4eeefdd
NoiseModelFactor4 implemented as derived class of NoiseModelFactorN 2021-12-03 02:25:11 -05:00
Gerry Chen 2aecaf3258
optional jacobian overloads backwards compatibility 2021-12-03 00:39:10 -05:00
Gerry Chen d9c8ce2721
alternate make_index_sequence impl if no boost::mp11 2021-12-02 23:26:34 -05:00
Gerry Chen e037fa1bdb
c++11 doesn't support std::size so use obj.size() instead 2021-12-01 16:20:51 -05:00
Gerry Chen 81f1d93158
NoiseModelFactorN - fixed-number of variables >6 2021-12-01 16:04:49 -05:00
Fan Jiang b1e91671fd
Merge pull request #767 from borglab/feature/custom_factor
Custom Factors in Python
2021-06-07 14:49:24 -04:00
Fan Jiang 880d5b57af Fixed Python factor for TBB 2021-06-05 00:18:45 -04:00
Varun Agrawal 457d548015 override the rekey methods so as to update the properties as well 2021-05-30 11:22:58 -04:00
Varun Agrawal 6c3aca8cac remove virtual from overridden methods, add virtual destructors to appease compiler 2021-04-30 12:58:52 -04:00
Varun Agrawal 4d6eef2c2f override print methods and update wrapper 2021-04-29 19:43:27 -04:00
Toni 7f80c906c4 Fix override warnings: modernize-use-override 2021-01-28 23:02:13 -05:00
lcarlone 5db6894b66 finally I have a way to properly change the noise model! 2020-11-27 18:25:38 -05:00
Frank Dellaert 269dea3a24
Merge pull request #422 from borglab/dellaert/issue420
Dellaert/issue420
2020-08-02 16:16:01 -04:00
Frank Dellaert e22c24eff5 Removed superfluous size, added doxygen partitions 2020-08-01 15:43:21 -04:00
Frank Dellaert 09bb25498f
Merge branch 'develop' into dellaert/issue420 2020-07-31 16:45:03 -04:00
Jose Luis Blanco Claraco 0198c648e3
Fix all new gcc warnings/errors: make explicit virtual/override methods.
Rules are:
- use "virtual" in base classes only.
- use "override" in all derived classes.
2020-07-26 11:20:42 +02:00
Frank dellaert 30703ccb6a Removed all deprecated code w Stephanie... 2020-07-22 17:32:25 -04:00
Francesco Papi 92008c9319 Add functionalities to get introspection of the loss function weights and unweighted residuals for the NoiseModelFactor class 2019-11-12 15:39:56 -08:00
Frank Dellaert 23f3f95ed2 deprecated get_noiseModel 2019-05-16 14:40:55 -04:00
Duy-Nguyen Ta 1cdc228d6a remove trailing spaces 2019-02-11 10:58:34 -05:00
Frank Dellaert 2aa43e11bd Use KeyVector everywhere to avoid conversions 2018-11-08 10:10:32 -05:00
ivan 23a1382bb2 [QP/LP] LP Added Zeros Error Fixed.
[QP] Now Checks for syntactic Equality by comparing each factor imported .
[QP] Now Checks for semantic Equality by ensuring each imported QP gives the same solution.
2016-05-02 19:54:58 -04:00