Commit Graph

8382 Commits (4675fd67d04d594a2f2d73084096d94ed1360a07)

Author SHA1 Message Date
Frank Dellaert 4675fd67d0 removed deprecated code 2023-01-20 22:50:05 -08:00
kartik arcot dc25a78f76 comment is simpler 2023-01-20 18:32:17 -08:00
kartik arcot 6c08c38478 minor reformatting 2023-01-20 18:06:55 -08:00
kartik arcot 92874f76fa rewrite evaluateError to use SFINAE instead of conditional compilation 2023-01-20 18:06:55 -08:00
kartik arcot 80fdd69a14 VariableIndex 2023-01-20 18:06:55 -08:00
kartik arcot d05d2af6b5 linear algorithms 2023-01-20 18:06:55 -08:00
kartik arcot 0d38db3941 iterative solver 2023-01-20 18:06:55 -08:00
kartik arcot 544af1f03a fixed smart factor and camera set for boost optional references 2023-01-20 18:06:55 -08:00
kartik arcot 6233619095 removed some new lines 2023-01-20 18:06:55 -08:00
kartik arcot 7efc411aa1 fixed some mr comments: use auto, change comment style 2023-01-20 18:06:55 -08:00
kartik arcot 319342ab89 use auto instead 2023-01-20 18:06:55 -08:00
kartik arcot 200aa13701 return before using statement 2023-01-20 18:06:55 -08:00
kartik arcot 5575dc1f69 addressed MR comments on nonlinearfactor 2023-01-20 18:06:55 -08:00
kartik arcot 9c56c73c1a fixing some mr comments. added new lines 2023-01-20 18:06:55 -08:00
kartik arcot 984d2d104f gps factor replace bind calls 2023-01-20 18:06:55 -08:00
kartik arcot 8506877a52 some more comments 2023-01-20 18:06:55 -08:00
kartik arcot bbb997f895 removed some more boost optional matrix references 2023-01-20 18:06:55 -08:00
kartik arcot 53d23b96ff added some comments and fixed some formatting 2023-01-20 18:06:55 -08:00
kartik arcot 6aed555eef removed NO_BOOST definitions and evaluateErrorInterface from expressionfactor 2023-01-20 18:06:55 -08:00
kartik arcot b7073e3224 all of gtsam compiles and tests pass with ptrs instead of optional matrix refererences 2023-01-20 18:06:55 -08:00
kartik arcot 2dc0dd5979 optional jacobian fix 2023-01-20 18:06:55 -08:00
kartik arcot ce02873140 everything compiles but tests fail in no boost mode 2023-01-20 18:06:55 -08:00
kartik arcot a070cf3130 added using keyword to expose the evaluateError overloads to the derived classes 2023-01-20 18:06:55 -08:00
kartik arcot f7c683a794 some changes that get testPriorFactor compiling 2023-01-20 18:06:55 -08:00
kartik arcot 841dc6005a changed signatures to use OptionalMatrix keyword 2023-01-20 18:06:55 -08:00
kartik arcot c1fe89cc0d type checing in evaluateError works 2023-01-20 18:06:55 -08:00
kartik arcot f2efe97f41 type checking works now 2023-01-20 18:06:55 -08:00
kartik arcot 1ee54c6533 works now 2023-01-20 18:06:55 -08:00
kartik arcot 4eb73db1c1 breaks 2023-01-20 18:06:55 -08:00
kartik arcot fcf339a31a changed interface for both unwhitenedError and evaluateError 2023-01-20 18:06:55 -08:00
Frank Dellaert 603d665342 Deprecate `filter` in favor of `extract`, which copies to std::map without boost. 2023-01-20 12:48:57 -08:00
Varun Agrawal aebc3f94d4
Merge pull request #1391 from borglab/hybrid/pruning_test 2023-01-18 15:46:05 -05:00
Varun Agrawal 7849cf4c41 add a TODO about reorder_relinearize 2023-01-17 15:57:18 -05:00
Frank Dellaert b5d574552c Switch pruning test to probabilities. 2023-01-17 12:56:53 -08:00
Varun Agrawal bfa4d6f3e6 update function names and docs to be correct 2023-01-17 15:56:37 -05:00
Frank Dellaert f714c4ac82 Merge branch 'develop' into hybrid/simplify 2023-01-17 07:50:45 -08:00
Frank Dellaert e444962aad Added correction with the normalization constant in the second elimination path. 2023-01-17 07:47:56 -08:00
Frank Dellaert c3ca31f2f3 Added partial elimination test 2023-01-17 07:47:10 -08:00
Varun Agrawal 7cd360039f
Merge pull request #1387 from borglab/discreteKeys-vector
Some Hybrid Improvements
2023-01-17 04:00:41 -05:00
Frank Dellaert b494a61150 Removed obsolete normalizationConstants method 2023-01-16 19:59:42 -08:00
Frank Dellaert 4283925e60 Ratio test succeeds on fg, but not on posterior yet, 2023-01-16 19:21:10 -08:00
Frank Dellaert f4859f0229 Fix logProbability tests 2023-01-16 18:56:58 -08:00
Frank Dellaert 32d69a3bd7 Trap if conditional==null. 2023-01-16 18:56:40 -08:00
Frank Dellaert 519b2bb515 Added comment 2023-01-16 18:56:25 -08:00
Frank Dellaert e31884c9a1 Eradicated GraphAndConstant 2023-01-16 18:28:12 -08:00
Frank Dellaert 8357fc7e02 Fix python tests (and expose HybridBayesNet.error) 2023-01-16 18:04:22 -08:00
Frank Dellaert a5951d8d34 Fixed test to work with "hidden constant" scheme 2023-01-16 18:03:51 -08:00
Frank Dellaert 202a5a3264 Fixed toFactorGraph and added test to verify 2023-01-16 17:38:01 -08:00
Frank Dellaert 3a446d7008 Explicitly implement logNormalizationConstant 2023-01-16 17:32:54 -08:00
Frank Dellaert 207c9b7236 Implemented the "hidden constant" scheme. 2023-01-16 16:45:30 -08:00