12345qiupeng
/
gtsam
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

make note of bug

release/4.3a0
Varun Agrawal 2025-01-29 01:34:30 -05:00
parent 65ef061c02
commit 847df02c17
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gtsam/discrete/DecisionTreeFactor.cpp
View File

@ -523,6 +523,10 @@ namespace gtsam {
// Check if value is less than the threshold and // Check if value is less than the threshold and
// we haven't exceeded the maximum number of leaves. // we haven't exceeded the maximum number of leaves.
// TODO(Varun): Bug since we can have a case where we need to prune higher
// probabilities after we have reached N.
// E.g. N=3 for [0.2, 0.2, 0.1, 0.2, 0.3]
// will give [0.2, 0.2, 0.0, 0.2, 0.0]
if (value < threshold || total >= N) { if (value < threshold || total >= N) {
return 0.0; return 0.0;
} else { } else {