Fix windows tests

.github/workflows/build-windows.yml

@@ -150,7 +150,10 @@ jobs:
           # cmake --build build -j4 --config ${{ matrix.build_type }} --target check.dynamics_unstable
           # Compile. Fail with exception
           # cmake --build build -j4 --config ${{ matrix.build_type }} --target check.nonlinear_unstable
-          # Compilation error
+          # Compile. Fail with exception
           # cmake --build build -j4 --config ${{ matrix.build_type }} --target check.slam_unstable
-          # Compilation error
+          # Compile. Fail with exception
           # cmake --build build -j4 --config ${{ matrix.build_type }} --target check.partition
+
+          # Run all tests
+          # cmake --build build -j1 --config ${{ matrix.build_type }} --target check

gtsam/discrete/AlgebraicDecisionTree.h

@@ -36,7 +36,7 @@ namespace gtsam {
    * @ingroup discrete
    */
   template <typename L>
-  class GTSAM_EXPORT AlgebraicDecisionTree : public DecisionTree<L, double> {
+  class AlgebraicDecisionTree : public DecisionTree<L, double> {
     /**
      * @brief Default method used by `labelFormatter` or `valueFormatter` when
      * printing.

gtsam/linear/SubgraphBuilder.h

@@ -182,7 +182,7 @@ GaussianFactorGraph buildFactorSubgraph(const GaussianFactorGraph &gfg,
 
 /** Split the graph into a subgraph and the remaining edges. 
  * Note that the remaining factorgraph has null factors. */
-std::pair<GaussianFactorGraph, GaussianFactorGraph> splitFactorGraph(
+std::pair<GaussianFactorGraph, GaussianFactorGraph> GTSAM_EXPORT splitFactorGraph(
     const GaussianFactorGraph &factorGraph, const Subgraph &subgraph);
 
 }  // namespace gtsam

gtsam/sfm/TranslationRecovery.h

@@ -48,7 +48,7 @@ namespace gtsam {
 // where s is an arbitrary scale that can be supplied, default 1.0. Hence, two
 // versions are supplied below corresponding to whether we have initial values
 // or not.
-class TranslationRecovery {
+class GTSAM_EXPORT TranslationRecovery {
  public:
   using KeyPair = std::pair<Key, Key>;
   using TranslationEdges = std::vector<BinaryMeasurement<Unit3>>;

gtsam_unstable/geometry/Event.h

@@ -34,7 +34,7 @@ namespace gtsam {
  * SLAM, where we have "time of arrival" measurements at a set of sensors. The
  * TOA functor below provides a measurement function for those applications.
  */
-class Event {
+class GTSAM_UNSTABLE_EXPORT Event {
   double time_;      ///< Time event was generated
   Point3 location_;  ///< Location at time event was generated
 
@@ -62,10 +62,10 @@ class Event {
   }
 
   /** print with optional string */
-  GTSAM_UNSTABLE_EXPORT void print(const std::string& s = "") const;
+  void print(const std::string& s = "") const;
 
   /** equals with an tolerance */
-  GTSAM_UNSTABLE_EXPORT bool equals(const Event& other,
+  bool equals(const Event& other,
                                     double tol = 1e-9) const;
 
   /// Updates a with tangent space delta

gtsam_unstable/partition/GenericGraph.h

@@ -14,6 +14,7 @@
 #include <stdexcept>
 #include <string>
 #include <memory>
+#include <gtsam_unstable/dllexport.h>
 
 #include "PartitionWorkSpace.h"
 
@@ -49,7 +50,7 @@ namespace gtsam { namespace partition {
   typedef std::vector<sharedGenericFactor2D> GenericGraph2D;
 
   /** merge nodes in DSF using constraints captured by the given graph */
-  std::list<std::vector<size_t> > findIslands(const GenericGraph2D& graph, const std::vector<size_t>& keys, WorkSpace& workspace,
+  std::list<std::vector<size_t> > GTSAM_UNSTABLE_EXPORT findIslands(const GenericGraph2D& graph, const std::vector<size_t>& keys, WorkSpace& workspace,
       const int minNrConstraintsPerCamera, const int minNrConstraintsPerLandmark);
 
   /** eliminate the sensors from generic graph */
@@ -97,11 +98,11 @@ namespace gtsam { namespace partition {
   typedef std::vector<sharedGenericFactor3D> GenericGraph3D;
 
   /** merge nodes in DSF using constraints captured by the given graph */
-  std::list<std::vector<size_t> > findIslands(const GenericGraph3D& graph, const std::vector<size_t>& keys, WorkSpace& workspace,
+  std::list<std::vector<size_t> > GTSAM_UNSTABLE_EXPORT findIslands(const GenericGraph3D& graph, const std::vector<size_t>& keys, WorkSpace& workspace,
       const size_t minNrConstraintsPerCamera, const size_t minNrConstraintsPerLandmark);
 
   /** eliminate the sensors from generic graph */
-  void reduceGenericGraph(const GenericGraph3D& graph, const std::vector<size_t>& cameraKeys,  const std::vector<size_t>& landmarkKeys,
+  void GTSAM_UNSTABLE_EXPORT reduceGenericGraph(const GenericGraph3D& graph, const std::vector<size_t>& cameraKeys,  const std::vector<size_t>& landmarkKeys,
       const std::vector<int>& dictionary,  GenericGraph3D& reducedGraph);
 
   /** check whether the 3D graph is singular (under constrained) */

gtsam_unstable/partition/tests/CMakeLists.txt

@@ -1,6 +1,6 @@
 set(ignore_test "testNestedDissection.cpp")
 
-if (NOT GTSAM_USE_BOOST_FEATURES)
+if (NOT GTSAM_USE_BOOST_FEATURES OR MSVC)
 	list(APPEND ignore_test "testFindSeparator.cpp")
 endif()
 

gtsam_unstable/slam/ProjectionFactorPPPC.h

@@ -32,7 +32,7 @@ namespace gtsam {
    * @ingroup slam
    */
 template <class POSE, class LANDMARK, class CALIBRATION = Cal3_S2>
-class GTSAM_UNSTABLE_EXPORT ProjectionFactorPPPC
+class ProjectionFactorPPPC
     : public NoiseModelFactorN<POSE, POSE, LANDMARK, CALIBRATION> {
  protected:
   Point2 measured_;  ///< 2D measurement

gtsam_unstable/slam/SmartProjectionPoseFactorRollingShutter.h

@@ -42,7 +42,7 @@ namespace gtsam {
  * @ingroup slam
  */
 template <class CAMERA>
-class GTSAM_UNSTABLE_EXPORT SmartProjectionPoseFactorRollingShutter
+class SmartProjectionPoseFactorRollingShutter
     : public SmartProjectionFactor<CAMERA> {
  private:
   typedef SmartProjectionFactor<CAMERA> Base;

gtsam_unstable/slam/tests/testSmartStereoProjectionPoseFactor.cpp

@@ -1441,14 +1441,14 @@ TEST( SmartStereoProjectionPoseFactor, HessianWithRotationNonDegenerate ) {
   std::shared_ptr<GaussianFactor> hessianFactorRotTran =
       smartFactor->linearize(tranValues);
 
-  // Hessian is invariant to rotations and translations in the degenerate case
+  double error;
-  EXPECT(
-      assert_equal(hessianFactor->information(),
 #ifdef GTSAM_USE_EIGEN_MKL
-          hessianFactorRotTran->information(), 1e-5));
+  error = 1e-5;
 #else
-          hessianFactorRotTran->information(), 1e-6));
+  error = 1e-6;
 #endif
+  // Hessian is invariant to rotations and translations in the degenerate case
+  EXPECT(assert_equal(hessianFactor->information(), hessianFactorRotTran->information(), error));
 }
 
 /* ************************************************************************* */