12345qiupeng
/
cartographer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Updated PR template taking wally into account. (#663)

master
Holger Rapp 2017-11-14 14:41:48 +01:00 committed by Wally B. Feed
parent 60c72cb445
commit a7680f60d4
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -1,8 +1,14 @@
Want to contribute? Great! Make sure you've checked all these boxes before creating your PR: Want to contribute? Great! Make sure you've read, understood and considered all
the points below before creating your PR:
- [ ] Keep your PR rebased to master. - Keep your PR under 200 lines of code and address a single concern.
- [ ] Keep your PR under 200 lines of code and address a single concern. - Add unit test(s) and documentation (these do not count toward your 200 lines).
- [ ] Add unit test(s) and documentation (these do not count toward your 200 lines). - Adhere to the [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html).
- [ ] Adhere to the [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html). - Run `ninja test` or `catkin_make_isolated --install --use-ninja --pkg cartographer --make-args test` as appropriate.
- [ ] Run `clang-format -style=Google` on your code (this alone is not enough to ensure you've followed the style guide). - Keep rebasing (or merging) of master branch to a minimum. It triggers Travis
- [ ] Run `ninja test` or `catkin_make_isolated --install --use-ninja --pkg cartographer --make-args test` as appropriate. runs for every update which blocks merging of other changes. Our merge bot
will rebase your branch, reformat your source code and merge as the last step
in the review process.
- Please replace this template text with the commit message you want for your
PR. You and/or the reviewer should keep it updated during the course of the
review using the GitHub edit feature.