From a7680f60d47725f59b210a34b67b36b683a652ff Mon Sep 17 00:00:00 2001 From: Holger Rapp Date: Tue, 14 Nov 2017 14:41:48 +0100 Subject: [PATCH] Updated PR template taking wally into account. (#663) --- .github/PULL_REQUEST_TEMPLATE.md | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0887020..babe3c9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,8 +1,14 @@ -Want to contribute? Great! Make sure you've checked all these boxes before creating your PR: +Want to contribute? Great! Make sure you've read, understood and considered all +the points below before creating your PR: -- [ ] Keep your PR rebased to master. -- [ ] Keep your PR under 200 lines of code and address a single concern. -- [ ] Add unit test(s) and documentation (these do not count toward your 200 lines). -- [ ] Adhere to the [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html). -- [ ] Run `clang-format -style=Google` on your code (this alone is not enough to ensure you've followed the style guide). -- [ ] Run `ninja test` or `catkin_make_isolated --install --use-ninja --pkg cartographer --make-args test` as appropriate. +- Keep your PR under 200 lines of code and address a single concern. +- Add unit test(s) and documentation (these do not count toward your 200 lines). +- Adhere to the [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html). +- Run `ninja test` or `catkin_make_isolated --install --use-ninja --pkg cartographer --make-args test` as appropriate. +- Keep rebasing (or merging) of master branch to a minimum. It triggers Travis + runs for every update which blocks merging of other changes. Our merge bot + will rebase your branch, reformat your source code and merge as the last step + in the review process. +- Please replace this template text with the commit message you want for your + PR. You and/or the reviewer should keep it updated during the course of the + review using the GitHub edit feature.