From e6a50bb721e79981c9d5bba8080e523cdd54fa89 Mon Sep 17 00:00:00 2001 From: Luca Date: Tue, 10 Mar 2015 16:43:43 -0400 Subject: [PATCH 1/2] Passing boost::none as optional parameter, to fix "make check" error --- gtsam/base/Lie.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gtsam/base/Lie.h b/gtsam/base/Lie.h index bf2056cc8..f077ebe0b 100644 --- a/gtsam/base/Lie.h +++ b/gtsam/base/Lie.h @@ -246,9 +246,9 @@ public: g = traits::Between(g, h, Hg, Hh); g = traits::Inverse(g, Hg); // log and exp map without Jacobians - g = traits::Expmap(v); + g = traits::Expmap(v, boost::none); v = traits::Logmap(g); - // log and expnential map with Jacobians + // log and exponential map with Jacobians g = traits::Expmap(v, Hg); v = traits::Logmap(g, Hg); } From cdd37c79733a490498a76b0fffec63caa1f1edcd Mon Sep 17 00:00:00 2001 From: Luca Date: Tue, 10 Mar 2015 18:38:09 -0400 Subject: [PATCH 2/2] removed fix, now "make check" will fail again --- gtsam/base/Lie.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtsam/base/Lie.h b/gtsam/base/Lie.h index f077ebe0b..c9f788992 100644 --- a/gtsam/base/Lie.h +++ b/gtsam/base/Lie.h @@ -246,7 +246,7 @@ public: g = traits::Between(g, h, Hg, Hh); g = traits::Inverse(g, Hg); // log and exp map without Jacobians - g = traits::Expmap(v, boost::none); + g = traits::Expmap(v); v = traits::Logmap(g); // log and exponential map with Jacobians g = traits::Expmap(v, Hg);