12345qiupeng
/
gtsam
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add edge case pruning test and fix

release/4.3a0
Varun Agrawal 2025-03-04 16:00:48 -05:00
parent c6a22301b7
commit f3fff0c997
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gtsam/discrete/DecisionTreeFactor.cpp
View File

@ -501,6 +501,10 @@ namespace gtsam {
}; };
this->visitWith(op); this->visitWith(op);
// If total number of hypotheses is less than N, return 0.0
if (min_heap.size() < N) {
return 0.0;
}
return min_heap.top(); return min_heap.top();
} }

7
gtsam/discrete/tests/testDecisionTreeFactor.cpp
View File

@ -132,7 +132,6 @@ TEST(DecisionTreeFactor, Divide) {
KeySet keys(joint.keys()); KeySet keys(joint.keys());
keys.insert(pA.keys().begin(), pA.keys().end()); keys.insert(pA.keys().begin(), pA.keys().end());
EXPECT(assert_inequal(KeySet(pS.keys()), keys)); EXPECT(assert_inequal(KeySet(pS.keys()), keys));
} }
/* ************************************************************************* */ /* ************************************************************************* */
@ -234,6 +233,12 @@ TEST(DecisionTreeFactor, Prune) {
maxNrAssignments = 5; maxNrAssignments = 5;
auto pruned3 = factor.prune(maxNrAssignments); auto pruned3 = factor.prune(maxNrAssignments);
EXPECT(assert_equal(expected3, pruned3)); EXPECT(assert_equal(expected3, pruned3));
// Edge case where the number of hypotheses are less than maxNrAssignments
DecisionTreeFactor f(A, "0.50001 0.49999");
auto pruned4 = f.prune(10);
DecisionTreeFactor expected4(A, "0.50001 0.49999");
EXPECT(assert_equal(expected4, pruned4));
} }
/* ************************************************************************** */ /* ************************************************************************** */