From eef7a19983793241aa00c56cbd2384eada9cdfbf Mon Sep 17 00:00:00 2001
From: Richard Roberts <richard.jw.roberts@gmail.com>
Date: Mon, 17 Feb 2014 00:44:50 -0500
Subject: [PATCH] Added a warning when linking to libraries where duplicates
 are distributed with matlab, with instructions for moving the libraries away.

---
 cmake/GtsamMatlabWrap.cmake | 83 +++++++++++++++++++++++++++++++++++++
 1 file changed, 83 insertions(+)

diff --git a/cmake/GtsamMatlabWrap.cmake b/cmake/GtsamMatlabWrap.cmake
index 4f2434888..a8592f16c 100644
--- a/cmake/GtsamMatlabWrap.cmake
+++ b/cmake/GtsamMatlabWrap.cmake
@@ -103,6 +103,7 @@ function(wrap_library_internal interfaceHeader linkLibraries extraIncludeDirs ex
 	# Add -shared or -static suffix to targets
 	set(correctedOtherLibraries "")
 	set(otherLibraryTargets "")
+    set(otherLibraryNontargets "")
 	foreach(lib ${moduleName} ${linkLibraries})
 		if(TARGET ${lib})
 			list(APPEND correctedOtherLibraries ${lib})
@@ -115,8 +116,20 @@ function(wrap_library_internal interfaceHeader linkLibraries extraIncludeDirs ex
 			list(APPEND otherLibraryTargets ${lib}-static)
 		else()
 			list(APPEND correctedOtherLibraries ${lib})
+            list(APPEND otherLibraryNontargets ${lib})
 		endif()
 	endforeach()
+    
+    # Check libraries for conflicting versions built-in to MATLAB
+    set(dependentLibraries "")
+    if(NOT "${otherLibraryTargets}" STREQUAL "")
+        foreach(target ${otherLibraryTargets})
+            get_target_property(dependentLibrariesOne ${target} INTERFACE_LINK_LIBRARIES)
+            list(APPEND dependentLibraries ${dependentLibrariesOne})
+        endforeach()
+    endif()
+    list(APPEND dependentLibraries ${otherLibraryNontargets})
+    check_conflicting_libraries_internal("${dependentLibraries}")
 
 	# Set up generation of module source file
 	file(MAKE_DIRECTORY "${generated_files_path}")
@@ -205,6 +218,76 @@ function(install_wrapped_library_internal interfaceHeader)
 	endif()
 endfunction()
 
+function(check_conflicting_libraries_internal libraries)
+    if(UNIX)
+        # Set path for matlab's built-in libraries
+        if(APPLE)
+            set(mxLibPath "${MATLAB_ROOT}/bin/maci64")
+        else()
+            if(CMAKE_CL_64)
+                set(mxLibPath "${MATLAB_ROOT}/bin/glnxa64")
+            else()
+                set(mxLibPath "${MATLAB_ROOT}/bin/glnx86")
+            endif()
+        endif()
+        
+        # List matlab's built-in libraries
+        file(GLOB matlabLibs RELATIVE "${mxLibPath}" "${mxLibPath}/lib*")
+        
+        # Convert to base names
+        set(matlabLibNames "")
+        foreach(lib ${matlabLibs})
+            get_filename_component(libName "${lib}" NAME_WE)
+            list(APPEND matlabLibNames "${libName}")
+        endforeach()
+        
+        # Get names of link libraries
+        set(linkLibNames "")
+        foreach(lib ${libraries})
+            string(FIND "${lib}" "/" slashPos)
+            if(NOT slashPos EQUAL -1)
+                # If the name is a path, just get the library name
+                get_filename_component(libName "${lib}" NAME_WE)
+                list(APPEND linkLibNames "${libName}")
+            else()
+                # It's not a path, so see if it looks like a filename
+                get_filename_component(ext "${lib}" EXT)
+                if(NOT "${ext}" STREQUAL "")
+                    # It's a filename, so get the base name
+                    get_filename_component(libName "${lib}" NAME_WE)
+                    list(APPEND linkLibNames "${libName}")
+                else()
+                    # It's not a filename so it must be a short name, add the "lib" prefix
+                    list(APPEND linkLibNames "lib${lib}")
+                endif()
+            endif()
+        endforeach()
+        
+        # Remove duplicates
+        list(REMOVE_DUPLICATES linkLibNames)
+        
+        set(conflictingLibs "")
+        foreach(lib ${linkLibNames})
+            list(FIND matlabLibNames "${lib}" libPos)
+            if(NOT libPos EQUAL -1)
+                if(NOT conflictingLibs STREQUAL "")
+                    set(conflictingLibs "${conflictingLibs}, ")
+                endif()
+                set(conflictingLibs "${conflictingLibs}${lib}")
+            endif()
+        endforeach()
+        
+        if(NOT "${conflictingLibs}" STREQUAL "")
+            message(WARNING "GTSAM links to the libraries [ ${conflictingLibs} ] on your system, but "
+                "MATLAB is distributed with its own versions of these libraries which may conflict. "
+                "If you get strange errors or crashes with the GTSAM MATLAB wrapper, move these "
+                "libraries out of MATLAB's built-in library directory, which is ${mxLibPath} on "
+                "your system.  MATLAB will usually still work with these libraries moved away, but "
+                "if not, you'll have to compile the static GTSAM MATLAB wrapper module.")
+        endif()
+    endif()
+endfunction()
+
 
 # Function to setup codegen and building of the wrap toolbox
 #