From d191b0cebbe840b322ea66f5ea788044f66bc4a0 Mon Sep 17 00:00:00 2001 From: cbeall3 Date: Thu, 10 Jul 2014 07:58:56 -0400 Subject: [PATCH] space between double angle-brackets --- gtsam/slam/JacobianFactorQ.h | 2 +- gtsam/slam/JacobianFactorSVD.h | 2 +- gtsam/slam/SmartFactorBase.h | 13 +++++++------ 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/gtsam/slam/JacobianFactorQ.h b/gtsam/slam/JacobianFactorQ.h index 1e264ccba..de13f7ef0 100644 --- a/gtsam/slam/JacobianFactorQ.h +++ b/gtsam/slam/JacobianFactorQ.h @@ -37,7 +37,7 @@ public: } /// Constructor - JacobianFactorQ(const std::vector>& Fblocks, + JacobianFactorQ(const std::vector >& Fblocks, const Matrix& E, const Matrix3& P, const Vector& b, const SharedDiagonal& model = SharedDiagonal()) : JacobianSchurFactor() { diff --git a/gtsam/slam/JacobianFactorSVD.h b/gtsam/slam/JacobianFactorSVD.h index 558a6c740..0d3c04de1 100644 --- a/gtsam/slam/JacobianFactorSVD.h +++ b/gtsam/slam/JacobianFactorSVD.h @@ -36,7 +36,7 @@ public: } /// Constructor - JacobianFactorSVD(const std::vector>& Fblocks, const Matrix& Enull, const Vector& b, + JacobianFactorSVD(const std::vector >& Fblocks, const Matrix& Enull, const Vector& b, const SharedDiagonal& model = SharedDiagonal()) : JacobianSchurFactor() { size_t numKeys = Enull.rows() / 2; size_t j = 0, m2 = 2*numKeys-3; diff --git a/gtsam/slam/SmartFactorBase.h b/gtsam/slam/SmartFactorBase.h index a185cefd5..ae2dc8b0f 100644 --- a/gtsam/slam/SmartFactorBase.h +++ b/gtsam/slam/SmartFactorBase.h @@ -33,7 +33,8 @@ #include #include #include -#include +#include +//#include namespace gtsam { /// Base class with no internal point, completely functional @@ -261,7 +262,7 @@ public: // **************************************************************************************************** /// Compute F, E only (called below in both vanilla and SVD versions) /// Given a Point3, assumes dimensionality is 3 - double computeJacobians(std::vector>& Fblocks, Matrix& E, + double computeJacobians(std::vector >& Fblocks, Matrix& E, Vector& b, const Cameras& cameras, const Point3& point) const { size_t numKeys = this->keys_.size(); @@ -298,7 +299,7 @@ public: // **************************************************************************************************** /// Version that computes PointCov, with optional lambda parameter - double computeJacobians(std::vector>& Fblocks, Matrix& E, + double computeJacobians(std::vector >& Fblocks, Matrix& E, Matrix3& PointCov, Vector& b, const Cameras& cameras, const Point3& point, double lambda = 0.0, bool diagonalDamping = false) const { @@ -329,7 +330,7 @@ public: const double lambda = 0.0) const { size_t numKeys = this->keys_.size(); - std::vector> Fblocks; + std::vector > Fblocks; double f = computeJacobians(Fblocks, E, PointCov, b, cameras, point, lambda); F = zeros(Z::Dim() * numKeys, D * numKeys); @@ -342,7 +343,7 @@ public: // **************************************************************************************************** /// SVD version - double computeJacobiansSVD(std::vector>& Fblocks, Matrix& Enull, + double computeJacobiansSVD(std::vector >& Fblocks, Matrix& Enull, Vector& b, const Cameras& cameras, const Point3& point, double lambda = 0.0, bool diagonalDamping = false) const { @@ -642,7 +643,7 @@ public: boost::shared_ptr > createJacobianQFactor( const Cameras& cameras, const Point3& point, double lambda = 0.0, bool diagonalDamping = false) const { - std::vector> Fblocks; + std::vector > Fblocks; Matrix E; Matrix3 PointCov; Vector b;