From f2bfdbd317b02dfc75143c6c34c91b7f16a72f6f Mon Sep 17 00:00:00 2001 From: Varun Agrawal Date: Sun, 15 Nov 2020 18:40:02 -0500 Subject: [PATCH 1/7] upload build directory after workflow completes --- .github/workflows/build-linux.yml | 7 ++++++- .github/workflows/build-macos.yml | 5 +++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index d80a7f4ba..07397c999 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -82,4 +82,9 @@ jobs: - name: Build and Test (Linux) if: runner.os == 'Linux' run: | - bash .github/scripts/unix.sh -t \ No newline at end of file + bash .github/scripts/unix.sh -t + - name: Upload build directory + uses: actions/upload-artifact@v2 + with: + name: gtsam-${{ matrix.name }} + path: $GITHUB_WORKSPACE/build/ diff --git a/.github/workflows/build-macos.yml b/.github/workflows/build-macos.yml index 69873980a..524cef18a 100644 --- a/.github/workflows/build-macos.yml +++ b/.github/workflows/build-macos.yml @@ -51,3 +51,8 @@ jobs: if: runner.os == 'macOS' run: | bash .github/scripts/unix.sh -t + - name: Upload build directory + uses: actions/upload-artifact@v2 + with: + name: gtsam-${{ matrix.name }} + path: $GITHUB_WORKSPACE/build/ From 5c94b5ccc70d374a49f024dcb24bcec94382c817 Mon Sep 17 00:00:00 2001 From: Varun Agrawal Date: Mon, 16 Nov 2020 13:11:10 -0500 Subject: [PATCH 2/7] fix indentation and add upload for Windows --- .github/workflows/build-linux.yml | 6 +++--- .github/workflows/build-macos.yml | 6 +++--- .github/workflows/build-windows.yml | 7 ++++++- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index 07397c999..514f7c6d5 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -85,6 +85,6 @@ jobs: bash .github/scripts/unix.sh -t - name: Upload build directory uses: actions/upload-artifact@v2 - with: - name: gtsam-${{ matrix.name }} - path: $GITHUB_WORKSPACE/build/ + with: + name: gtsam-${{ matrix.name }} + path: $GITHUB_WORKSPACE/build/ diff --git a/.github/workflows/build-macos.yml b/.github/workflows/build-macos.yml index 524cef18a..298fc316b 100644 --- a/.github/workflows/build-macos.yml +++ b/.github/workflows/build-macos.yml @@ -53,6 +53,6 @@ jobs: bash .github/scripts/unix.sh -t - name: Upload build directory uses: actions/upload-artifact@v2 - with: - name: gtsam-${{ matrix.name }} - path: $GITHUB_WORKSPACE/build/ + with: + name: gtsam-${{ matrix.name }} + path: $GITHUB_WORKSPACE/build/ diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 0a55de880..446e708a6 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -75,4 +75,9 @@ jobs: cmake --build build --config ${{ matrix.build_type }} --target wrap cmake --build build --config ${{ matrix.build_type }} --target check.base cmake --build build --config ${{ matrix.build_type }} --target check.base_unstable - cmake --build build --config ${{ matrix.build_type }} --target check.linear \ No newline at end of file + cmake --build build --config ${{ matrix.build_type }} --target check.linear + - name: Upload build directory + uses: actions/upload-artifact@v2 + with: + name: gtsam-${{ matrix.name }} + path: $GITHUB_WORKSPACE/build/ From aa2d9225dcc52848342d68435b28dc5995698700 Mon Sep 17 00:00:00 2001 From: Varun Agrawal Date: Mon, 16 Nov 2020 14:42:17 -0500 Subject: [PATCH 3/7] correct form for workspace env variable --- .github/workflows/build-linux.yml | 2 +- .github/workflows/build-macos.yml | 2 +- .github/workflows/build-windows.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index 514f7c6d5..1778286d9 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -87,4 +87,4 @@ jobs: uses: actions/upload-artifact@v2 with: name: gtsam-${{ matrix.name }} - path: $GITHUB_WORKSPACE/build/ + path: ${{ github.workspace }}/build/ diff --git a/.github/workflows/build-macos.yml b/.github/workflows/build-macos.yml index 298fc316b..2a3af6b9e 100644 --- a/.github/workflows/build-macos.yml +++ b/.github/workflows/build-macos.yml @@ -55,4 +55,4 @@ jobs: uses: actions/upload-artifact@v2 with: name: gtsam-${{ matrix.name }} - path: $GITHUB_WORKSPACE/build/ + path: ${{ github.workspace }}/build/ diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 446e708a6..1de0d0493 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -80,4 +80,4 @@ jobs: uses: actions/upload-artifact@v2 with: name: gtsam-${{ matrix.name }} - path: $GITHUB_WORKSPACE/build/ + path: ${{ github.workspace }}/build/ From d5a09aad12ef04392cacb8b8bfe1589a66e42fca Mon Sep 17 00:00:00 2001 From: Varun Agrawal Date: Mon, 16 Nov 2020 17:47:42 -0500 Subject: [PATCH 4/7] differentiate between Release and Debug builds --- .github/workflows/build-linux.yml | 2 +- .github/workflows/build-macos.yml | 2 +- .github/workflows/build-windows.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index 1778286d9..cd4933cd9 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -86,5 +86,5 @@ jobs: - name: Upload build directory uses: actions/upload-artifact@v2 with: - name: gtsam-${{ matrix.name }} + name: gtsam-${{ matrix.name }}-${{ matrix.build_type }} path: ${{ github.workspace }}/build/ diff --git a/.github/workflows/build-macos.yml b/.github/workflows/build-macos.yml index 2a3af6b9e..5e6f8ca04 100644 --- a/.github/workflows/build-macos.yml +++ b/.github/workflows/build-macos.yml @@ -54,5 +54,5 @@ jobs: - name: Upload build directory uses: actions/upload-artifact@v2 with: - name: gtsam-${{ matrix.name }} + name: gtsam-${{ matrix.name }}-${{ matrix.build_type }} path: ${{ github.workspace }}/build/ diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 1de0d0493..63c276020 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -79,5 +79,5 @@ jobs: - name: Upload build directory uses: actions/upload-artifact@v2 with: - name: gtsam-${{ matrix.name }} + name: gtsam-${{ matrix.name }}-${{ matrix.build_type }} path: ${{ github.workspace }}/build/ From 9e2007562a8448065224a30c72240ea4aea1b643 Mon Sep 17 00:00:00 2001 From: Varun Agrawal Date: Thu, 19 Nov 2020 08:04:30 -0500 Subject: [PATCH 5/7] only upload release builds --- .github/workflows/build-linux.yml | 1 + .github/workflows/build-macos.yml | 1 + .github/workflows/build-windows.yml | 1 + 3 files changed, 3 insertions(+) diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index cd4933cd9..940e34b82 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -85,6 +85,7 @@ jobs: bash .github/scripts/unix.sh -t - name: Upload build directory uses: actions/upload-artifact@v2 + if: ${{ matrix.build_type }} == "Release" with: name: gtsam-${{ matrix.name }}-${{ matrix.build_type }} path: ${{ github.workspace }}/build/ diff --git a/.github/workflows/build-macos.yml b/.github/workflows/build-macos.yml index 5e6f8ca04..cccfd7b5b 100644 --- a/.github/workflows/build-macos.yml +++ b/.github/workflows/build-macos.yml @@ -53,6 +53,7 @@ jobs: bash .github/scripts/unix.sh -t - name: Upload build directory uses: actions/upload-artifact@v2 + if: ${{ matrix.build_type }} == "Release" with: name: gtsam-${{ matrix.name }}-${{ matrix.build_type }} path: ${{ github.workspace }}/build/ diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 63c276020..a14d7de5e 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -78,6 +78,7 @@ jobs: cmake --build build --config ${{ matrix.build_type }} --target check.linear - name: Upload build directory uses: actions/upload-artifact@v2 + if: ${{ matrix.build_type }} == "Release" with: name: gtsam-${{ matrix.name }}-${{ matrix.build_type }} path: ${{ github.workspace }}/build/ From 99e3a111e1d7d0d16cc05e8b12fed6390bbbdf28 Mon Sep 17 00:00:00 2001 From: Varun Agrawal Date: Thu, 19 Nov 2020 14:58:50 -0500 Subject: [PATCH 6/7] correct conditional syntax --- .github/workflows/build-linux.yml | 2 +- .github/workflows/build-macos.yml | 2 +- .github/workflows/build-windows.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index 940e34b82..4039711f2 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -85,7 +85,7 @@ jobs: bash .github/scripts/unix.sh -t - name: Upload build directory uses: actions/upload-artifact@v2 - if: ${{ matrix.build_type }} == "Release" + if: ${{ matrix.build_type == "Release" }} with: name: gtsam-${{ matrix.name }}-${{ matrix.build_type }} path: ${{ github.workspace }}/build/ diff --git a/.github/workflows/build-macos.yml b/.github/workflows/build-macos.yml index cccfd7b5b..1d36e048f 100644 --- a/.github/workflows/build-macos.yml +++ b/.github/workflows/build-macos.yml @@ -53,7 +53,7 @@ jobs: bash .github/scripts/unix.sh -t - name: Upload build directory uses: actions/upload-artifact@v2 - if: ${{ matrix.build_type }} == "Release" + if: ${{ matrix.build_type == "Release" }} with: name: gtsam-${{ matrix.name }}-${{ matrix.build_type }} path: ${{ github.workspace }}/build/ diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index a14d7de5e..8e469d49f 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -78,7 +78,7 @@ jobs: cmake --build build --config ${{ matrix.build_type }} --target check.linear - name: Upload build directory uses: actions/upload-artifact@v2 - if: ${{ matrix.build_type }} == "Release" + if: ${{ matrix.build_type == "Release" }} with: name: gtsam-${{ matrix.name }}-${{ matrix.build_type }} path: ${{ github.workspace }}/build/ From c206ed9c2fcfff0802951ae7cabea5c8ba7ecd5e Mon Sep 17 00:00:00 2001 From: Varun Agrawal Date: Thu, 19 Nov 2020 15:35:09 -0500 Subject: [PATCH 7/7] syntax update --- .github/workflows/build-linux.yml | 2 +- .github/workflows/build-macos.yml | 2 +- .github/workflows/build-windows.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index 4039711f2..32c3bd8aa 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -85,7 +85,7 @@ jobs: bash .github/scripts/unix.sh -t - name: Upload build directory uses: actions/upload-artifact@v2 - if: ${{ matrix.build_type == "Release" }} + if: matrix.build_type == 'Release' with: name: gtsam-${{ matrix.name }}-${{ matrix.build_type }} path: ${{ github.workspace }}/build/ diff --git a/.github/workflows/build-macos.yml b/.github/workflows/build-macos.yml index 1d36e048f..cf1a474e3 100644 --- a/.github/workflows/build-macos.yml +++ b/.github/workflows/build-macos.yml @@ -53,7 +53,7 @@ jobs: bash .github/scripts/unix.sh -t - name: Upload build directory uses: actions/upload-artifact@v2 - if: ${{ matrix.build_type == "Release" }} + if: matrix.build_type == 'Release' with: name: gtsam-${{ matrix.name }}-${{ matrix.build_type }} path: ${{ github.workspace }}/build/ diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 8e469d49f..7eb908c94 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -78,7 +78,7 @@ jobs: cmake --build build --config ${{ matrix.build_type }} --target check.linear - name: Upload build directory uses: actions/upload-artifact@v2 - if: ${{ matrix.build_type == "Release" }} + if: matrix.build_type == 'Release' with: name: gtsam-${{ matrix.name }}-${{ matrix.build_type }} path: ${{ github.workspace }}/build/