From c59f458facb10c224383995ebaefeb0fa6883a4a Mon Sep 17 00:00:00 2001
From: Varun Agrawal <varagrawal@gmail.com>
Date: Sat, 24 Aug 2024 15:32:18 -0400
Subject: [PATCH] improved check

---
 gtsam/nonlinear/NonlinearOptimizerParams.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gtsam/nonlinear/NonlinearOptimizerParams.cpp b/gtsam/nonlinear/NonlinearOptimizerParams.cpp
index 800db02a0..55dfd4561 100644
--- a/gtsam/nonlinear/NonlinearOptimizerParams.cpp
+++ b/gtsam/nonlinear/NonlinearOptimizerParams.cpp
@@ -132,8 +132,8 @@ bool NonlinearOptimizerParams::equals(const NonlinearOptimizerParams& other,
   if (iterativeParams && other.iterativeParams) {
     iterative_params_equal = iterativeParams->equals(*other.iterativeParams);
   } else {
-    // If one or both shared pointers are null, we can't assume they are equal
-    iterative_params_equal = false;
+    // Check if either is null. If both are null, then true
+    iterative_params_equal = !iterativeParams && !other.iterativeParams;
   }
 
   return maxIterations == other.getMaxIterations() &&