Removed unused "zero_below_diagonal" flag in Matrix QR

release/4.3a0
Richard Roberts 2012-08-22 22:40:04 +00:00
parent 9962a66e7c
commit b6ddb2197b
2 changed files with 2 additions and 2 deletions

View File

@ -293,7 +293,7 @@ std::pair<Matrix,Matrix> qr(const Matrix& A);
* @param clear_below_diagonal enables zeroing out below diagonal
*/
template <class MATRIX>
void inplace_QR(MATRIX& A, bool clear_below_diagonal=true) {
void inplace_QR(MATRIX& A) {
size_t rows = A.rows();
size_t cols = A.cols();
size_t size = std::min(rows,cols);

View File

@ -124,7 +124,7 @@ SharedDiagonal Gaussian::QR(Matrix& Ab) const {
if(debug) gtsam::print(Ab, "Whitened Ab: ");
// Eigen QR - much faster than older householder approach
inplace_QR(Ab, false);
inplace_QR(Ab);
// hand-coded householder implementation
// TODO: necessary to isolate last column?