12345qiupeng
/
gtsam
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Empty derived destructors are not needed

release/4.3a0
dellaert 2014-10-08 17:32:46 +02:00
parent 6a1bc6e242
commit abb92632b8
1 changed files with 3 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
gtsam_unstable/nonlinear/Expression-inl.h
View File

@ -263,10 +263,6 @@ class ConstantExpression: public ExpressionNode<T> {
public: public:
/// Destructor
virtual ~ConstantExpression() {
}
/// Return keys that play in this expression, i.e., the empty set /// Return keys that play in this expression, i.e., the empty set
virtual std::set<Key> keys() const { virtual std::set<Key> keys() const {
std::set<Key> keys; std::set<Key> keys;
@ -306,10 +302,6 @@ class LeafExpression: public ExpressionNode<T> {
public: public:
/// Destructor
virtual ~LeafExpression() {
}
/// Return keys that play in this expression /// Return keys that play in this expression
virtual std::set<Key> keys() const { virtual std::set<Key> keys() const {
std::set<Key> keys; std::set<Key> keys;
@ -359,10 +351,6 @@ private:
public: public:
/// Destructor
virtual ~UnaryExpression() {
}
/// Return keys that play in this expression /// Return keys that play in this expression
virtual std::set<Key> keys() const { virtual std::set<Key> keys() const {
return expressionA_->keys(); return expressionA_->keys();
@ -387,8 +375,7 @@ public:
struct Trace: public JacobianTrace { struct Trace: public JacobianTrace {
TracePtr trace; TracePtr trace;
JacobianTA dTdA; JacobianTA dTdA;
virtual ~Trace() {
}
/// Start the reverse AD process /// Start the reverse AD process
virtual void reverseAD(JacobianMap& jacobians) const { virtual void reverseAD(JacobianMap& jacobians) const {
trace.reverseAD(dTdA, jacobians); trace.reverseAD(dTdA, jacobians);
@ -438,10 +425,6 @@ private:
public: public:
/// Destructor
virtual ~BinaryExpression() {
}
/// Return keys that play in this expression /// Return keys that play in this expression
virtual std::set<Key> keys() const { virtual std::set<Key> keys() const {
std::set<Key> keys1 = expressionA1_->keys(); std::set<Key> keys1 = expressionA1_->keys();
@ -475,8 +458,7 @@ public:
TracePtr trace1, trace2; TracePtr trace1, trace2;
JacobianTA1 dTdA1; JacobianTA1 dTdA1;
JacobianTA2 dTdA2; JacobianTA2 dTdA2;
virtual ~Trace() {
}
/// Start the reverse AD process /// Start the reverse AD process
virtual void reverseAD(JacobianMap& jacobians) const { virtual void reverseAD(JacobianMap& jacobians) const {
trace1.reverseAD(dTdA1, jacobians); trace1.reverseAD(dTdA1, jacobians);
@ -535,10 +517,6 @@ private:
public: public:
/// Destructor
virtual ~TernaryExpression() {
}
/// Return keys that play in this expression /// Return keys that play in this expression
virtual std::set<Key> keys() const { virtual std::set<Key> keys() const {
std::set<Key> keys1 = expressionA1_->keys(); std::set<Key> keys1 = expressionA1_->keys();
@ -580,8 +558,7 @@ public:
JacobianTA1 dTdA1; JacobianTA1 dTdA1;
JacobianTA2 dTdA2; JacobianTA2 dTdA2;
JacobianTA3 dTdA3; JacobianTA3 dTdA3;
virtual ~Trace() {
}
/// Start the reverse AD process /// Start the reverse AD process
virtual void reverseAD(JacobianMap& jacobians) const { virtual void reverseAD(JacobianMap& jacobians) const {
trace1.reverseAD(dTdA1, jacobians); trace1.reverseAD(dTdA1, jacobians);