Merge pull request #2033 from jmackay2/fix_maybe_uninitialized

fix maybe unitialized warning
release/4.3a0
Frank Dellaert 2025-02-27 09:39:54 -05:00 committed by GitHub
commit a83c50dc6c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 4 deletions

View File

@ -9,10 +9,6 @@
#include <gtsam/geometry/FundamentalMatrix.h> #include <gtsam/geometry/FundamentalMatrix.h>
#include <gtsam/geometry/Point2.h> #include <gtsam/geometry/Point2.h>
#if defined(__GNUC__) && !defined(__clang__)
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
#endif
namespace gtsam { namespace gtsam {
//************************************************************************* //*************************************************************************
@ -40,6 +36,9 @@ FundamentalMatrix::FundamentalMatrix(const Matrix3& U, double s,
FundamentalMatrix::FundamentalMatrix(const Matrix3& F) { FundamentalMatrix::FundamentalMatrix(const Matrix3& F) {
// Perform SVD // Perform SVD
Eigen::JacobiSVD<Matrix3> svd(F, Eigen::ComputeFullU | Eigen::ComputeFullV); Eigen::JacobiSVD<Matrix3> svd(F, Eigen::ComputeFullU | Eigen::ComputeFullV);
if (svd.info() != Eigen::ComputationInfo::Success) {
throw std::runtime_error("FundamentalMatrix::FundamentalMatrix: SVD computation failure");
}
// Extract U and V // Extract U and V
Matrix3 U = svd.matrixU(); Matrix3 U = svd.matrixU();