operator* version which accepts DiscreteFactor

gtsam/discrete/DecisionTreeFactor.cpp

@@ -82,6 +82,17 @@ namespace gtsam {
     ADT::print("", formatter);
   }
 
+  /* ************************************************************************ */
+  DiscreteFactor::shared_ptr DecisionTreeFactor::operator*(
+      const DiscreteFactor::shared_ptr& f) const {
+    if (auto derived = std::dynamic_pointer_cast<DecisionTreeFactor>(f)) {
+      return std::make_shared<DecisionTreeFactor>(this->operator*(*derived));
+    } else {
+      throw std::runtime_error(
+          "Cannot convert DiscreteFactor to DecisionTreeFactor");
+    }
+  }
+
   /* ************************************************************************ */
   DecisionTreeFactor DecisionTreeFactor::apply(ADT::Unary op) const {
     // apply operand

gtsam/discrete/DecisionTreeFactor.h

@@ -144,10 +144,13 @@ namespace gtsam {
     double error(const DiscreteValues& values) const override;
 
     /// multiply two factors
-    DecisionTreeFactor operator*(const DecisionTreeFactor& f) const override {
+    DecisionTreeFactor operator*(const DecisionTreeFactor& f) const {
       return apply(f, ADT::Ring::mul);
     }
 
+    DiscreteFactor::shared_ptr operator*(
+        const DiscreteFactor::shared_ptr& f) const override;
+
     static double safe_div(const double& a, const double& b);
 
     /// divide by factor f (safely)

gtsam/discrete/DiscreteFactor.h

@@ -107,9 +107,10 @@ class GTSAM_EXPORT DiscreteFactor : public Factor {
   /// Compute error for each assignment and return as a tree
   virtual AlgebraicDecisionTree<Key> errorTree() const;
 
-  /// Multiply in a DecisionTreeFactor and return the result as
-  /// DecisionTreeFactor
-  virtual DecisionTreeFactor operator*(const DecisionTreeFactor&) const = 0;
+  /// Multiply in a DiscreteFactor and return the result as
+  /// DiscreteFactor
+  virtual DiscreteFactor::shared_ptr operator*(
+      const DiscreteFactor::shared_ptr&) const = 0;
 
   virtual DecisionTreeFactor toDecisionTreeFactor() const = 0;
 

gtsam/discrete/TableFactor.cpp

@@ -169,8 +169,13 @@ double TableFactor::error(const HybridValues& values) const {
 }
 
 /* ************************************************************************ */
-DecisionTreeFactor TableFactor::operator*(const DecisionTreeFactor& f) const {
-  return toDecisionTreeFactor() * f;
+DiscreteFactor::shared_ptr TableFactor::operator*(
+    const DiscreteFactor::shared_ptr& f) const {
+  if (auto derived = std::dynamic_pointer_cast<TableFactor>(f)) {
+    return std::make_shared<TableFactor>(this->operator*(*derived));
+  } else {
+    throw std::runtime_error("Cannot convert DiscreteFactor to TableFactor");
+  }
 }
 
 /* ************************************************************************ */

gtsam/discrete/TableFactor.h

@@ -186,8 +186,9 @@ class GTSAM_EXPORT TableFactor : public DiscreteFactor {
     return apply(f, Ring::mul);
   };
 
-  /// multiply with DecisionTreeFactor
-  DecisionTreeFactor operator*(const DecisionTreeFactor& f) const override;
+  /// multiply with DiscreteFactor
+  DiscreteFactor::shared_ptr operator*(
+      const DiscreteFactor::shared_ptr& f) const override;
 
   static double safe_div(const double& a, const double& b);