12345qiupeng
/
gtsam
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disabled 2 tests, incompatible with Unit3 retract, with extensive comment

release/4.3a0
Frank 2015-10-19 15:20:40 -07:00
parent ee5bd7ac39
commit a1881efc70
2 changed files with 46 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
gtsam/sam/tests/testBearingFactor.cpp
View File

@ -81,23 +81,33 @@ TEST(BearingFactor, Serialization3D) {
} }
/* ************************************************************************* */ /* ************************************************************************* */
TEST(BearingFactor, 3D) { // TODO(frank): this test is disabled (for now) because the macros below are
// Serialize the factor // incompatible with the Unit3 localCoordinates. The issue is the following:
std::string serialized = serializeXML(factor3D); // For factors, we want to use Local(value, measured), because we need the error
// to be expressed in the tangent space of value. This surfaced in the Unit3 case
// And de-serialize it // where the tangent space can be radically didfferent from one value to the next.
BearingFactor3D factor; // For derivatives, we want Local(constant, varying), because we need a derivative
deserializeXML(serialized, factor); // in a constant tangent space. But since the macros below call whitenedError
// which calls Local(value,measured), we actually call the reverse. This does not
// Set the linearization point // matter for types with a commutative Local, but matters a lot for Unit3.
Values values; // More thinking needed about what the right thing is, here...
values.insert(poseKey, Pose3()); //TEST(BearingFactor, 3D) {
values.insert(pointKey, Point3(1, 0, 0)); // // Serialize the factor
// std::string serialized = serializeXML(factor3D);
EXPECT_CORRECT_EXPRESSION_JACOBIANS(factor.expression(poseKey, pointKey), //
values, 1e-7, 1e-5); // // And de-serialize it
EXPECT_CORRECT_FACTOR_JACOBIANS(factor, values, 1e-7, 1e-5); // BearingFactor3D factor;
} // deserializeXML(serialized, factor);
//
// // Set the linearization point
// Values values;
// values.insert(poseKey, Pose3());
// values.insert(pointKey, Point3(1, 0, 0));
//
// EXPECT_CORRECT_EXPRESSION_JACOBIANS(factor.expression(poseKey, pointKey),
// values, 1e-7, 1e-5);
// EXPECT_CORRECT_FACTOR_JACOBIANS(factor, values, 1e-7, 1e-5);
//}
/* ************************************************************************* */ /* ************************************************************************* */
int main() { int main() {

36
gtsam/sam/tests/testBearingRangeFactor.cpp
View File

@ -80,23 +80,25 @@ TEST(BearingRangeFactor, Serialization3D) {
} }
/* ************************************************************************* */ /* ************************************************************************* */
TEST(BearingRangeFactor, 3D) { // TODO(frank): this test is disabled (for now) because the macros below are
// Serialize the factor // incompatible with the Unit3 localCoordinates. See testBearingFactor...
std::string serialized = serializeXML(factor3D); //TEST(BearingRangeFactor, 3D) {
// // Serialize the factor
// And de-serialize it // std::string serialized = serializeXML(factor3D);
BearingRangeFactor3D factor; //
deserializeXML(serialized, factor); // // And de-serialize it
// BearingRangeFactor3D factor;
// Set the linearization point // deserializeXML(serialized, factor);
Values values; //
values.insert(poseKey, Pose3()); // // Set the linearization point
values.insert(pointKey, Point3(1, 0, 0)); // Values values;
// values.insert(poseKey, Pose3());
EXPECT_CORRECT_EXPRESSION_JACOBIANS(factor.expression(poseKey, pointKey), // values.insert(pointKey, Point3(1, 0, 0));
values, 1e-7, 1e-5); //
EXPECT_CORRECT_FACTOR_JACOBIANS(factor, values, 1e-7, 1e-5); // EXPECT_CORRECT_EXPRESSION_JACOBIANS(factor.expression(poseKey, pointKey),
} // values, 1e-7, 1e-5);
// EXPECT_CORRECT_FACTOR_JACOBIANS(factor, values, 1e-7, 1e-5);
//}
/* ************************************************************************* */ /* ************************************************************************* */
int main() { int main() {