From 94fda5dd5a97969974d9ed381afa4713b2e4f7f5 Mon Sep 17 00:00:00 2001 From: Varun Agrawal Date: Sun, 6 Oct 2024 11:08:02 -0400 Subject: [PATCH] take descriptive comment all the way --- gtsam/hybrid/HybridGaussianFactorGraph.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gtsam/hybrid/HybridGaussianFactorGraph.cpp b/gtsam/hybrid/HybridGaussianFactorGraph.cpp index 7dfa56e77..5b26a623a 100644 --- a/gtsam/hybrid/HybridGaussianFactorGraph.cpp +++ b/gtsam/hybrid/HybridGaussianFactorGraph.cpp @@ -305,6 +305,9 @@ static std::shared_ptr createDiscreteFactor( // Negative logspace version of: // exp(-factor->error(kEmpty)) / conditional->normalizationConstant(); + // = exp(-factor->error(kEmpty)) * \sqrt{|2πΣ|}; + // log = -(-factor->error(kEmpty) + log(\sqrt{|2πΣ|})) + // = factor->error(kEmpty) - log(\sqrt{|2πΣ|}) // negLogConstant gives `-log(k)` // which is `-log(k) = log(1/k) = log(\sqrt{|2πΣ|})`. return factor->error(kEmpty) - conditional->negLogConstant();