From 94aa96e00a9bb21e7cccb75219c614d1a91653ff Mon Sep 17 00:00:00 2001
From: Jose Luis Blanco Claraco <joseluisblancoc@gmail.com>
Date: Mon, 8 Nov 2021 22:41:59 +0100
Subject: [PATCH] prefer semicolon in definitions

---
 gtsam/base/Matrix.h                     | 20 ++++++++++----------
 gtsam/base/Vector.h                     | 20 ++++++++++----------
 gtsam/geometry/Pose2.cpp                |  2 +-
 gtsam/geometry/Pose3.cpp                |  2 +-
 gtsam/geometry/concepts.h               |  2 +-
 gtsam/navigation/MagPoseFactor.h        |  2 +-
 gtsam_unstable/slam/PoseBetweenFactor.h |  2 +-
 gtsam_unstable/slam/PosePriorFactor.h   |  2 +-
 8 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/gtsam/base/Matrix.h b/gtsam/base/Matrix.h
index 26f03f3e3..61c61a5af 100644
--- a/gtsam/base/Matrix.h
+++ b/gtsam/base/Matrix.h
@@ -57,17 +57,17 @@ using Matrix7##N = Eigen::Matrix<double, 7, N>;  \
 using Matrix8##N = Eigen::Matrix<double, 8, N>;  \
 using Matrix9##N = Eigen::Matrix<double, 9, N>;  \
 static const Eigen::MatrixBase<Matrix##N>::IdentityReturnType I_##N##x##N = Matrix##N::Identity(); \
-static const Eigen::MatrixBase<Matrix##N>::ConstantReturnType Z_##N##x##N = Matrix##N::Zero()
+static const Eigen::MatrixBase<Matrix##N>::ConstantReturnType Z_##N##x##N = Matrix##N::Zero();
 
-GTSAM_MAKE_MATRIX_DEFS(1);
-GTSAM_MAKE_MATRIX_DEFS(2);
-GTSAM_MAKE_MATRIX_DEFS(3);
-GTSAM_MAKE_MATRIX_DEFS(4);
-GTSAM_MAKE_MATRIX_DEFS(5);
-GTSAM_MAKE_MATRIX_DEFS(6);
-GTSAM_MAKE_MATRIX_DEFS(7);
-GTSAM_MAKE_MATRIX_DEFS(8);
-GTSAM_MAKE_MATRIX_DEFS(9);
+GTSAM_MAKE_MATRIX_DEFS(1)
+GTSAM_MAKE_MATRIX_DEFS(2)
+GTSAM_MAKE_MATRIX_DEFS(3)
+GTSAM_MAKE_MATRIX_DEFS(4)
+GTSAM_MAKE_MATRIX_DEFS(5)
+GTSAM_MAKE_MATRIX_DEFS(6)
+GTSAM_MAKE_MATRIX_DEFS(7)
+GTSAM_MAKE_MATRIX_DEFS(8)
+GTSAM_MAKE_MATRIX_DEFS(9)
 
 // Matrix expressions for accessing parts of matrices
 typedef Eigen::Block<Matrix> SubMatrix;
diff --git a/gtsam/base/Vector.h b/gtsam/base/Vector.h
index 8a7eb1d55..35c68c4b4 100644
--- a/gtsam/base/Vector.h
+++ b/gtsam/base/Vector.h
@@ -49,17 +49,17 @@ static const Eigen::MatrixBase<Vector3>::ConstantReturnType Z_3x1 = Vector3::Zer
 // VectorN and Z_Nx1, for N=1..9
 #define GTSAM_MAKE_VECTOR_DEFS(N)                \
   using Vector##N = Eigen::Matrix<double, N, 1>; \
-  static const Eigen::MatrixBase<Vector##N>::ConstantReturnType Z_##N##x1 = Vector##N::Zero()
+  static const Eigen::MatrixBase<Vector##N>::ConstantReturnType Z_##N##x1 = Vector##N::Zero();
 
-GTSAM_MAKE_VECTOR_DEFS(4);
-GTSAM_MAKE_VECTOR_DEFS(5);
-GTSAM_MAKE_VECTOR_DEFS(6);
-GTSAM_MAKE_VECTOR_DEFS(7);
-GTSAM_MAKE_VECTOR_DEFS(8);
-GTSAM_MAKE_VECTOR_DEFS(9);
-GTSAM_MAKE_VECTOR_DEFS(10);
-GTSAM_MAKE_VECTOR_DEFS(11);
-GTSAM_MAKE_VECTOR_DEFS(12);
+GTSAM_MAKE_VECTOR_DEFS(4)
+GTSAM_MAKE_VECTOR_DEFS(5)
+GTSAM_MAKE_VECTOR_DEFS(6)
+GTSAM_MAKE_VECTOR_DEFS(7)
+GTSAM_MAKE_VECTOR_DEFS(8)
+GTSAM_MAKE_VECTOR_DEFS(9)
+GTSAM_MAKE_VECTOR_DEFS(10)
+GTSAM_MAKE_VECTOR_DEFS(11)
+GTSAM_MAKE_VECTOR_DEFS(12)
 
 typedef Eigen::VectorBlock<Vector> SubVector;
 typedef Eigen::VectorBlock<const Vector> ConstSubVector;
diff --git a/gtsam/geometry/Pose2.cpp b/gtsam/geometry/Pose2.cpp
index 8dafffee8..a0b3d502e 100644
--- a/gtsam/geometry/Pose2.cpp
+++ b/gtsam/geometry/Pose2.cpp
@@ -28,7 +28,7 @@ using namespace std;
 namespace gtsam {
 
 /** instantiate concept checks */
-GTSAM_CONCEPT_POSE_INST(Pose2);
+GTSAM_CONCEPT_POSE_INST(Pose2)
 
 static const Rot2 R_PI_2(Rot2::fromCosSin(0., 1.));
 
diff --git a/gtsam/geometry/Pose3.cpp b/gtsam/geometry/Pose3.cpp
index 4bfb574b1..f8c61fd59 100644
--- a/gtsam/geometry/Pose3.cpp
+++ b/gtsam/geometry/Pose3.cpp
@@ -30,7 +30,7 @@ using std::vector;
 using Point3Pairs = vector<Point3Pair>;
 
 /** instantiate concept checks */
-GTSAM_CONCEPT_POSE_INST(Pose3);
+GTSAM_CONCEPT_POSE_INST(Pose3)
 
 /* ************************************************************************* */
 Pose3::Pose3(const Pose2& pose2) :
diff --git a/gtsam/geometry/concepts.h b/gtsam/geometry/concepts.h
index a313d4448..bafb62418 100644
--- a/gtsam/geometry/concepts.h
+++ b/gtsam/geometry/concepts.h
@@ -71,6 +71,6 @@ private:
  */
 
 /** Pose Concept macros */
-#define GTSAM_CONCEPT_POSE_INST(T) template class gtsam::PoseConcept<T>
+#define GTSAM_CONCEPT_POSE_INST(T) template class gtsam::PoseConcept<T>;
 #define GTSAM_CONCEPT_POSE_TYPE(T) using _gtsam_PoseConcept##T = gtsam::PoseConcept<T>;
 
diff --git a/gtsam/navigation/MagPoseFactor.h b/gtsam/navigation/MagPoseFactor.h
index c0a6a7ece..da2a54ce9 100644
--- a/gtsam/navigation/MagPoseFactor.h
+++ b/gtsam/navigation/MagPoseFactor.h
@@ -46,7 +46,7 @@ class MagPoseFactor: public NoiseModelFactor1<POSE> {
 
   /// Concept check by type.
   GTSAM_CONCEPT_TESTABLE_TYPE(POSE)
-  GTSAM_CONCEPT_POSE_TYPE(POSE);
+  GTSAM_CONCEPT_POSE_TYPE(POSE)
 
  public:
   ~MagPoseFactor() override {}
diff --git a/gtsam_unstable/slam/PoseBetweenFactor.h b/gtsam_unstable/slam/PoseBetweenFactor.h
index 444da275d..a6c583418 100644
--- a/gtsam_unstable/slam/PoseBetweenFactor.h
+++ b/gtsam_unstable/slam/PoseBetweenFactor.h
@@ -41,7 +41,7 @@ namespace gtsam {
 
     /** concept check by type */
     GTSAM_CONCEPT_TESTABLE_TYPE(POSE)
-    GTSAM_CONCEPT_POSE_TYPE(POSE);
+    GTSAM_CONCEPT_POSE_TYPE(POSE)
   public:
 
     // shorthand for a smart pointer to a factor
diff --git a/gtsam_unstable/slam/PosePriorFactor.h b/gtsam_unstable/slam/PosePriorFactor.h
index 665bb4680..f657fc443 100644
--- a/gtsam_unstable/slam/PosePriorFactor.h
+++ b/gtsam_unstable/slam/PosePriorFactor.h
@@ -38,7 +38,7 @@ namespace gtsam {
 
     /** concept check by type */
     GTSAM_CONCEPT_TESTABLE_TYPE(POSE)
-    GTSAM_CONCEPT_POSE_TYPE(POSE);
+    GTSAM_CONCEPT_POSE_TYPE(POSE)
   public:
 
     /// shorthand for a smart pointer to a factor