From 92b829dd55654b708509e911fb84a1720b30195b Mon Sep 17 00:00:00 2001
From: Varun Agrawal <varagrawal@gmail.com>
Date: Mon, 23 Sep 2024 15:55:19 -0400
Subject: [PATCH] remove normalizationConstant()

---
 gtsam/inference/Conditional-inst.h | 10 ----------
 gtsam/inference/Conditional.h      |  3 ---
 2 files changed, 13 deletions(-)

diff --git a/gtsam/inference/Conditional-inst.h b/gtsam/inference/Conditional-inst.h
index ca4d0981f..c21a75d26 100644
--- a/gtsam/inference/Conditional-inst.h
+++ b/gtsam/inference/Conditional-inst.h
@@ -63,12 +63,6 @@ double Conditional<FACTOR, DERIVEDCONDITIONAL>::negLogConstant() const {
   throw std::runtime_error("Conditional::negLogConstant is not implemented");
 }
 
-/* ************************************************************************* */
-template <class FACTOR, class DERIVEDCONDITIONAL>
-double Conditional<FACTOR, DERIVEDCONDITIONAL>::normalizationConstant() const {
-  return std::exp(-negLogConstant());
-}
-
 /* ************************************************************************* */
 template <class FACTOR, class DERIVEDCONDITIONAL>
 template <class VALUES>
@@ -81,10 +75,6 @@ bool Conditional<FACTOR, DERIVEDCONDITIONAL>::CheckInvariants(
   const double logProb = conditional.logProbability(values);
   if (std::abs(prob_or_density - std::exp(logProb)) > 1e-9)
     return false;  // logProb is not consistent with prob_or_density
-  if (std::abs(conditional.negLogConstant() -
-               (-std::log(conditional.normalizationConstant()))) > 1e-9)
-    return false;  // log normalization constant is not consistent with
-                   // normalization constant
   const double error = conditional.error(values);
   if (error < 0.0) return false;  // prob_or_density is negative.
   const double expected = -(conditional.negLogConstant() + error);
diff --git a/gtsam/inference/Conditional.h b/gtsam/inference/Conditional.h
index f37a1b7a4..f9da36b7b 100644
--- a/gtsam/inference/Conditional.h
+++ b/gtsam/inference/Conditional.h
@@ -172,9 +172,6 @@ namespace gtsam {
      */
     virtual double negLogConstant() const;
 
-    /** Non-virtual, negate and exponentiate negLogConstant. */
-    double normalizationConstant() const;
-
     /// @}
     /// @name Advanced Interface
     /// @{