diff --git a/gtsam/inference/BayesTree-inst.h b/gtsam/inference/BayesTree-inst.h index c65e2ddc2..f97972e5a 100644 --- a/gtsam/inference/BayesTree-inst.h +++ b/gtsam/inference/BayesTree-inst.h @@ -338,6 +338,7 @@ namespace gtsam { /* ************************************************************************* */ // Find the lowest common ancestor of two cliques + // TODO(Varun): consider implementing this as a Range Minimum Query template static std::shared_ptr findLowestCommonAncestor( const std::shared_ptr& C1, const std::shared_ptr& C2) { @@ -360,7 +361,7 @@ namespace gtsam { /* ************************************************************************* */ // Given the clique P(F:S) and the ancestor clique B - // Return the Bayes tree P(S\B | S \cap B) + // Return the Bayes tree P(S\B | S \cap B), where \cap is intersection template static auto factorInto( const std::shared_ptr& p_F_S, const std::shared_ptr& B, diff --git a/gtsam/inference/BayesTreeCliqueBase-inst.h b/gtsam/inference/BayesTreeCliqueBase-inst.h index 9e687be6b..40fa5b9a4 100644 --- a/gtsam/inference/BayesTreeCliqueBase-inst.h +++ b/gtsam/inference/BayesTreeCliqueBase-inst.h @@ -107,7 +107,7 @@ namespace gtsam { // The shortcut density is a conditional P(S|B) of the separator of this // clique on the root or common ancestor B. We can compute it recursively from // the parent shortcut P(Sp|B) as \int P(Fp|Sp) P(Sp|B), where Fp are the - // frontal nodes in p + // frontal nodes in pthe parent p, and Sp the separator of the parent. /* ************************************************************************* */ template @@ -141,7 +141,8 @@ namespace gtsam { /* *********************************************************************** */ // Separator marginal, uses separator marginal of parent recursively // Calculates P(S) = \int P(Cp) = \int P(Fp|Sp) P(Sp) - // if P(Sp) is not cached, it will call separatorMarginal on the parent + // if P(Sp) is not cached, it will call separatorMarginal on the parent. + // Here again, Fp and Sp are the frontal nodes and separator in the parent p. /* *********************************************************************** */ template typename BayesTreeCliqueBase::FactorGraphType