12345qiupeng
/
gtsam
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Adding comment relating to issue and move around fix preprocessor locations

release/4.3a0
Andrew Melim 2014-12-09 11:49:13 -05:00
parent 3bd491bf66
commit 90676199dd
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
gtsam/nonlinear/Expression.h
View File

@ -206,20 +206,25 @@ private:
// with an execution trace, made up entirely of "Record" structs, see // with an execution trace, made up entirely of "Record" structs, see
// the FunctionalNode class in expression-inl.h // the FunctionalNode class in expression-inl.h
size_t size = traceSize(); size_t size = traceSize();
// Windows does not support variable length arrays, so memory must be dynamically
// allocated on Visual Studio. For more information see the issue below
// https://bitbucket.org/gtborg/gtsam/issue/178/vlas-unsupported-in-visual-studio
#ifdef _MSC_VER #ifdef _MSC_VER
ExecutionTraceStorage* traceStorage = new ExecutionTraceStorage[size]; ExecutionTraceStorage* traceStorage = new ExecutionTraceStorage[size];
ExecutionTrace<T> trace;
T value(traceExecution(values, trace, traceStorage));
trace.startReverseAD1(jacobians);
delete[] traceStorage;
return value;
#else #else
ExecutionTraceStorage traceStorage[size]; ExecutionTraceStorage traceStorage[size];
#endif
ExecutionTrace<T> trace; ExecutionTrace<T> trace;
T value(traceExecution(values, trace, traceStorage)); T value(traceExecution(values, trace, traceStorage));
trace.startReverseAD1(jacobians); trace.startReverseAD1(jacobians);
return value;
#ifdef _MSC_VER
delete[] traceStorage;
#endif #endif
return value;
} }
// be very selective on who can access these private methods: // be very selective on who can access these private methods: