Two more methods are static

release/4.3a0
Frank Dellaert 2024-10-15 16:50:28 +09:00
parent ba7674d5fb
commit 8cc5171cbc
2 changed files with 4 additions and 4 deletions

View File

@ -650,7 +650,7 @@ namespace gtsam {
template<typename L, typename Y> template<typename L, typename Y>
template<typename It, typename ValueIt> template<typename It, typename ValueIt>
typename DecisionTree<L, Y>::NodePtr DecisionTree<L, Y>::build( typename DecisionTree<L, Y>::NodePtr DecisionTree<L, Y>::build(
It begin, It end, ValueIt beginY, ValueIt endY) const { It begin, It end, ValueIt beginY, ValueIt endY) {
// get crucial counts // get crucial counts
size_t nrChoices = begin->second; size_t nrChoices = begin->second;
size_t size = endY - beginY; size_t size = endY - beginY;
@ -692,7 +692,7 @@ namespace gtsam {
template<typename L, typename Y> template<typename L, typename Y>
template<typename It, typename ValueIt> template<typename It, typename ValueIt>
typename DecisionTree<L, Y>::NodePtr DecisionTree<L, Y>::create( typename DecisionTree<L, Y>::NodePtr DecisionTree<L, Y>::create(
It begin, It end, ValueIt beginY, ValueIt endY) const { It begin, It end, ValueIt beginY, ValueIt endY) {
auto node = build(begin, end, beginY, endY); auto node = build(begin, end, beginY, endY);
if (auto choice = std::dynamic_pointer_cast<const Choice>(node)) { if (auto choice = std::dynamic_pointer_cast<const Choice>(node)) {
return Choice::Unique(choice); return Choice::Unique(choice);

View File

@ -154,7 +154,7 @@ namespace gtsam {
* and Y values * and Y values
*/ */
template <typename It, typename ValueIt> template <typename It, typename ValueIt>
NodePtr build(It begin, It end, ValueIt beginY, ValueIt endY) const; static NodePtr build(It begin, It end, ValueIt beginY, ValueIt endY);
/** Internal helper function to create from /** Internal helper function to create from
* keys, cardinalities, and Y values. * keys, cardinalities, and Y values.
@ -162,7 +162,7 @@ namespace gtsam {
* before we prune in a top-down fashion. * before we prune in a top-down fashion.
*/ */
template <typename It, typename ValueIt> template <typename It, typename ValueIt>
NodePtr create(It begin, It end, ValueIt beginY, ValueIt endY) const; static NodePtr create(It begin, It end, ValueIt beginY, ValueIt endY);
/** /**
* @brief Convert from a DecisionTree<L, X> to DecisionTree<L, Y>. * @brief Convert from a DecisionTree<L, X> to DecisionTree<L, Y>.