12345qiupeng
/
gtsam
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix warning: ‘beta’ may be used uninitialized in this function

release/4.3a0
Jose Luis Blanco-Claraco 2024-10-29 08:05:27 +01:00
parent d48b1fc840
commit 8bd4738f47
No known key found for this signature in database
GPG Key ID: D443304FBD70A641
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gtsam/nonlinear/NonlinearConjugateGradientOptimizer.h
View File

@ -21,6 +21,8 @@
#include <gtsam/base/Manifold.h> #include <gtsam/base/Manifold.h>
#include <gtsam/nonlinear/NonlinearOptimizer.h> #include <gtsam/nonlinear/NonlinearOptimizer.h>
#include <stdexcept>
namespace gtsam { namespace gtsam {
/// Fletcher-Reeves formula for computing β, the direction of steepest descent. /// Fletcher-Reeves formula for computing β, the direction of steepest descent.
@ -247,6 +249,9 @@ std::tuple<V, int> nonlinearConjugateGradient(
case DirectionMethod::DaiYuan: case DirectionMethod::DaiYuan:
beta = DaiYuan(currentGradient, prevGradient, direction); beta = DaiYuan(currentGradient, prevGradient, direction);
break; break;
default:
throw std::runtime_error(
"NonlinearConjugateGradientOptimizer: Invalid directionMethod");
} }
direction = currentGradient + (beta * direction); direction = currentGradient + (beta * direction);