From 5cc5c82b26ef768b8181ea1dd72533095cc21664 Mon Sep 17 00:00:00 2001 From: chrisbeall Date: Mon, 22 May 2017 18:11:35 -0400 Subject: [PATCH] -Add virtual destructor to PreintegratedRotationParams -Add namespace so GTSAM_VALUE_EXPORT macro can be used in projects outside of gtsam --- gtsam/base/GenericValue.h | 2 +- gtsam/navigation/PreintegratedRotation.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/gtsam/base/GenericValue.h b/gtsam/base/GenericValue.h index 5b59f4872..93a7d0db5 100644 --- a/gtsam/base/GenericValue.h +++ b/gtsam/base/GenericValue.h @@ -190,7 +190,7 @@ public: } /// use this macro instead of BOOST_CLASS_EXPORT for GenericValues -#define GTSAM_VALUE_EXPORT(Type) BOOST_CLASS_EXPORT(GenericValue) +#define GTSAM_VALUE_EXPORT(Type) BOOST_CLASS_EXPORT(gtsam::GenericValue) }; diff --git a/gtsam/navigation/PreintegratedRotation.h b/gtsam/navigation/PreintegratedRotation.h index 88d9c6437..cb40774f4 100644 --- a/gtsam/navigation/PreintegratedRotation.h +++ b/gtsam/navigation/PreintegratedRotation.h @@ -35,6 +35,8 @@ struct PreintegratedRotationParams { PreintegratedRotationParams() : gyroscopeCovariance(I_3x3) {} + virtual ~PreintegratedRotationParams() {} + virtual void print(const std::string& s) const; virtual bool equals(const PreintegratedRotationParams& other, double tol=1e-9) const;