From 8b00840169e8c481376f03051327847ae74f842a Mon Sep 17 00:00:00 2001 From: Varun Agrawal Date: Mon, 9 Mar 2020 16:33:56 -0400 Subject: [PATCH] removed header bloat and added reference comment for fpEqual implementation --- gtsam/base/Matrix.h | 1 + gtsam/base/Vector.cpp | 6 +++++- gtsam/base/Vector.h | 2 -- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/gtsam/base/Matrix.h b/gtsam/base/Matrix.h index 1ee1a6c4a..fa70e5b00 100644 --- a/gtsam/base/Matrix.h +++ b/gtsam/base/Matrix.h @@ -17,6 +17,7 @@ * @author Frank Dellaert * @author Alex Cunningham * @author Alex Hagiopol + * @author Varun Agrawal */ // \callgraph diff --git a/gtsam/base/Vector.cpp b/gtsam/base/Vector.cpp index 8c8b15416..beec030ba 100644 --- a/gtsam/base/Vector.cpp +++ b/gtsam/base/Vector.cpp @@ -34,7 +34,11 @@ using namespace std; namespace gtsam { -/* ************************************************************************* */ +/* ************************************************************************* + * References: + * 1. https://randomascii.wordpress.com/2012/02/25/comparing-floating-point-numbers-2012-edition/ + * 2. https://floating-point-gui.de/errors/comparison/ + * ************************************************************************* */ bool fpEqual(double a, double b, double tol) { using std::abs; using std::isnan; diff --git a/gtsam/base/Vector.h b/gtsam/base/Vector.h index 035a6fa87..576717a0c 100644 --- a/gtsam/base/Vector.h +++ b/gtsam/base/Vector.h @@ -27,9 +27,7 @@ #include #include -#include #include -#include #include namespace gtsam {