diff --git a/.cproject b/.cproject index cf0ec25f8..5d3496e1d 100644 --- a/.cproject +++ b/.cproject @@ -1,17 +1,19 @@ - + + + + + - - @@ -52,13 +54,13 @@ + + - - @@ -97,13 +99,13 @@ + + - - @@ -315,6 +317,14 @@ true true + + make + -j2 + testGaussianFactor.run + true + true + true + make -j2 @@ -341,7 +351,6 @@ make - tests/testBayesTree.run true false @@ -349,7 +358,6 @@ make - testBinaryBayesNet.run true false @@ -397,7 +405,6 @@ make - testSymbolicBayesNet.run true false @@ -405,7 +412,6 @@ make - tests/testSymbolicFactor.run true false @@ -413,7 +419,6 @@ make - testSymbolicFactorGraph.run true false @@ -429,20 +434,11 @@ make - tests/testBayesTree true false true - - make - -j2 - testGaussianFactor.run - true - true - true - make -j5 @@ -531,22 +527,6 @@ false true - - make - -j2 - tests/testPose2.run - true - true - true - - - make - -j2 - tests/testPose3.run - true - true - true - make -j2 @@ -563,6 +543,22 @@ true true + + make + -j2 + tests/testPose2.run + true + true + true + + + make + -j2 + tests/testPose3.run + true + true + true + make -j2 @@ -587,26 +583,42 @@ true true - + make - -j2 - all + -j5 + testValues.run true true true - + make - -j2 - check + -j5 + testOrdering.run true true true - + make - -j2 - clean + -j5 + testKey.run + true + true + true + + + make + -j5 + testLinearContainerFactor.run + true + true + true + + + make + -j6 -j8 + testWhiteNoiseFactor.run true true true @@ -659,42 +671,26 @@ true true - + make - -j5 - testValues.run + -j2 + all true true true - + make - -j5 - testOrdering.run + -j2 + check true true true - + make - -j5 - testKey.run - true - true - true - - - make - -j5 - testLinearContainerFactor.run - true - true - true - - - make - -j6 -j8 - testWhiteNoiseFactor.run + -j2 + clean true true true @@ -1093,7 +1089,6 @@ make - testGraph.run true false @@ -1101,7 +1096,6 @@ make - testJunctionTree.run true false @@ -1109,7 +1103,6 @@ make - testSymbolicBayesNetB.run true false @@ -1277,7 +1270,6 @@ make - testErrors.run true false @@ -1323,6 +1315,14 @@ true true + + make + -j2 + testGaussianFactor.run + true + true + true + make -j2 @@ -1403,14 +1403,6 @@ true true - - make - -j2 - testGaussianFactor.run - true - true - true - make -j2 @@ -1717,6 +1709,7 @@ make + testSimulated2DOriented.run true false @@ -1756,6 +1749,7 @@ make + testSimulated2D.run true false @@ -1763,6 +1757,7 @@ make + testSimulated3D.run true false @@ -1976,10 +1971,10 @@ true true - + make -j5 - VisualSLAMExample.run + SFMExample.run true true true @@ -2016,6 +2011,14 @@ true true + + make + -j5 + SFMExample_bal.run + true + true + true + make -j4 @@ -2034,6 +2037,7 @@ make + tests/testGaussianISAM2 true false @@ -2055,6 +2059,102 @@ true true + + make + -j2 + testRot3.run + true + true + true + + + make + -j2 + testRot2.run + true + true + true + + + make + -j2 + testPose3.run + true + true + true + + + make + -j2 + timeRot3.run + true + true + true + + + make + -j2 + testPose2.run + true + true + true + + + make + -j2 + testCal3_S2.run + true + true + true + + + make + -j2 + testSimpleCamera.run + true + true + true + + + make + -j2 + testHomography2.run + true + true + true + + + make + -j2 + testCalibratedCamera.run + true + true + true + + + make + -j2 + check + true + true + true + + + make + -j2 + clean + true + true + true + + + make + -j2 + testPoint2.run + true + true + true + make -j3 @@ -2256,7 +2356,6 @@ cpack - -G DEB true false @@ -2264,7 +2363,6 @@ cpack - -G RPM true false @@ -2272,7 +2370,6 @@ cpack - -G TGZ true false @@ -2280,7 +2377,6 @@ cpack - --config CPackSourceConfig.cmake true false @@ -2446,98 +2542,34 @@ true true - + make - -j2 - testRot3.run + -j5 + testSpirit.run true true true - + make - -j2 - testRot2.run + -j5 + testWrap.run true true true - + make - -j2 - testPose3.run + -j5 + check.wrap true true true - + make - -j2 - timeRot3.run - true - true - true - - - make - -j2 - testPose2.run - true - true - true - - - make - -j2 - testCal3_S2.run - true - true - true - - - make - -j2 - testSimpleCamera.run - true - true - true - - - make - -j2 - testHomography2.run - true - true - true - - - make - -j2 - testCalibratedCamera.run - true - true - true - - - make - -j2 - check - true - true - true - - - make - -j2 - clean - true - true - true - - - make - -j2 - testPoint2.run + -j5 + wrap true true true @@ -2581,38 +2613,6 @@ false true - - make - -j5 - testSpirit.run - true - true - true - - - make - -j5 - testWrap.run - true - true - true - - - make - -j5 - check.wrap - true - true - true - - - make - -j5 - wrap - true - true - true - diff --git a/gtsam/discrete/DecisionTree-inl.h b/gtsam/discrete/DecisionTree-inl.h index ae6785644..9319a1541 100644 --- a/gtsam/discrete/DecisionTree-inl.h +++ b/gtsam/discrete/DecisionTree-inl.h @@ -421,7 +421,7 @@ namespace gtsam { DecisionTree::DecisionTree(const std::vector& labelCs, const std::string& table) { - // Convert std::string to doubles + // Convert std::string to values of type Y std::vector ys; std::istringstream iss(table); copy(std::istream_iterator(iss), std::istream_iterator(), diff --git a/gtsam/discrete/DecisionTree.h b/gtsam/discrete/DecisionTree.h index fe392ec7a..ecf03ad5d 100644 --- a/gtsam/discrete/DecisionTree.h +++ b/gtsam/discrete/DecisionTree.h @@ -28,7 +28,7 @@ namespace gtsam { /** - * Algebraic Decision Trees + * Decision Tree * L = label for variables * Y = function range (any algebra), e.g., bool, int, double */ @@ -44,7 +44,7 @@ namespace gtsam { /** A label annotated with cardinality */ typedef std::pair LabelC; - /** DD's consist of Leaf and Choice nodes, both subclasses of Node */ + /** DTs consist of Leaf and Choice nodes, both subclasses of Node */ class Leaf; class Choice; @@ -60,16 +60,14 @@ namespace gtsam { // Constructor Node() { #ifdef DT_DEBUG_MEMORY - std::cout << ++nrNodes << " constructed " << id() << std::endl; std::cout.flush(); - + std::cout << ++nrNodes << " constructed " << id() << std::endl; std::cout.flush(); #endif } // Destructor virtual ~Node() { #ifdef DT_DEBUG_MEMORY - std::cout << --nrNodes << " destructed " << id() << std::endl; std::cout.flush(); - + std::cout << --nrNodes << " destructed " << id() << std::endl; std::cout.flush(); #endif } @@ -94,10 +92,10 @@ namespace gtsam { public: - /** A function is a shared pointer to the root of an ADD */ + /** A function is a shared pointer to the root of a DT */ typedef typename Node::Ptr NodePtr; - /* an AlgebraicDecisionTree just contains the root */ + /* a DecisionTree just contains the root */ NodePtr root_; protected: @@ -128,7 +126,7 @@ namespace gtsam { /** Allow Label+Cardinality for convenience */ DecisionTree(const LabelC& label, const Y& y1, const Y& y2); - /** Create from keys and string table */ + /** Create from keys and a corresponding vector of values */ DecisionTree(const std::vector& labelCs, const std::vector& ys); /** Create from keys and string table */ @@ -138,7 +136,7 @@ namespace gtsam { template DecisionTree(Iterator begin, Iterator end, const L& label); - /** Create DecisionTree from others others (binary version) */ + /** Create DecisionTree from two others */ DecisionTree(const L& label, // const DecisionTree& f0, const DecisionTree& f1);