From 91b662540570878589dc3335370015037d2b01dc Mon Sep 17 00:00:00 2001 From: ShuangLiu1992 Date: Fri, 27 Jan 2023 16:37:20 +0000 Subject: [PATCH 1/2] fix ambiguous template variadic variable issue fix fix ambiguous template variadic variable issue on non-gcc compilers https://stackoverflow.com/questions/56943558/c-partial-template-argument-deduction-for-function-with-variadic-pack-produces --- gtsam/geometry/CameraSet.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtsam/geometry/CameraSet.h b/gtsam/geometry/CameraSet.h index 1db86cfde..901017bb3 100644 --- a/gtsam/geometry/CameraSet.h +++ b/gtsam/geometry/CameraSet.h @@ -153,7 +153,7 @@ class CameraSet : public std::vector> { * full matrices and vectors and pass it to the pointer * version of the function */ - template + template > Vector reprojectionError(const POINT& point, const ZVector& measured, OptArgs&... args) const { // pass it to the pointer version of the function From 4929827f70947eaca85371b246e4ad14346b058f Mon Sep 17 00:00:00 2001 From: ShuangLiu1992 Date: Fri, 27 Jan 2023 16:43:27 +0000 Subject: [PATCH 2/2] fix SmartFactorBase as well --- gtsam/slam/SmartFactorBase.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtsam/slam/SmartFactorBase.h b/gtsam/slam/SmartFactorBase.h index 80dde3563..e0540cc41 100644 --- a/gtsam/slam/SmartFactorBase.h +++ b/gtsam/slam/SmartFactorBase.h @@ -243,7 +243,7 @@ protected: * to the matrices and vectors that will be used to store the results instead * of pointers. */ - template + template> Vector unwhitenedError( const Cameras& cameras, const POINT& point, OptArgs&&... optArgs) const {