12345qiupeng
/
gtsam
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make operator-> const 

Having this operator non-const is awkward as operator* is const. This
sometimes leads to writing:
  (*obj).data; instead of obj->data;
which is unexpected....
release/4.3a0
Sébastien Gonzalve 2024-11-09 20:20:37 +01:00
parent a95d816f37
commit 733e919570
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gtsam/nonlinear/Values.h
View File

@ -189,7 +189,7 @@ namespace gtsam {
const_iterator_type it_; const_iterator_type it_;
deref_iterator(const_iterator_type it) : it_(it) {} deref_iterator(const_iterator_type it) : it_(it) {}
ConstKeyValuePair operator*() const { return {it_->first, *(it_->second)}; } ConstKeyValuePair operator*() const { return {it_->first, *(it_->second)}; }
std::unique_ptr<ConstKeyValuePair> operator->() { std::unique_ptr<ConstKeyValuePair> operator->() const {
return std::make_unique<ConstKeyValuePair>(it_->first, *(it_->second)); return std::make_unique<ConstKeyValuePair>(it_->first, *(it_->second));
} }
bool operator==(const deref_iterator& other) const { bool operator==(const deref_iterator& other) const {