Merge pull request #1488 from borglab/fix-default-shared-libs

Go back to default shared libraries, and fix unhandled case.

.github/scripts/unix.sh

@@ -72,7 +72,6 @@ function configure()
       -DGTSAM_POSE3_EXPMAP=${GTSAM_POSE3_EXPMAP:-ON} \
       -DGTSAM_USE_SYSTEM_EIGEN=${GTSAM_USE_SYSTEM_EIGEN:-OFF} \
       -DGTSAM_USE_SYSTEM_METIS=${GTSAM_USE_SYSTEM_METIS:-OFF} \
-      -DGTSAM_FORCE_SHARED_LIB=${GTSAM_FORCE_SHARED_LIB:-OFF} \
       -DGTSAM_BUILD_WITH_MARCH_NATIVE=OFF \
       -DGTSAM_SINGLE_TEST_EXE=OFF
 }

.github/workflows/build-special.yml

@@ -12,7 +12,6 @@ jobs:
       CTEST_PARALLEL_LEVEL: 2
       CMAKE_BUILD_TYPE: ${{ matrix.build_type }}
       GTSAM_BUILD_UNSTABLE: ON
-      GTSAM_FORCE_SHARED_LIB: ON  # Make shared library to save memory on CI
 
     strategy:
       fail-fast: false

cmake/HandleGeneralOptions.cmake

@@ -14,7 +14,7 @@ if(GTSAM_UNSTABLE_AVAILABLE)
     option(GTSAM_UNSTABLE_BUILD_PYTHON       "Enable/Disable Python wrapper for libgtsam_unstable" ON)
     option(GTSAM_UNSTABLE_INSTALL_MATLAB_TOOLBOX "Enable/Disable MATLAB wrapper for libgtsam_unstable" OFF)
 endif()
-option(GTSAM_FORCE_SHARED_LIB               "Force gtsam to be a shared library, overriding BUILD_SHARED_LIBS" OFF)
+option(GTSAM_FORCE_SHARED_LIB               "Force gtsam to be a shared library, overriding BUILD_SHARED_LIBS" ON)
 option(GTSAM_FORCE_STATIC_LIB               "Force gtsam to be a static library, overriding BUILD_SHARED_LIBS" OFF)
 option(GTSAM_USE_QUATERNIONS                "Enable/Disable using an internal Quaternion representation for rotations instead of rotation matrices. If enable, Rot3::EXPMAP is enforced by default." OFF)
 option(GTSAM_POSE3_EXPMAP                   "Enable/Disable using Pose3::EXPMAP as the default mode. If disabled, Pose3::FIRST_ORDER will be used." ON)
@@ -43,10 +43,12 @@ elseif (BUILD_SHARED_LIBS)
     message(STATUS "GTSAM is a shared library due to BUILD_SHARED_LIBS is ON")
     set(GTSAM_LIBRARY_TYPE SHARED CACHE STRING "" FORCE)
     set(GTSAM_SHARED_LIB 1 CACHE BOOL "" FORCE)
-else()
+elseif((DEFINED BUILD_SHARED_LIBS) AND (NOT BUILD_SHARED_LIBS))
     message(STATUS "GTSAM is a static library due to BUILD_SHARED_LIBS is OFF")
     set(GTSAM_LIBRARY_TYPE STATIC CACHE STRING "" FORCE)
     set(GTSAM_SHARED_LIB 0 CACHE BOOL "" FORCE)
+else()
+    message(FATAL_ERROR "Please, to unambiguously select the desired library type to use to build GTSAM, set one of GTSAM_FORCE_SHARED_LIB=ON, GTSAM_FORCE_STATIC_LIB=ON, or BUILD_SHARED_LIBS={ON/OFF}")
 endif()
 
 if(NOT MSVC AND NOT XCODE_VERSION)