From 6190e3d13ffec5b7435fd9e3d62a2a94a9d6fb9f Mon Sep 17 00:00:00 2001
From: Varun Agrawal <varagrawal@gmail.com>
Date: Wed, 25 Sep 2024 11:03:15 -0400
Subject: [PATCH] Revert "Fix compile error on Clang 18, tweak for better type
 generation"

This reverts commit e3dd4e1704bc3a2cdcd3856adc151f38bdbd7407.
---
 gtsam/inference/Factor.h | 1 -
 python/CMakeLists.txt    | 4 ++--
 python/gtsam/gtsam.tpl   | 6 +++---
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/gtsam/inference/Factor.h b/gtsam/inference/Factor.h
index f073c4975..e357a9c88 100644
--- a/gtsam/inference/Factor.h
+++ b/gtsam/inference/Factor.h
@@ -25,7 +25,6 @@
 #include <boost/serialization/nvp.hpp>
 #endif
 #include <memory>
-#include <algorithm>
 
 #include <gtsam/base/types.h>
 #include <gtsam/base/FastVector.h>
diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
index 674f17d3f..404f5ecc0 100644
--- a/python/CMakeLists.txt
+++ b/python/CMakeLists.txt
@@ -257,7 +257,7 @@ if(GTSAM_UNSTABLE_BUILD_PYTHON)
         COMMAND
         ${CMAKE_COMMAND} -E env
         "PYTHONPATH=${GTSAM_PYTHON_BUILD_DIRECTORY}/$ENV{PYTHONPATH}"
-        pybind11-stubgen -o . --enum-class-locations \"KernelFunctionType|NoiseFormat:gtsam.gtsam\" --enum-class-locations \"OrderingType:gtsam.gtsam.Ordering\" --numpy-array-use-type-var gtsam_unstable
+        pybind11-stubgen -o . --enum-class-locations \"KernelFunctionType|NoiseFormat:gtsam.gtsam\" --enum-class-locations \"OrderingType:gtsam.gtsam.Ordering\" gtsam_unstable
         DEPENDS ${GTSAM_PYTHON_DEPENDENCIES} ${GTSAM_PYTHON_TEST_FILES} ${GTSAM_PYTHON_UNSTABLE_TARGET}
         WORKING_DIRECTORY "${GTSAM_PYTHON_BUILD_DIRECTORY}/"
     )
@@ -284,7 +284,7 @@ add_custom_target(
         COMMAND
         ${CMAKE_COMMAND} -E env
         "PYTHONPATH=${GTSAM_PYTHON_BUILD_DIRECTORY}/$ENV{PYTHONPATH}"
-        pybind11-stubgen -o . --enum-class-locations \"KernelFunctionType|NoiseFormat:gtsam.gtsam\" --enum-class-locations \"OrderingType:gtsam.gtsam.Ordering\" --numpy-array-use-type-var gtsam
+        pybind11-stubgen -o . --enum-class-locations \"KernelFunctionType|NoiseFormat:gtsam.gtsam\" --enum-class-locations \"OrderingType:gtsam.gtsam.Ordering\" gtsam
         DEPENDS ${GTSAM_PYTHON_DEPENDENCIES} ${GTSAM_PYTHON_TEST_FILES} ${GTSAM_PYTHON_TARGET}
         WORKING_DIRECTORY "${GTSAM_PYTHON_BUILD_DIRECTORY}/"
 )
diff --git a/python/gtsam/gtsam.tpl b/python/gtsam/gtsam.tpl
index 6876b4ab4..c72a216a2 100644
--- a/python/gtsam/gtsam.tpl
+++ b/python/gtsam/gtsam.tpl
@@ -39,12 +39,12 @@ namespace py = pybind11;
 {module_def} {{
     m_.doc() = "pybind11 wrapper of {module_name}";
 
-// Specializations for STL classes
-#include "python/gtsam/specializations/{module_name}.h"
-
 {submodules_init}
 
 {wrapped_namespace}
 
+// Specializations for STL classes
+#include "python/gtsam/specializations/{module_name}.h"
+
 }}