From f90b941e7a514c67444c6fe1b26f7a44dfbbf554 Mon Sep 17 00:00:00 2001 From: Christian Forster Date: Tue, 2 Dec 2014 19:08:42 -0500 Subject: [PATCH 1/2] added @deprecated note in LieVector, LieMatrix, LieScalar --- gtsam/base/LieMatrix.h | 4 +++- gtsam/base/LieScalar.h | 4 +++- gtsam/base/LieVector.h | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/gtsam/base/LieMatrix.h b/gtsam/base/LieMatrix.h index f1fc69e71..783b8dd47 100644 --- a/gtsam/base/LieMatrix.h +++ b/gtsam/base/LieMatrix.h @@ -27,7 +27,9 @@ namespace gtsam { /** - * LieVector is a wrapper around vector to allow it to be a Lie type + * @deprecated: LieScalar, LieVector and LieMatrix are obsolete in GTSAM 4.0 as + * we can directly add double, Vector, and Matrix into values now, because of + * gtsam::traits. */ struct LieMatrix : public Matrix { diff --git a/gtsam/base/LieScalar.h b/gtsam/base/LieScalar.h index 5125340be..ceb0b2f09 100644 --- a/gtsam/base/LieScalar.h +++ b/gtsam/base/LieScalar.h @@ -24,7 +24,9 @@ namespace gtsam { /** - * LieScalar is a wrapper around double to allow it to be a Lie type + * @deprecated: LieScalar, LieVector and LieMatrix are obsolete in GTSAM 4.0 as + * we can directly add double, Vector, and Matrix into values now, because of + * gtsam::traits. */ struct GTSAM_EXPORT LieScalar { diff --git a/gtsam/base/LieVector.h b/gtsam/base/LieVector.h index d1b2ad78c..df39064fe 100644 --- a/gtsam/base/LieVector.h +++ b/gtsam/base/LieVector.h @@ -24,7 +24,9 @@ namespace gtsam { /** - * LieVector is a wrapper around vector to allow it to be a Lie type + * @deprecated: LieScalar, LieVector and LieMatrix are obsolete in GTSAM 4.0 as + * we can directly add double, Vector, and Matrix into values now, because of + * gtsam::traits. */ struct LieVector : public Vector { From 9c5cb1e7d3fc986c0b1b7abb602f051ac48ae0c1 Mon Sep 17 00:00:00 2001 From: Christian Forster Date: Tue, 2 Dec 2014 19:30:27 -0500 Subject: [PATCH 2/2] added compiler warning that LieVector, LieMatrix, LieScalar are deprecated --- gtsam/base/LieMatrix.h | 1 + gtsam/base/LieScalar.h | 1 + gtsam/base/LieVector.h | 1 + 3 files changed, 3 insertions(+) diff --git a/gtsam/base/LieMatrix.h b/gtsam/base/LieMatrix.h index 783b8dd47..4c250b3f2 100644 --- a/gtsam/base/LieMatrix.h +++ b/gtsam/base/LieMatrix.h @@ -19,6 +19,7 @@ #include +#warning "LieMatrix.h is deprecated. Please use Eigen::Matrix instead." #include #include #include diff --git a/gtsam/base/LieScalar.h b/gtsam/base/LieScalar.h index ceb0b2f09..c68458364 100644 --- a/gtsam/base/LieScalar.h +++ b/gtsam/base/LieScalar.h @@ -17,6 +17,7 @@ #pragma once +#warning "LieScalar.h is deprecated. Please use double/float instead." #include #include #include diff --git a/gtsam/base/LieVector.h b/gtsam/base/LieVector.h index df39064fe..94ba775cf 100644 --- a/gtsam/base/LieVector.h +++ b/gtsam/base/LieVector.h @@ -17,6 +17,7 @@ #pragma once +#warning "LieVector.h is deprecated. Please use Eigen::Vector instead." #include #include #include