From 4c4bdd4ba7630c964619bfabede55b25d89307cc Mon Sep 17 00:00:00 2001 From: p-zach Date: Wed, 16 Apr 2025 00:02:07 -0400 Subject: [PATCH] Actually the Colamd wrap is fine --- gtsam/inference/inference.i | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gtsam/inference/inference.i b/gtsam/inference/inference.i index 2b05adf89..0d7bd784e 100644 --- a/gtsam/inference/inference.i +++ b/gtsam/inference/inference.i @@ -122,11 +122,9 @@ class Ordering { template < FACTOR_GRAPH = {gtsam::NonlinearFactorGraph, gtsam::DiscreteFactorGraph, gtsam::SymbolicFactorGraph, gtsam::GaussianFactorGraph, gtsam::HybridGaussianFactorGraph}> - - // Can't have both of these Colamd implementations; the second overrides the first. - // Python wrapper is for ease of use, so choose the one that is more commonly used. + static gtsam::Ordering Colamd(const FACTOR_GRAPH& graph); - // static gtsam::Ordering Colamd(const gtsam::VariableIndex& variableIndex); + static gtsam::Ordering Colamd(const gtsam::VariableIndex& variableIndex); template < FACTOR_GRAPH = {gtsam::NonlinearFactorGraph, gtsam::DiscreteFactorGraph,