From 4789cd268282caa1e3e972e9e2ad92b6becb9f6d Mon Sep 17 00:00:00 2001 From: alexma3312 Date: Sat, 22 Aug 2020 15:20:20 -0400 Subject: [PATCH] Modify comments and move header file declaration. --- gtsam_unstable/geometry/Similarity3.cpp | 1 + gtsam_unstable/geometry/Similarity3.h | 5 ++--- gtsam_unstable/geometry/tests/testSimilarity3.cpp | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/gtsam_unstable/geometry/Similarity3.cpp b/gtsam_unstable/geometry/Similarity3.cpp index eb2868f7e..0083799ce 100644 --- a/gtsam_unstable/geometry/Similarity3.cpp +++ b/gtsam_unstable/geometry/Similarity3.cpp @@ -19,6 +19,7 @@ #include #include +#include namespace gtsam { diff --git a/gtsam_unstable/geometry/Similarity3.h b/gtsam_unstable/geometry/Similarity3.h index d09850764..018778d09 100644 --- a/gtsam_unstable/geometry/Similarity3.h +++ b/gtsam_unstable/geometry/Similarity3.h @@ -23,8 +23,6 @@ #include #include #include -#include -#include namespace gtsam { @@ -113,7 +111,8 @@ public: * |Rs*R Rs*t+ts| |Rs*R s(Rs*t+ts)| * | 0 1/s | = | 0 1 | * - * This group action satisfies the compatibility condition. + * This group action satisfies the compatibility condition. + * For more details, refer to: https://en.wikipedia.org/wiki/Group_action */ GTSAM_UNSTABLE_EXPORT Pose3 transformFrom(const Pose3& T) const; diff --git a/gtsam_unstable/geometry/tests/testSimilarity3.cpp b/gtsam_unstable/geometry/tests/testSimilarity3.cpp index 2ae0d8e82..01e33b330 100644 --- a/gtsam_unstable/geometry/tests/testSimilarity3.cpp +++ b/gtsam_unstable/geometry/tests/testSimilarity3.cpp @@ -274,6 +274,8 @@ TEST(Similarity3, GroupActionPose3) { EXPECT(assert_equal(expected_Tb2, bSa.transformFrom(Ta2))); } +// Test left group action compatibility. +// cSa*Ta = cSb*bSa*Ta TEST(Similarity3, GroupActionPose3_Compatibility) { Similarity3 bSa(Rot3::Ry(180 * degree), Point3(2, 3, 5), 2.0); Similarity3 cSb(Rot3::Ry(90 * degree), Point3(-10, -4, 0), 3.0);